From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F2A0FCB61A for ; Fri, 6 Mar 2026 15:49:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A6DD810ED6F; Fri, 6 Mar 2026 15:49:13 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="cEnu/OnA"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="REG7AcGa"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id DC5BA10ED7C for ; Fri, 6 Mar 2026 15:49:12 +0000 (UTC) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626FSvTR1369184 for ; Fri, 6 Mar 2026 15:49:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0/756cthtUIgOJKo1UJZNjKGTLA8f8YYmW1bpSBDIWY=; b=cEnu/OnAC1cBRLNl 4oQ9YSwsZrvBAX9vdKjIs9IzdOxhYHFFQ0EAkTpagLjsb1DfxR5yMosUQ3mz5pDo S0lStsQEKOV0jFVu6gcYfnTboyaow+s2cJOaGYaQfpvaYF+RmDLZPh/Ec3Q4HHzL Z4ms2RHS4O9mHg1ZDJsSdiKGKAVEjPMiGp0rVjpjmHAvTmzI7XmKLHrZcEGy0R4O 1Pn0H6H086qujpi/XmdmZdKzDTWEaQZJn0ctv0+8fOqWxpWuTHXaPT4sSIpbZi5c jEt096fLWsPp3uPV3vFuKCWSlMp0pyiUXcI3mQVepsO1b163WXom9joVA8/cXTl/ cA1vHw== Received: from mail-dl1-f71.google.com (mail-dl1-f71.google.com [74.125.82.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqrf5t1gs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 15:49:11 +0000 (GMT) Received: by mail-dl1-f71.google.com with SMTP id a92af1059eb24-1275c6fc58aso17579842c88.0 for ; Fri, 06 Mar 2026 07:49:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772812151; x=1773416951; darn=lists.freedesktop.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0/756cthtUIgOJKo1UJZNjKGTLA8f8YYmW1bpSBDIWY=; b=REG7AcGaV6CmGFvvU+7fUTxsAv+VTXIR57QPzK+L4M1//vCgqsvNpVq50l3grZ1A4G zHgbqVUAiKjwSkHCKnTPTSRJbrtZC5lz4WptZ9JJuAE5VBODSbRIO2Wqwalg/+0WRFfe nG/xXCeMU4as9V3NjVYQsAoZjv18VArqTf1wiBBOzmlzsC6TlRqM32DUSl28SF7kKVSr 6gQgmux0vdVr1teE5FVa0sezTz+tMEOK4JH7wfkQ37xKMNthd6962zP6Qbx2SYbZYc/V 7Ebb6uTQR4NaZjdYV8X27V20gll6tDs7Kc1zL9dy09Tuau3iv6lHIwK6STwR8ih1sORK GW1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772812151; x=1773416951; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0/756cthtUIgOJKo1UJZNjKGTLA8f8YYmW1bpSBDIWY=; b=jnwi2Tnjz8EEgG4VDdil45pka/p6T7MNUxg5/Zgm2Rj/OVbY/28PCd8GB49X57kTHg L9imNvnW4RD59mbNYWKjH6aKz+odPIV8kvNt2UbNCUZoGWMxK5WXVuGrv+EX+7+Aopz7 Vl9sJQ6DFm1BEbL228k/kKNTBj1ytC3LymGZQrMDZBtQXVVn7CTwsMe0cfZ1X+uaCoKl hrZPA39iOCuLyUzwtvCkm1jaUqjw9QRCTCSjV7Z0UQYnoQRkIMX1Hk68QQpiWM9Csl8A vjvSC0Kbf6KlEjisnVwFY5ZM1c36ajnQZ/JrgDWkPNzLCUDZyzPQBt5ZlV4lObOZVetU bBRQ== X-Forwarded-Encrypted: i=1; AJvYcCUAAnOJ4bsPSzdEBmHLLfN1eanBNxfpjPvjcQ1+HaB/Cy+hZ1HhDXu6AiJqCQK2EvY5DJBkTFKhY7o=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yz0eWg/MUhu7YUf/4wASoJOAu8St7HYjEzkujKlUse4guq2TryG peQEAhJvMmawCojh4B0VJzjiVu47gOGJTVFptmg6KRufsSV/hIDn4eesyHs1HPXW7EtendA91Ra jGeV4zX7+7sWvCrodcyGkgxuy/5lsiRmeJS0bAciDID9nvhpoCfKGeEONQREjsIkHOWtWloc= X-Gm-Gg: ATEYQzwoNjlA16bLTGs8UnSMyPaATu5eHVuKTPW8j3s/k6yHJ4o9KuRiJ+bUtJxth+c EUTYS4HYpUs2O8ZRyRd+M9yR6A5UlAza68jI/nJzWrgMoTHZBrzg3P7uOkWYZiQD14OLWHed0Vu UHL34gLf8Q3+juiDCZiJsBNCM7760yS+1buzwvmo+UYg1eQRIrf245+DkaQSgEFHhx7c6k2Zpl9 x7lcRwRUQeaWWD0lRnOARQEW9xwstyH31295IXY9C0SKgWGk3nmjIuj8Npfg8ABC9gYttW8hT5a bpdIqTHbs2OfaFttxaM5Xoadchau4wzvlQXklc8l1KzG7yuHXNUw8+vZihDh+UyzqqFSyMvH84a /IJYvK8WUKICTTEJcS1dyj3DWkrlC2sc6muwoDSfck6uH/20NyvSlomE9AQOyWLZvkNkX86OGLY vRZ1HjCZMQHbMefQ== X-Received: by 2002:a05:7022:6898:b0:11b:e21e:5653 with SMTP id a92af1059eb24-128c2e0c967mr1056252c88.19.1772812150815; Fri, 06 Mar 2026 07:49:10 -0800 (PST) X-Received: by 2002:a05:7022:6898:b0:11b:e21e:5653 with SMTP id a92af1059eb24-128c2e0c967mr1056220c88.19.1772812150163; Fri, 06 Mar 2026 07:49:10 -0800 (PST) Received: from [192.168.1.41] (c-24-130-122-79.hsd1.ca.comcast.net. [24.130.122.79]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-128c3f58d24sm1497977c88.12.2026.03.06.07.49.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Mar 2026 07:49:09 -0800 (PST) Message-ID: <00a7e65d-aad3-4029-af51-ff0870e65595@oss.qualcomm.com> Date: Fri, 6 Mar 2026 07:49:07 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/14] firmware: qcom: Add a generic PAS service To: Sumit Garg , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-remoteproc@vger.kernel.org Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, robin.clark@oss.qualcomm.com, sean@poorly.run, akhilpo@oss.qualcomm.com, lumag@kernel.org, abhinav.kumar@linux.dev, jesszhan0024@gmail.com, marijn.suijten@somainline.org, airlied@gmail.com, simona@ffwll.ch, vikash.garodia@oss.qualcomm.com, dikshita.agarwal@oss.qualcomm.com, bod@kernel.org, mchehab@kernel.org, elder@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jjohnson@kernel.org, mathieu.poirier@linaro.org, trilokkumar.soni@oss.qualcomm.com, mukesh.ojha@oss.qualcomm.com, pavan.kondeti@oss.qualcomm.com, jorge.ramirez@oss.qualcomm.com, tonyh@qti.qualcomm.com, vignesh.viswanathan@oss.qualcomm.com, srinivas.kandagatla@oss.qualcomm.com, amirreza.zarrabi@oss.qualcomm.com, jens.wiklander@linaro.org, op-tee@lists.trustedfirmware.org, apurupa@qti.qualcomm.com, skare@qti.qualcomm.com, Sumit Garg References: <20260306105027.290375-1-sumit.garg@kernel.org> <20260306105027.290375-3-sumit.garg@kernel.org> From: Jeff Johnson Content-Language: en-US In-Reply-To: <20260306105027.290375-3-sumit.garg@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: QKyS8-FX8l4dFoaHUs4SE-sCXvpNH94w X-Proofpoint-GUID: QKyS8-FX8l4dFoaHUs4SE-sCXvpNH94w X-Authority-Analysis: v=2.4 cv=L+oQguT8 c=1 sm=1 tr=0 ts=69aaf777 cx=c_pps a=JYo30EpNSr/tUYqK9jHPoA==:117 a=Tg7Z00WN3eLgNEO9NLUKUQ==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=PJDN-9afRshu8rMoDvAA:9 a=QEXdDO2ut3YA:10 a=Fk4IpSoW4aLDllm1B1p-:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE0NiBTYWx0ZWRfXxMOb5WkeX3Tk 59V6d4P6CB3Of2zUBkM2RhNXa83KvHQM8JrA2ftX5uKwtUKrfGbkgEGGrQb4k3iGjgguPn7usNC A6VdLLshmDeLeisF/70E0aaZ/Q0ovLa1HrdntSOEv0Rh1nNGMUzaZg2r3hf7sp3BHNEDxh1Zw3N vWocVpQd8hISxxXOE/g7lk5086GRjBxwP9ohWB1q1CBXOjHxdWDPY0XK5PejbiLGs9c/0cNn6YI 21THovchA5Y07DJaiT3f+iCi8gDDKpXgzODblLaZM8sCieisj9ZYbJ5G3QVLBo+dKoSbKUas5wa KmwEJSadGjytyWixp7FdmB2ClK3/aoQysPSxfiecp14BM/UO3ytHLmlV0dpKglyBXGXPw9SxcUD pojIZBAXYelo2uYhI+W/qJtJH9oltuoRkCcqWt2RrVLnSrCrNkW4osPT4X3PAMQ1PKyN8+0lS9Y o0FsHIQnli/wX0NVSXQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_04,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 adultscore=0 bulkscore=0 priorityscore=1501 phishscore=0 impostorscore=0 lowpriorityscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060146 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 3/6/2026 2:50 AM, Sumit Garg wrote: I missed one k-doc warning... > +/** > + * qcom_scm_pas_auth_and_reset() - Authenticate the given peripheral firmware s/scm_// Warning: drivers/firmware/qcom/qcom_pas.c:173 expecting prototype for qcom_scm_pas_auth_and_reset(). Prototype was for qcom_pas_auth_and_reset() instead > + * and reset the remote processor > + * @pas_id: peripheral authentication service id > + * > + * Return 0 on success. > + */ > +int qcom_pas_auth_and_reset(u32 pas_id) > +{ > + if (ops_ptr) > + return ops_ptr->auth_and_reset(ops_ptr->dev, pas_id); > + > + return -ENODEV; > +}