From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49EF7E9B258 for ; Tue, 24 Feb 2026 12:44:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AA3E810E56E; Tue, 24 Feb 2026 12:44:15 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; secure) header.d=mailbox.org header.i=@mailbox.org header.b="pBVmotrV"; dkim-atps=neutral Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [80.241.56.161]) by gabe.freedesktop.org (Postfix) with ESMTPS id 35A1C895CA for ; Tue, 24 Feb 2026 12:44:13 +0000 (UTC) Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4fKy8V0Nkkz9vBl; Tue, 24 Feb 2026 13:44:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1771937050; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RxkSCX9jSePv4HDz10rAW//n/j/3CWDn153Nc3v7e4o=; b=pBVmotrVELLGAUGb28t67xg/5T/yqRFV19GJzIe/dIgIN8r7/2MklrNmcwQpq7jVIJIULD RQcMy7c1mbWjmmodSITWGF3J14OPA8JJhn1l+NMFGiIJxyDiXrm45fLK+GT4fTkepgiyJj X90piuNHTq8iTQTJuxtjo/4wgxOyUdRSvXxhaDr1zE+AYUXKPYd9YlF6WzsAlnZXWUkqGM gxTSqcG/3RRAMXteZ7ZhCztswIbvx/hiVod6L9leHx9nXHGJDmBmsv+Oqqb0MGFHuoEm5F WrXr3lgAuNZ7ebMNiNyQ6KbMXRdTqKQUueUYdP+CDXyhw7Uq8FBcrpw0XzkmQw== Message-ID: <020433384b88cd7bc88762373dd6e6b5a9d07c66.camel@mailbox.org> Subject: Re: [PATCH] drm/tests: Mark slow tests as slow From: Philipp Stanner To: Tvrtko Ursulin , Danilo Krummrich , Maxime Ripard Cc: Matthew Brost , Philipp Stanner , Christian Koenig , Maarten Lankhorst , Thomas Zimmermann , Matthew Auld , Arun Pravin , Simona Vetter , David Airlie , dri-devel@lists.freedesktop.org Date: Tue, 24 Feb 2026 13:44:04 +0100 In-Reply-To: References: <20260224110310.1854608-1-mripard@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MBO-RS-ID: a7834fe8ea3ba1e234c X-MBO-RS-META: ogaqg9sg758u9gi595xcrx9hjnm55uet X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: phasta@kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 2026-02-24 at 12:29 +0000, Tvrtko Ursulin wrote: >=20 > On 24/02/2026 11:43, Danilo Krummrich wrote: > > (Cc: Tvrtko) > >=20 > > On Tue Feb 24, 2026 at 12:03 PM CET, Maxime Ripard wrote: > > > Some DRM tests cross the 1s execution time threshold that defines a t= est > > > as slow. Let's flag them as such. > >=20 > > > >=20 > > > =C2=A0 static struct kunit_case drm_sched_credits_tests[] =3D { > > > - KUNIT_CASE(drm_sched_test_credits), > > > + KUNIT_CASE_SLOW(drm_sched_test_credits), > >=20 > > Hm..I don't think this test should be that slow. > >=20 > > Looking at the code, I see intentional timeouts through: > >=20 > > done =3D drm_mock_sched_job_wait_scheduled(job[1], HZ); > > KUNIT_ASSERT_FALSE(test, done); > >=20 > > Since the timeout is in jiffies, this should be always 1s, which seems = a bit > > overkill. > >=20 > > Maybe we should just change this to msecs_to_jiffies(200), which should= still be > > plenty and keep the test below 500ms. >=20 > Right, 200ms should be more than plenty. >=20 Who volunteers for implementing that change? :) P.