public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Lizhi Hou <lizhi.hou@amd.com>
To: Karol Wachowski <karol.wachowski@linux.intel.com>,
	<dri-devel@lists.freedesktop.org>
Cc: <oded.gabbay@gmail.com>, <jeff.hugo@oss.qualcomm.com>,
	<maciej.falkowski@linux.intel.com>,
	<andrzej.kacprowski@linux.intel.com>, <stable@vger.kernel.org>
Subject: Re: [PATCH] accel/ivpu: Add disable clock relinquish workaround for NVL-A0
Date: Mon, 23 Mar 2026 09:53:32 -0700	[thread overview]
Message-ID: <0317ba0d-6260-6e4f-ad5d-514297da7d73@amd.com> (raw)
In-Reply-To: <20260323095029.64613-1-karol.wachowski@linux.intel.com>


On 3/23/26 02:50, Karol Wachowski wrote:
> Turn on disable clock relinquish workaround for Nova Lake A0.
> Without this workaround NPU may not power off correctly after
> inference, leading to unexpected system behavior.
>
> Fixes: 550f4dd2cedd ("accel/ivpu: Add support for Nova Lake's NPU")
> Cc: <stable@vger.kernel.org> # v6.19+
>
> Signed-off-by: Karol Wachowski <karol.wachowski@linux.intel.com>
> ---
>   drivers/accel/ivpu/ivpu_drv.h | 1 +
>   drivers/accel/ivpu/ivpu_hw.c  | 6 ++++--
>   2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/accel/ivpu/ivpu_drv.h b/drivers/accel/ivpu/ivpu_drv.h
> index 5b34b6f50e69..f1b6155065ff 100644
> --- a/drivers/accel/ivpu/ivpu_drv.h
> +++ b/drivers/accel/ivpu/ivpu_drv.h
> @@ -35,6 +35,7 @@
>   #define IVPU_HW_IP_60XX 60
>   
>   #define IVPU_HW_IP_REV_LNL_B0 4
> +#define IVPU_HW_IP_REV_NVL_A0 0
>   
>   #define IVPU_HW_BTRS_MTL 1
>   #define IVPU_HW_BTRS_LNL 2
> diff --git a/drivers/accel/ivpu/ivpu_hw.c b/drivers/accel/ivpu/ivpu_hw.c
> index d69cd0d93569..d4a9bcda4100 100644
> --- a/drivers/accel/ivpu/ivpu_hw.c
> +++ b/drivers/accel/ivpu/ivpu_hw.c
> @@ -70,8 +70,10 @@ static void wa_init(struct ivpu_device *vdev)
>   	if (ivpu_hw_btrs_gen(vdev) == IVPU_HW_BTRS_MTL)
>   		vdev->wa.interrupt_clear_with_0 = ivpu_hw_btrs_irqs_clear_with_0_mtl(vdev);
>   
> -	if (ivpu_device_id(vdev) == PCI_DEVICE_ID_LNL &&
> -	    ivpu_revision(vdev) < IVPU_HW_IP_REV_LNL_B0)
> +	if ((ivpu_device_id(vdev) == PCI_DEVICE_ID_LNL &&
> +	     ivpu_revision(vdev) < IVPU_HW_IP_REV_LNL_B0) ||
> +	    (ivpu_device_id(vdev) == PCI_DEVICE_ID_NVL &&
> +	     ivpu_revision(vdev) == IVPU_HW_IP_REV_NVL_A0))
Reviewed-by: Lizhi.hou <lizhi.hou@amd.com>
>   		vdev->wa.disable_clock_relinquish = true;
>   
>   	if (ivpu_test_mode & IVPU_TEST_MODE_CLK_RELINQ_ENABLE)

  reply	other threads:[~2026-03-23 16:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-23  9:50 [PATCH] accel/ivpu: Add disable clock relinquish workaround for NVL-A0 Karol Wachowski
2026-03-23 16:53 ` Lizhi Hou [this message]
2026-03-24  8:32   ` Karol Wachowski
2026-03-24 22:00 ` Claude review: " Claude Code Review Bot
2026-03-24 22:00 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0317ba0d-6260-6e4f-ad5d-514297da7d73@amd.com \
    --to=lizhi.hou@amd.com \
    --cc=andrzej.kacprowski@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jeff.hugo@oss.qualcomm.com \
    --cc=karol.wachowski@linux.intel.com \
    --cc=maciej.falkowski@linux.intel.com \
    --cc=oded.gabbay@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox