Re: [PATCH 1/4] fbdev: Wrap user-invoked calls to fb_set_var() in helper

[Helge Deller <deller@gmx.de>]

On 5/20/26 18:00, Thomas Zimmermann wrote:
> Handle fbcon during display updates in fb_set_var_from_user(). Check
> with fbcon if the mode change is possible, update hardware state and
> finally update fbcon. Update all callers.
> 
> Only the FBIOPUT_VSCREENINFO ioctl currently does all steps. Other
> mode-changes callers in sysfs and driver code are missing fbcon-related
> steps.
> 
> With the new helper, ps3fb and sh_mobile_lcdcfb no longer maintain
> fbcon state themselves.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
>   drivers/video/fbdev/core/fb_chrdev.c   |  6 +-----
>   drivers/video/fbdev/core/fbcon.c       |  2 --
>   drivers/video/fbdev/core/fbmem.c       | 13 +++++++++++++
>   drivers/video/fbdev/core/fbsysfs.c     |  4 +---
>   drivers/video/fbdev/ps3fb.c            |  5 +----
>   drivers/video/fbdev/sh_mobile_lcdcfb.c |  5 +----
>   include/linux/fb.h                     |  2 ++
>   7 files changed, 19 insertions(+), 18 deletions(-)
> 
>...
> diff --git a/include/linux/fb.h b/include/linux/fb.h
> index 5178a33c752c..88680a7cabd5 100644
> --- a/include/linux/fb.h
> +++ b/include/linux/fb.h
> @@ -533,6 +533,8 @@ extern int fb_set_var(struct fb_info *info, struct fb_var_screeninfo *var);
>   extern int fb_pan_display(struct fb_info *info, struct fb_var_screeninfo *var);
>   extern int fb_blank(struct fb_info *info, int blank);
>   
> +int fb_set_var_from_user(struct fb_info *info, struct fb_var_screeninfo *var);
> +

"extern" int fb_set_var_from_user(...) ?

Other than that the series is a nice cleanup!

Thanks!
Helge