public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <dev@lankhorst.se>
To: "Hogander, Jouni" <jouni.hogander@intel.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Cc: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
	lkp <lkp@intel.com>
Subject: Re: [PATCH v2] drm/ttm/tests: Fix build failure on PREEMPT_RT
Date: Wed, 4 Mar 2026 10:25:19 +0100	[thread overview]
Message-ID: <0d69a3a9-3656-4471-a075-85b3090c585f@lankhorst.se> (raw)
In-Reply-To: <d98e78d4b24b8b18db6a8d82d52ebf8f91c6fbfb.camel@intel.com>

Hey,


Den 2026-03-04 kl. 09:58, skrev Hogander, Jouni:
> On Wed, 2026-03-04 at 09:56 +0100, Maarten Lankhorst wrote:
>> Fix a compile error in the kunit tests when CONFIG_PREEMPT_RT is
>> enabled, and the normal mutex is converted into a rtmutex.
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes:
>> https://lore.kernel.org/oe-kbuild-all/202602261547.3bM6yVAS-lkp@intel.com/
>> Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
> 
> Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
Thanks, tested if UML was still passing and it does. 

./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/ttm/tests/.kunitconfig
....
[10:06:16] [PASSED] ttm_bo_reserve_interrupted

Will wait for CI kunit results and then push.

> 
>> ---
>> Changes since v1:
>> - Use the correct locking primitive (Jouni)
>>
>>  drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c
>> b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c
>> index d468f83220720..f3103307b5df9 100644
>> --- a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c
>> +++ b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c
>> @@ -222,13 +222,13 @@ static void ttm_bo_reserve_interrupted(struct
>> kunit *test)
>>  		KUNIT_FAIL(test, "Couldn't create ttm bo reserve
>> task\n");
>>  
>>  	/* Take a lock so the threaded reserve has to wait */
>> -	mutex_lock(&bo->base.resv->lock.base);
>> +	dma_resv_lock(bo->base.resv, NULL);
>>  
>>  	wake_up_process(task);
>>  	msleep(20);
>>  	err = kthread_stop(task);
>>  
>> -	mutex_unlock(&bo->base.resv->lock.base);
>> +	dma_resv_unlock(bo->base.resv);
>>  
>>  	KUNIT_ASSERT_EQ(test, err, -ERESTARTSYS);
>>  }
> 


  reply	other threads:[~2026-03-04  9:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-04  8:56 [PATCH v2] drm/ttm/tests: Fix build failure on PREEMPT_RT Maarten Lankhorst
2026-03-04  8:58 ` Hogander, Jouni
2026-03-04  9:25   ` Maarten Lankhorst [this message]
2026-03-05  3:40 ` Claude review: " Claude Code Review Bot
2026-03-05  3:40 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d69a3a9-3656-4471-a075-85b3090c585f@lankhorst.se \
    --to=dev@lankhorst.se \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jouni.hogander@intel.com \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox