From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2D5ECD6E57 for ; Wed, 3 Jun 2026 14:07:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BDDC410FEC3; Wed, 3 Jun 2026 14:07:38 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="YddxIrCd"; dkim-atps=neutral Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) by gabe.freedesktop.org (Postfix) with ESMTPS id DE2EE10FEBF for ; Wed, 3 Jun 2026 14:07:36 +0000 (UTC) Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 8360F1A0117; Wed, 3 Jun 2026 14:07:35 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 4F67B5FA0A; Wed, 3 Jun 2026 14:07:35 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id B4E2D10888CCD; Wed, 3 Jun 2026 16:07:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1780495654; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=ZzLHMq1gKIJ4B1phl+JFZT2hAaDJA+UC4QF8qFjgU/M=; b=YddxIrCdSs/sJ6253x9UOnwSovYCu0z+/zGgZy/r5A2FRtbBLKzCmHM6zMWEwh5gkxqOy9 e90CzdBFtEUrE+BxaQsqsXQMvIgt/i9y98rAZ4HzpFd37LRnxA6RzoA7A0fUBgnlHDhPvs +Zfk14azV0K8aNPDBASwC9ZXMCziZ0tNjDQKe0/Vr45ReiBqzRgl7DhL/ynAlwqd2CgXwU HtVybpL3NcYfMmf4852B3C6gXeB58b3TGJh4KvqzmScVebsB4bt9wdSNu7zLQsZg+M6Wx1 oKdRfq/rk99aeDhaebZE2UPic/gFvt+lupowA5yNGIKKb4dgoZWxfkWgfmQk6Q== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 03/76] drm/atomic-state-helper: Drop memset from __drm_atomic_helper_bridge_state_init() From: Luca Ceresoli To: Maxime Ripard Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Dmitry Baryshkov , dri-devel@lists.freedesktop.org In-Reply-To: <20260530-drm-no-more-bridge-reset-v1-3-875d828d31bc@kernel.org> References: <20260530-drm-no-more-bridge-reset-v1-0-875d828d31bc@kernel.org> <20260530-drm-no-more-bridge-reset-v1-3-875d828d31bc@kernel.org> Date: Wed, 03 Jun 2026 16:07:19 +0200 Message-Id: <178049563993.8577.7148287055498981614.b4-review@b4> X-Mailer: b4 0.15.2 X-Last-TLS-Session-Version: TLSv1.3 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, 30 May 2026 15:59:08 +0200, Maxime Ripard wrote: > __drm_atomic_helper_bridge_state_init() is always called on a freshly > kzalloc-ed state, so the memset is redundant. > > Drop it and document the expectation that the state is already zeroed. Reviewed-by: Luca Ceresoli -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com