public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Lizhi Hou <lizhi.hou@amd.com>
To: Haoyu Lu <hechushiguitu666@gmail.com>,
	Min Ma <mamin506@gmail.com>, Oded Gabbay <ogabbay@kernel.org>
Cc: <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] accel/amdxdna: fix missing newline in pr_err message
Date: Fri, 20 Mar 2026 08:54:54 -0700	[thread overview]
Message-ID: <1af543d3-46ff-7a9c-6432-fe3c9050e23d@amd.com> (raw)
In-Reply-To: <20260320112938.305-1-hechushiguitu666@gmail.com>


On 3/20/26 04:29, Haoyu Lu wrote:
> [You don't often get email from hechushiguitu666@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> From: "haoyu.lu" <hechushiguitu666@gmail.com>
>
> Add missing newline to pr_err message in amdxdna_mailbox.c.
>
> Signed-off-by: haoyu.lu <hechushiguitu666@gmail.com>

Please add 'Fixes' tag.

Lizhi

> ---
>   drivers/accel/amdxdna/amdxdna_mailbox.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accel/amdxdna/amdxdna_mailbox.c b/drivers/accel/amdxdna/amdxdna_mailbox.c
> index 46d844a73a94..e681a090752d 100644
> --- a/drivers/accel/amdxdna/amdxdna_mailbox.c
> +++ b/drivers/accel/amdxdna/amdxdna_mailbox.c
> @@ -499,7 +499,7 @@ xdna_mailbox_start_channel(struct mailbox_channel *mb_chann,
>          int ret;
>
>          if (!is_power_of_2(x2i->rb_size) || !is_power_of_2(i2x->rb_size)) {
> -               pr_err("Ring buf size must be power of 2");
> +               pr_err("Ring buf size must be power of 2\n");
>                  return -EINVAL;
>          }
>
> --
> 2.53.0.windows.1
>

  reply	other threads:[~2026-03-20 15:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-20 11:29 [PATCH] accel/amdxdna: fix missing newline in pr_err message Haoyu Lu
2026-03-20 15:54 ` Lizhi Hou [this message]
2026-03-21 17:46   ` Claude review: " Claude Code Review Bot
2026-03-21 17:46   ` Claude Code Review Bot
2026-03-23  3:49   ` [PATCH v2] " Haoyu Lu
2026-03-23 16:40     ` Lizhi Hou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1af543d3-46ff-7a9c-6432-fe3c9050e23d@amd.com \
    --to=lizhi.hou@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hechushiguitu666@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mamin506@gmail.com \
    --cc=ogabbay@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox