From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65556CD6E55 for ; Wed, 3 Jun 2026 09:14:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 87ECC113C97; Wed, 3 Jun 2026 09:14:24 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=igalia.com header.i=@igalia.com header.b="NrKadQyG"; dkim-atps=neutral Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9BDE4113C95 for ; Wed, 3 Jun 2026 09:14:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=De/H9v3P+lfJ2i1wRPydbhaI86jUHQUvPbwvrzdNMps=; b=NrKadQyGVMB2w/jp3uIEeexYCn Hs7Xrwh7t+Ckdwa1x9iBLGYyWWAmGbjcIWi2s30TfoeWqP74lzf7PgLTRV6ci5Mc8E5zVZB9zERLE WWPipO3fcrx/Nk8YXcnZVPzgbDMtwIMbot6QGyvJMk2LcIBWudAMvPmm9/debZvdxUgw8bwdwgrhB WweuQi1RilW5olcGceMnyWl2/iHoFa0aiqFuQzALy+Hxz2r5W/KWNOy0R609t50iYlZMxnzUAbmIf mgE9eI0cZlFTfLOfRObKK0y/V4hx+NwSoh79l+SWN2aL7Y3byGXQF+lZDCndRkB3uOqVR3NSS2sAy Qj9aF+MA==; Received: from [90.240.106.137] (helo=[192.168.0.116]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1wUhg4-00C67g-7L; Wed, 03 Jun 2026 11:14:20 +0200 Message-ID: <1ddf1427-e0ee-4891-9af6-028cd559b161@igalia.com> Date: Wed, 3 Jun 2026 10:14:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/sched: Remove redundant entity->rq initialization and checks To: phasta@kernel.org, dri-devel@lists.freedesktop.org Cc: kernel-dev@igalia.com, =?UTF-8?Q?Christian_K=C3=B6nig?= , Danilo Krummrich , Matthew Brost References: <20260602153339.43453-1-tvrtko.ursulin@igalia.com> <4e7e282983939dd64b9303d53302e6806361076c.camel@mailbox.org> Content-Language: en-GB From: Tvrtko Ursulin In-Reply-To: <4e7e282983939dd64b9303d53302e6806361076c.camel@mailbox.org> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: base64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Ck9uIDAzLzA2LzIwMjYgMDk6MzcsIFBoaWxpcHAgU3Rhbm5lciB3cm90ZToKPiBPbiBUdWUsIDIw MjYtMDYtMDIgYXQgMTY6MzMgKzAxMDAsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+PiBDb21taXQK Pj4gMjhjNWJmMjg3NjNkICgiZHJtL3NjaGVkOiBEaXNhbGxvdyBpbml0aWFsaXppbmcgZW50aXRp ZXMgd2l0aCBubyBzY2hlZHVsZXJzIikKPj4gZmFpbGVkIHRvIG5vdGljZSBjbGVhcmluZyBvZiBl bnRpdHktPnJxIGluIGRybV9zY2hlZF9lbnRpdHlfaW5pdCgpIGlzIG5vdwo+IAo+IEJ5IGNsZWFy aW5nIHlvdSBhbHNvIG1lYW4gdGhlIHNldHRpbmcgdG8gTlVMTD8KPiAKPiBJJ2QganVzdCB1c2Ug ImluaXRpYWxpemF0aW9uIiBjb25zaXN0ZW50bHksIGxpa2UgaW4gdGhlIGNvbW1pdCB0aXRsZS4K Ckl0IGlzIGluaXRpYWxpemVkIHByb3Blcmx5IGEgYml0IGxvd2VyIGRvd24gc28gY2xlYXJpbmcg aXMgSSB0aGluayBtb3JlIAphY2N1cmF0ZS4KCj4+IHJlZHVuZGFudCBhbmQgY2FuIGJlIHJlbW92 ZWQuCj4+Cj4+IEdpdmVuIHRoYXQgZW50aXR5LT5ycSBjYW4gbm93IG5ldmVyIGJlIE5VTEwsIHdl IGFsc28gcmVtb3ZlIHR3byBpbXBvc3NpYmxlCj4+IGNoZWNrcywgZnJvbSBkcm1fc2NoZWRfZW50 aXR5X2tpbGwoKSBhbmQgZHJtX3NjaGVkX2VudGl0eV9mbHVzaCgpCj4+IHJlc3BlY3RpdmVseS4K Pj4KPj4gU2ltaWxhcmx5LCB3ZSBjYW4gYWxzbyByZW1vdmUgdGhlICFlbnRpdHktPnJxIGNoZWNr IGluCj4+IGRybV9zY2hlZF9qb2JfaW5pdCgpLiBBbmQgZm9yIHRoZSBiZXR0ZXIsIGdpdmVuIHRo YXQgdGhlIGVycm9yIG1lc3NhZ2UsIGlmCj4+IGl0IGV2ZXIgdHJpZ2dlcmVkLCB3b3VsZCBoYXZl IGRlcmVmZXJlbmNlZCB0aGUgeWV0IHVuLWluaXRpYWxpemVkIGpvYi0+Cj4+IHNjaGVkIChvbmx5 IGluaXRpYWxpemVkIGxhdGVyIGluIGRybV9zY2hlZF9qb2JfYXJtKCkpLiBUaGlzIGFwcGVhcnMg dG8KPj4gaGF2ZSBiZWVuIHRoZW9yZXRpY2FsbHkgYnJva2VuIGV2ZXIgc2luY2UgY29tbWl0Cj4+ IDU2ZTQ0OTYwM2YwYSAoImRybS9zY2hlZDogQ29udmVydCB0aGUgR1BVIHNjaGVkdWxlciB0byB2 YXJpYWJsZSBudW1iZXIgb2YgcnVuLXF1ZXVlcyIpCj4+IC4KPj4KPj4gU2lnbmVkLW9mZi1ieTog VHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGlnYWxpYS5jb20+Cj4+IENjOiBDaHJpc3Rp YW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Cj4+IENjOiBEYW5pbG8gS3J1bW1y aWNoIDxkYWtyQGtlcm5lbC5vcmc+Cj4+IENjOiBNYXR0aGV3IEJyb3N0IDxtYXR0aGV3LmJyb3N0 QGludGVsLmNvbT4KPj4gQ2M6IFBoaWxpcHAgU3Rhbm5lciA8cGhhc3RhQGtlcm5lbC5vcmc+Cj4+ IC0tLQo+PiAgwqBkcml2ZXJzL2dwdS9kcm0vc2NoZWR1bGVyL3NjaGVkX2VudGl0eS5jIHwgMTEg KystLS0tLS0tLS0KPj4gIMKgZHJpdmVycy9ncHUvZHJtL3NjaGVkdWxlci9zY2hlZF9tYWluLmPC oMKgIHzCoCA5IC0tLS0tLS0tLQo+PiAgwqAyIGZpbGVzIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygr KSwgMTggZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vc2No ZWR1bGVyL3NjaGVkX2VudGl0eS5jIGIvZHJpdmVycy9ncHUvZHJtL3NjaGVkdWxlci9zY2hlZF9l bnRpdHkuYwo+PiBpbmRleCA0ZWJiNTEzMjU1ZWQuLmM1MTEwMWVjNzBjMSAxMDA2NDQKPj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL3NjaGVkdWxlci9zY2hlZF9lbnRpdHkuYwo+PiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vc2NoZWR1bGVyL3NjaGVkX2VudGl0eS5jCj4+IEBAIC0xMjksNyArMTI5LDYg QEAgaW50IGRybV9zY2hlZF9lbnRpdHlfaW5pdChzdHJ1Y3QgZHJtX3NjaGVkX2VudGl0eSAqZW50 aXR5LAo+PiAgwqAJCXJldHVybiAtRU5PTUVNOwo+PiAgIAo+PiAgwqAJSU5JVF9MSVNUX0hFQUQo JmVudGl0eS0+bGlzdCk7Cj4+IC0JZW50aXR5LT5ycSA9IE5VTEw7Cj4gCj4gSXQgd291bGQgc2Vl bSB0aGF0IGhhcyBhbHdheXMgYmVlbiByZWR1bmRhbnQgYmVjYXVzZSBvZiB0aGUgbWVtc2V0KDAp Cj4gZGlyZWN0bHkgYWJvdmUuCgpUcnVlLCBldmVyIHNpbmNlIDFkZWNiZjZiYjBiNCAoImRybS9z Y2hlZDogRml4IGVudGl0aWVzIHdpdGggMCBycXMuIikuIApKdXN0IHRoYXQgaW4gdGhpcyBwYXRj aCB0aGUgcmVkdW5kYW50IGlzIGZvY3VzaW5nIG9uOgoKICAgZW50aXR5LT5ycSA9IE5VTEw7Ci4u LgogICBlbnRpdHktPnJxID0gJnNjaGVkX2xpc3RbMF0tPnJxOwoKR29vZCBlbm91Z2ggb3IgeW91 IHdhbnQgYSByZXNwaW4gYW5kIGlmIHNvIGluIHdoYXQgZmxhdm91cj8KClJlZ2FyZHMsCgpUdnJ0 a28KCj4gCj4+ICDCoAllbnRpdHktPmd1aWx0eSA9IGd1aWx0eTsKPj4gIMKgCWVudGl0eS0+cHJp b3JpdHkgPSBwcmlvcml0eTsKPj4gIMKgCWVudGl0eS0+bGFzdF91c2VyID0gY3VycmVudC0+Z3Jv dXBfbGVhZGVyOwo+PiBAQCAtMjgwLDkgKzI3OSw2IEBAIHZvaWQgZHJtX3NjaGVkX2VudGl0eV9r aWxsKHN0cnVjdCBkcm1fc2NoZWRfZW50aXR5ICplbnRpdHkpCj4+ICDCoAlzdHJ1Y3QgZHJtX3Nj aGVkX2pvYiAqam9iOwo+PiAgwqAJc3RydWN0IGRtYV9mZW5jZSAqcHJldjsKPj4gICAKPj4gLQlp ZiAoIWVudGl0eS0+cnEpCj4+IC0JCXJldHVybjsKPj4gLQo+PiAgwqAJc3Bpbl9sb2NrKCZlbnRp dHktPmxvY2spOwo+PiAgwqAJZW50aXR5LT5zdG9wcGVkID0gdHJ1ZTsKPj4gIMKgCWRybV9zY2hl ZF9ycV9yZW1vdmVfZW50aXR5KGVudGl0eS0+cnEsIGVudGl0eSk7Cj4+IEBAIC0zMjksMTQgKzMy NSwxMSBAQCBFWFBPUlRfU1lNQk9MKGRybV9zY2hlZF9lbnRpdHlfa2lsbCk7Cj4+ICDCoCAqLwo+ PiAgwqBsb25nIGRybV9zY2hlZF9lbnRpdHlfZmx1c2goc3RydWN0IGRybV9zY2hlZF9lbnRpdHkg KmVudGl0eSwgbG9uZyB0aW1lb3V0KQo+PiAgwqB7Cj4+IC0Jc3RydWN0IGRybV9ncHVfc2NoZWR1 bGVyICpzY2hlZDsKPj4gKwlzdHJ1Y3QgZHJtX2dwdV9zY2hlZHVsZXIgKnNjaGVkID0KPj4gKwkJ Y29udGFpbmVyX29mKGVudGl0eS0+cnEsIHR5cGVvZigqc2NoZWQpLCBycSk7Cj4+ICDCoAlzdHJ1 Y3QgdGFza19zdHJ1Y3QgKmxhc3RfdXNlcjsKPj4gIMKgCWxvbmcgcmV0ID0gdGltZW91dDsKPj4g ICAKPj4gLQlpZiAoIWVudGl0eS0+cnEpCj4+IC0JCXJldHVybiAwOwo+PiAtCj4+IC0Jc2NoZWQg PSBjb250YWluZXJfb2YoZW50aXR5LT5ycSwgdHlwZW9mKCpzY2hlZCksIHJxKTsKPj4gIMKgCS8q Cj4+ICDCoAkgKiBUaGUgY2xpZW50IHdpbGwgbm90IHF1ZXVlIG1vcmUgam9icyBkdXJpbmcgdGhp cyBmaW5pIC0gY29uc3VtZQo+PiAgwqAJICogZXhpc3RpbmcgcXVldWVkIG9uZXMsIG9yIGRpc2Nh cmQgdGhlbSBvbiBTSUdLSUxMLgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3NjaGVk dWxlci9zY2hlZF9tYWluLmMgYi9kcml2ZXJzL2dwdS9kcm0vc2NoZWR1bGVyL3NjaGVkX21haW4u Ywo+PiBpbmRleCA4MThkM2Q0NDM0YjUuLmQyY2EwMWIzMWVlNCAxMDA2NDQKPj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL3NjaGVkdWxlci9zY2hlZF9tYWluLmMKPj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL3NjaGVkdWxlci9zY2hlZF9tYWluLmMKPj4gQEAgLTU4OCwxNSArNTg4LDYgQEAgaW50IGRy bV9zY2hlZF9qb2JfaW5pdChzdHJ1Y3QgZHJtX3NjaGVkX2pvYiAqam9iLAo+PiAgwqAJCcKgwqDC oMKgwqDCoCB1MzIgY3JlZGl0cywgdm9pZCAqb3duZXIsCj4+ICDCoAkJwqDCoMKgwqDCoMKgIHVp bnQ2NF90IGRybV9jbGllbnRfaWQpCj4+ICDCoHsKPj4gLQlpZiAoIWVudGl0eS0+cnEpIHsKPj4g LQkJLyogVGhpcyB3aWxsIG1vc3QgbGlrZWx5IGJlIGZvbGxvd2VkIGJ5IG1pc3NpbmcgZnJhbWVz Cj4+IC0JCSAqIG9yIHdvcnNlLS1hIGJsYW5rIHNjcmVlbi0tbGVhdmUgYSB0cmFpbCBpbiB0aGUK Pj4gLQkJICogbG9ncywgc28gdGhpcyBjYW4gYmUgZGVidWdnZWQgZWFzaWVyLgo+PiAtCQkgKi8K Pj4gLQkJZGV2X2Vycihqb2ItPnNjaGVkLT5kZXYsICIlczogZW50aXR5IGhhcyBubyBycSFcbiIs IF9fZnVuY19fKTsKPj4gLQkJcmV0dXJuIC1FTk9FTlQ7Cj4+IC0JfQo+PiAtCj4+ICDCoAlpZiAo dW5saWtlbHkoIWNyZWRpdHMpKSB7Cj4+ICDCoAkJcHJfZXJyKCIqRVJST1IqICVzOiBjcmVkaXRz IGNhbm5vdCBiZSAwIVxuIiwgX19mdW5jX18pOwo+PiAgwqAJCXJldHVybiAtRUlOVkFMOwo+IAo+ IEJ1dCBvdmVyYWxsIGEgdmVyeSBuaWNlIGNsZWFudXAKPiAKPiAKPiBQLgoK