Re: [PATCH 00/15] drm/ast: Clean up access to MMIO registers

[Thomas Zimmermann <tzimmermann@suse.de>]

The series title should say 'non-MMIO registers'. :( The rest of the 
series is not affected by the typo.

Am 23.03.26 um 16:56 schrieb Thomas Zimmermann:
> Aspeed devices up to Gen6 contain internal memory that is accessible
> from the host via the P2A bridge. The helpers ast_moutdwm() and
> ast_mindwm() pick a 64-KiB segment of the memory to expose to the
> host, which then has the content available. Content is either registers
> of the various IP blocks or on-board system memory.
>
> Clean up the driver code involved and provide macro constants for the
> registers used by the ast driver. Go through the driver and replace
> the magic values with the constants.
>
> The first patch of the series fixes a bug that has been found while
> working on these changes. The DP501 writes the content of register
> SCU2C to the wrong address. The fix is a separate patch to ease
> backporting.
>
> Smoke-tested on AST2100, AST2300, AST2500 and AST2600.
>
> Thomas Zimmermann (15):
>    drm/ast: dp501: Fix initialization of SCU2C
>    drm/ast: Move 32-bit register-access helpers to ast_drv.{c,h}
>    drm/ast: Use constants for AHBC registers
>    drm/ast: Use constants for MCR registers
>    drm/ast: Use constants for SCU registers
>    drm/ast: Use constants for A2P registers
>    drm/ast: Use constants for WDT registers
>    drm/ast: Use constants for SDRAM registers
>    drm/ast: Store register addresses in struct ast_dramstruct
>    drm/ast: Gen1: Fix open-coded register access
>    drm/ast: Gen2: Fix open-coded register access
>    drm/ast: Gen4: Fix open-coded register access
>    drm/ast: Gen6: Fix open-coded register access
>    drm/ast: dp501: Fix open-coded register access
>    drm/ast: Fix open-coded scu_rev access
>
>   drivers/gpu/drm/ast/ast_2000.c  |  61 +++--
>   drivers/gpu/drm/ast/ast_2100.c  | 292 +++++++++++------------
>   drivers/gpu/drm/ast/ast_2300.c  | 398 ++++++++++++++++----------------
>   drivers/gpu/drm/ast/ast_2500.c  | 319 ++++++++++++-------------
>   drivers/gpu/drm/ast/ast_dp501.c | 146 ++++++------
>   drivers/gpu/drm/ast/ast_drv.c   |  84 ++++++-
>   drivers/gpu/drm/ast/ast_drv.h   |  60 +++--
>   drivers/gpu/drm/ast/ast_post.c  |  48 +---
>   drivers/gpu/drm/ast/ast_post.h  |  20 +-
>   drivers/gpu/drm/ast/ast_reg.h   | 155 +++++++++++++
>   10 files changed, 886 insertions(+), 697 deletions(-)
>
>
> base-commit: 5cb7d14d9bd2061386a0192a4649626a3e3a5ec3

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)