From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B78A9E81BCC for ; Mon, 9 Feb 2026 14:10:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 04CDD10E3F8; Mon, 9 Feb 2026 14:10:44 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="awdnsntt"; dkim-atps=neutral Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id 72D8210E3F8 for ; Mon, 9 Feb 2026 14:10:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1770646240; bh=hZkJVgJ7X2tCJW8hxCbMEX2eWCVr2C6omxspYOwQ0yQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=awdnsnttpnrxf2kSIQMnWGzZDpV1k+xmdUeIswLueRTYBQDpGa6V/ZdZSx1kSa33T T5p3ulBDXmgs7ul96a1rVSlzLFZJRppsrVxKiIfDqNH/llDIorW2eFMmlYotkYqMLJ jaFGEUnFFs7cksEwPs5qQBphkAB0iCQfz22g9Cdfdeto0fABFoIFrlawCeCNz4TYlN VPL/E5APCcJzKi5FjHoO971eHZMLJ/CU2wX03n32bTfMnPU4lr8hyM/VyXo0NpMCY+ ttOSIu8RaGoFpwo8mpIp0BlFxEuKdE2bavwz7Ule8ULtbrN3bz0a8rVEipHreIDYTC yl7ECoK7TQpvQ== Received: from fedora (unknown [IPv6:2a01:e0a:2c:6930:d919:a6e:5ea1:8a9f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 817F917E137B; Mon, 9 Feb 2026 15:10:40 +0100 (CET) Date: Mon, 9 Feb 2026 15:10:35 +0100 From: Boris Brezillon To: Thomas Zimmermann Cc: loic.molinari@collabora.com, willy@infradead.org, frank.binns@imgtec.com, matt.coster@imgtec.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, airlied@gmail.com, simona@ffwll.ch, dri-devel@lists.freedesktop.org, linux-mm@kvack.org Subject: Re: [PATCH v3 1/6] drm/gem-shmem: Use obj directly where appropriate in fault handler Message-ID: <20260209151035.59889115@fedora> In-Reply-To: <20260209133241.238813-2-tzimmermann@suse.de> References: <20260209133241.238813-1-tzimmermann@suse.de> <20260209133241.238813-2-tzimmermann@suse.de> Organization: Collabora X-Mailer: Claws Mail 4.3.1 (GTK 3.24.51; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 9 Feb 2026 14:27:10 +0100 Thomas Zimmermann wrote: > Replace shmem->base with obj in several places. It is the same value, > but the latter is easier to read. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/drm_gem_shmem_helper.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c > index 3871a6d92f77..5bced7db0f1f 100644 > --- a/drivers/gpu/drm/drm_gem_shmem_helper.c > +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c > @@ -584,7 +584,7 @@ static vm_fault_t drm_gem_shmem_fault(struct vm_fault *vmf) > /* Offset to faulty address in the VMA. */ > page_offset = vmf->pgoff - vma->vm_pgoff; > > - dma_resv_lock(shmem->base.resv, NULL); > + dma_resv_lock(obj->resv, NULL); > > if (page_offset >= num_pages || > drm_WARN_ON_ONCE(obj->dev, !shmem->pages) || > @@ -602,7 +602,7 @@ static vm_fault_t drm_gem_shmem_fault(struct vm_fault *vmf) > ret = vmf_insert_pfn(vma, vmf->address, pfn); > > out: > - dma_resv_unlock(shmem->base.resv); > + dma_resv_unlock(obj->resv); > > return ret; > }