From: Ariel D'Alessandro <ariel.dalessandro@collabora.com>
To: Louis Chauvet <louis.chauvet@bootlin.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Simona Vetter <simona@ffwll.ch>,
Melissa Wen <melissa.srw@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
nfraprado@collabora.com, pekka.paalanen@collabora.com,
daniels@collabora.com, kernel@collabora.com,
Ariel D'Alessandro <ariel.dalessandro@collabora.com>
Subject: [PATCH v2 0/2] drm/vkms: Fix bad matrix offset component multiplication
Date: Tue, 10 Feb 2026 14:43:59 -0300 [thread overview]
Message-ID: <20260210-vkms-composer-fix-matrix-v2-0-d1ed09cb23e8@collabora.com> (raw)
This patch series fixes a bug in the 3x4 matrix multiplication for BT709
enconding/decoding, where the offset component if not handled properly.
Currently, BT.709 encoding matrix kunit tests don't cover the offset
component multiplication, so a new set of tests is added.
The bug was found while working on the IGT tools CRTC (post-blend) color
pipelines, see submitted patchset [0] (patch [1] in particular) for the
full context.
[0] https://lore.kernel.org/igt-dev/20251223-post-blend-colorops-v2-0-f40aca9795bd@collabora.com/
[1] https://lore.kernel.org/igt-dev/20251223-post-blend-colorops-v2-7-f40aca9795bd@collabora.com/
Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@collabora.com>
---
Changes in v2:
- Added kunit tests for alternative BT709 encoding matrix.
- Link to v1: https://lore.kernel.org/r/20251223-vkms-composer-fix-matrix-v1-1-10a979e06209@collabora.com
---
Ariel D'Alessandro (2):
drm/vkms: Fix bad matrix offset component multiplication
drm/vkms: Add kunit tests for alternative BT709 encoding matrix
drivers/gpu/drm/vkms/tests/vkms_color_test.c | 146 +++++++++++++++++++++++++++
drivers/gpu/drm/vkms/vkms_composer.c | 13 ++-
2 files changed, 156 insertions(+), 3 deletions(-)
---
base-commit: b96bcfba104c65db41378a04f5ccac186f79578f
change-id: 20251223-vkms-composer-fix-matrix-aa2c593f4515
Best regards,
--
Ariel D'Alessandro <ariel.dalessandro@collabora.com>
next reply other threads:[~2026-02-10 17:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 17:43 Ariel D'Alessandro [this message]
2026-02-10 17:44 ` [PATCH v2 1/2] drm/vkms: Fix bad matrix offset component multiplication Ariel D'Alessandro
2026-02-12 11:37 ` Pekka Paalanen
2026-02-12 20:36 ` Claude review: " Claude Code Review Bot
2026-02-10 17:44 ` [PATCH v2 2/2] drm/vkms: Add kunit tests for alternative BT709 encoding matrix Ariel D'Alessandro
2026-02-12 20:36 ` Claude review: " Claude Code Review Bot
2026-02-11 6:19 ` Claude review: drm/vkms: Fix bad matrix offset component multiplication Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260210-vkms-composer-fix-matrix-v2-0-d1ed09cb23e8@collabora.com \
--to=ariel.dalessandro@collabora.com \
--cc=airlied@gmail.com \
--cc=daniels@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamohammed.sa@gmail.com \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=louis.chauvet@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=melissa.srw@gmail.com \
--cc=mripard@kernel.org \
--cc=nfraprado@collabora.com \
--cc=pekka.paalanen@collabora.com \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox