public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Andy Yan <andyshrk@163.com>
To: andrzej.hajda@intel.com, airlied@gmail.com,
	jernej.skrabec@gmail.com, jonas@kwiboo.se,
	Laurent.pinchart@ideasonboard.com,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	neil.armstrong@linaro.org, rfoss@kernel.org, simona@ffwll.ch,
	tzimmermann@suse.de, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, dmitry.baryshkov@oss.qualcomm.com
Cc: Andy Yan <andyshrk@163.com>
Subject: [PATCH] drm/bridge: lt9611: Remove DRM_BRIDGE_OP_MODES flag
Date: Tue, 10 Feb 2026 15:08:05 +0800	[thread overview]
Message-ID: <20260210070821.570062-1-andyshrk@163.com> (raw)

According to the documentation: Bridges that set this flag shall
implement the &drm_bridge_funcs->get_modes callback.

But the lt9611 driver does not implement the get_modes callback,
so remove this flag.

Signed-off-by: Andy Yan <andyshrk@163.com>
---

 drivers/gpu/drm/bridge/lontium-lt9611.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
index 0628d8e737ab..d916784af1ea 100644
--- a/drivers/gpu/drm/bridge/lontium-lt9611.c
+++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
@@ -1149,9 +1149,8 @@ static int lt9611_probe(struct i2c_client *client)
 
 	lt9611->bridge.of_node = client->dev.of_node;
 	lt9611->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID |
-			     DRM_BRIDGE_OP_HPD | DRM_BRIDGE_OP_MODES |
-			     DRM_BRIDGE_OP_HDMI | DRM_BRIDGE_OP_HDMI_AUDIO |
-			     DRM_BRIDGE_OP_HDMI_SPD_INFOFRAME;
+			     DRM_BRIDGE_OP_HPD | DRM_BRIDGE_OP_HDMI |
+			     DRM_BRIDGE_OP_HDMI_AUDIO | DRM_BRIDGE_OP_HDMI_SPD_INFOFRAME;
 	lt9611->bridge.type = DRM_MODE_CONNECTOR_HDMIA;
 	lt9611->bridge.vendor = "Lontium";
 	lt9611->bridge.product = "LT9611";
-- 
2.43.0

base-commit: 310326bb7df4bba094a3fc60364c641c547fd923
branch: drm-misc-next



             reply	other threads:[~2026-02-10  7:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-10  7:08 Andy Yan [this message]
2026-02-11  6:42 ` Claude review: drm/bridge: lt9611: Remove DRM_BRIDGE_OP_MODES flag Claude Code Review Bot
2026-02-11  6:42 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260210070821.570062-1-andyshrk@163.com \
    --to=andyshrk@163.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox