[PATCH] drm/gpusvm: Fix drm_gpusvm_pages_valid_unlocked() kernel-doc

[PATCH] drm/gpusvm: Fix drm_gpusvm_pages_valid_unlocked() kernel-doc

[Matthew Brost]

The kernel-doc for drm_gpusvm_pages_valid_unlocked() was stale and still
referenced old range-based arguments and naming. Update the documentation
to match the current function arguments and signature.

Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
 drivers/gpu/drm/drm_gpusvm.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/drm_gpusvm.c b/drivers/gpu/drm/drm_gpusvm.c
index 81626b00b755..2e229bc944f0 100644
--- a/drivers/gpu/drm/drm_gpusvm.c
+++ b/drivers/gpu/drm/drm_gpusvm.c
@@ -1338,14 +1338,14 @@ bool drm_gpusvm_range_pages_valid(struct drm_gpusvm *gpusvm,
 EXPORT_SYMBOL_GPL(drm_gpusvm_range_pages_valid);
 
 /**
- * drm_gpusvm_range_pages_valid_unlocked() - GPU SVM range pages valid unlocked
+ * drm_gpusvm_pages_valid_unlocked() - GPU SVM pages valid unlocked
  * @gpusvm: Pointer to the GPU SVM structure
- * @range: Pointer to the GPU SVM range structure
+ * @svm_pages: Pointer to the GPU SVM pages structure
  *
- * This function determines if a GPU SVM range pages are valid. Expected be
- * called without holding gpusvm->notifier_lock.
+ * This function determines if a GPU SVM pages are valid. Expected be called
+ * without holding gpusvm->notifier_lock.
  *
- * Return: True if GPU SVM range has valid pages, False otherwise
+ * Return: True if GPU SVM pages are valid, False otherwise
  */
 static bool drm_gpusvm_pages_valid_unlocked(struct drm_gpusvm *gpusvm,
 					    struct drm_gpusvm_pages *svm_pages)
-- 
2.34.1

Claude review: drm/gpusvm: Fix drm_gpusvm_pages_valid_unlocked() kernel-doc

[Claude Code Review Bot]

Overall Series Review

Subject: drm/gpusvm: Fix drm_gpusvm_pages_valid_unlocked() kernel-doc
Author: Matthew Brost <matthew.brost@intel.com>
Patches: 1
Reviewed: 2026-02-23T06:29:02.386965

---

This is a single-patch series that fixes stale kernel-doc comments for `drm_gpusvm_pages_valid_unlocked()`. The function was apparently renamed from `drm_gpusvm_range_pages_valid_unlocked()` and its second parameter changed from `range` (of type `struct drm_gpusvm_range *`) to `svm_pages` (of type `struct drm_gpusvm_pages *`), but the kernel-doc comment was not updated at that time. This patch corrects that oversight.

The fix is accurate: the kernel-doc function name, parameter name, and description now match the actual function signature and semantics. No functional code is changed.

---
Generated by Claude Code Patch Reviewer

Claude review: drm/gpusvm: Fix drm_gpusvm_pages_valid_unlocked() kernel-doc

[Claude Code Review Bot]

Patch Review

Documentation-only fix, no issues with correctness.

> - * drm_gpusvm_range_pages_valid_unlocked() - GPU SVM range pages valid unlocked
> + * drm_gpusvm_pages_valid_unlocked() - GPU SVM pages valid unlocked

Correctly matches the actual function name.

> - * @range: Pointer to the GPU SVM range structure
> + * @svm_pages: Pointer to the GPU SVM pages structure

Correctly matches the actual parameter name and type (`struct drm_gpusvm_pages *svm_pages`).

> + * This function determines if a GPU SVM pages are valid. Expected be called

Minor: the grammar "if a GPU SVM pages are valid" reads awkwardly — "if GPU SVM pages are valid" (dropping the article "a") would be more natural. Similarly, "Expected be called" is missing "to" — should be "Expected to be called." These were pre-existing issues in the old text ("if a GPU SVM range pages are valid") so this patch isn't making things worse, but since the lines are being touched anyway it would be a good opportunity to clean up the grammar.

Otherwise, the patch is correct and does what the commit message says.

---
Generated by Claude Code Patch Reviewer