From: Koen Koning <koen.koning@linux.intel.com>
To: dri-devel@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org,
Joel Fernandes <joelagnelf@nvidia.com>,
Matthew Auld <matthew.auld@intel.com>,
Danilo Krummrich <dakr@kernel.org>,
Koen Koning <koen.koning@linux.intel.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>
Subject: [PATCH v3 3/3] drm/drv: fix module_init() usage
Date: Thu, 19 Feb 2026 22:38:58 +0100 [thread overview]
Message-ID: <20260219213858.370675-4-koen.koning@linux.intel.com> (raw)
In-Reply-To: <20260219213858.370675-1-koen.koning@linux.intel.com>
Use subsys_initcall() instead of module_init() (which compiles to
device_initcall() for built-ins) for drm_drv, so its initialization code
always runs before any (built-in) drivers.
This happened to work correctly so far due to the order of linking in
the Makefiles, but this should not be relied upon.
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Danilo Krummrich <dakr@kernel.org>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Airlie <airlied@gmail.com>
Cc: Simona Vetter <simona@ffwll.ch>
Signed-off-by: Koen Koning <koen.koning@linux.intel.com>
---
drivers/gpu/drm/drm_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
index 2915118436ce..db974f769692 100644
--- a/drivers/gpu/drm/drm_drv.c
+++ b/drivers/gpu/drm/drm_drv.c
@@ -1271,5 +1271,5 @@ static int __init drm_core_init(void)
return ret;
}
-module_init(drm_core_init);
+subsys_initcall(drm_core_init);
module_exit(drm_core_exit);
--
2.48.1
next prev parent reply other threads:[~2026-02-19 21:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-13 15:20 [PATCH] gpu: Fix uninitialized buddy for built-in drivers Koen Koning
2026-02-13 17:27 ` Joel Fernandes
2026-02-16 10:28 ` Matthew Auld
2026-02-22 20:25 ` Claude review: " Claude Code Review Bot
2026-02-22 20:25 ` Claude Code Review Bot
2026-02-16 11:19 ` [PATCH v2] " Koen Koning
2026-02-16 21:31 ` Joel Fernandes
2026-02-19 10:16 ` Danilo Krummrich
2026-02-19 10:38 ` Matthew Auld
2026-02-19 11:14 ` Danilo Krummrich
2026-02-19 12:44 ` Matthew Auld
2026-02-19 12:56 ` Danilo Krummrich
2026-02-19 15:32 ` Matthew Auld
2026-02-19 16:08 ` Danilo Krummrich
2026-02-19 18:28 ` Koen Koning
2026-02-19 18:34 ` Danilo Krummrich
2026-02-19 21:38 ` [PATCH v3 0/3] gpu: fix module_init() usage Koen Koning
2026-02-19 21:38 ` [PATCH v3 1/3] gpu/buddy: " Koen Koning
2026-02-20 6:06 ` Greg KH
2026-02-20 10:17 ` Danilo Krummrich
2026-02-20 13:55 ` Joel Fernandes
2026-02-21 5:44 ` Greg KH
2026-02-19 21:38 ` [PATCH v3 2/3] drm/sched: " Koen Koning
2026-02-20 6:06 ` Greg KH
2026-02-19 21:38 ` Koen Koning [this message]
2026-02-22 20:25 ` Claude review: gpu: " Claude Code Review Bot
2026-02-22 20:25 ` Claude review: gpu: Fix uninitialized buddy for built-in drivers Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260219213858.370675-4-koen.koning@linux.intel.com \
--to=koen.koning@linux.intel.com \
--cc=airlied@gmail.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=joelagnelf@nvidia.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthew.auld@intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox