From: Randy Dunlap <rdunlap@infradead.org>
To: dri-devel@lists.freedesktop.org
Cc: Randy Dunlap <rdunlap@infradead.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2] drm/gpusvm: correct kernel-doc for drm_gpusvm_pages_valid_unlocked()
Date: Thu, 19 Feb 2026 13:55:10 -0800 [thread overview]
Message-ID: <20260219215510.466906-1-rdunlap@infradead.org> (raw)
Use the correct function name and parameter description to avoid these
warnings:
WARNING: drivers/gpu/drm/drm_gpusvm.c:1351 function parameter 'svm_pages'
not described in 'drm_gpusvm_pages_valid_unlocked'
WARNING: drivers/gpu/drm/drm_gpusvm.c:1351 expecting prototype for
drm_gpusvm_range_pages_valid_unlocked(). Prototype was for
drm_gpusvm_pages_valid_unlocked() instead
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
v2: rebase & resend
Cc: David Airlie <airlied@gmail.com>
Cc: Simona Vetter <simona@ffwll.ch>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/drm_gpusvm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-next-20260218.orig/drivers/gpu/drm/drm_gpusvm.c
+++ linux-next-20260218/drivers/gpu/drm/drm_gpusvm.c
@@ -1338,9 +1338,9 @@ bool drm_gpusvm_range_pages_valid(struct
EXPORT_SYMBOL_GPL(drm_gpusvm_range_pages_valid);
/**
- * drm_gpusvm_range_pages_valid_unlocked() - GPU SVM range pages valid unlocked
+ * drm_gpusvm_pages_valid_unlocked() - GPU SVM range pages valid unlocked
* @gpusvm: Pointer to the GPU SVM structure
- * @range: Pointer to the GPU SVM range structure
+ * @svm_pages: Pointer to the GPU SVM pages structure
*
* This function determines if a GPU SVM range pages are valid. Expected be
* called without holding gpusvm->notifier_lock.
next reply other threads:[~2026-02-19 21:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 21:55 Randy Dunlap [this message]
2026-02-22 20:21 ` Claude review: drm/gpusvm: correct kernel-doc for drm_gpusvm_pages_valid_unlocked() Claude Code Review Bot
2026-02-22 20:21 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260219215510.466906-1-rdunlap@infradead.org \
--to=rdunlap@infradead.org \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox