From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B143C55164 for ; Fri, 20 Feb 2026 08:44:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D138710E7CF; Fri, 20 Feb 2026 08:44:32 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="F3U+wj1D"; dkim-atps=neutral Received: from mail-yx1-f47.google.com (mail-yx1-f47.google.com [74.125.224.47]) by gabe.freedesktop.org (Postfix) with ESMTPS id 72BCD10E33E for ; Thu, 19 Feb 2026 22:44:45 +0000 (UTC) Received: by mail-yx1-f47.google.com with SMTP id 956f58d0204a3-64ad8435f46so1310947d50.1 for ; Thu, 19 Feb 2026 14:44:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771541084; x=1772145884; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pH/3gnQr87FHbNqJn52DgWvIFWAoFRDTMQB92zG80ZM=; b=F3U+wj1DeXktfomb1ARwcZcR+tci1iGnSlq5O8LlzZfvqP5kYxaBK52cYWuc5aB24n 4Gzhwtb0wJEC2FSAHK9NMLpBv2eAKAQy4+H9F46PAjpTBsq9MhPlClVty8yIXNLNHx+8 UgedsBJGSExff6uS853t0eOk/w1kl2qFwqFfaREgq+ddS1ykLzM0WIaf4wTGwcfEQwXP WK9h7yiev4CvCPKUTaWupYSObpp3GJXeKIQRgr71rN1SDu/r8rvpIDnKQiV3VAwimkGH ZpPv6GB8gxwRw6Uk4KEmirewXhwxr/+I9D2lrFfNr8QWIOmjdjhjMhrJVlouI5CK9Gbc 6dXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771541084; x=1772145884; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pH/3gnQr87FHbNqJn52DgWvIFWAoFRDTMQB92zG80ZM=; b=UdDKb3Qt2ZkrA33Sh5Ic5QwEaeX048q9j5J04uYaPXwaWhJrotYEcz74IUkFBC7djK WaS9JnXlS8fQsofIABm4i9cbNx9Unxf9iiIHjgnc0aQ4qSkhrWenQVb+jWwWu6Wl0+Fy R5ZfLzTem1TjJxjfQ+MqYbfOID4Yh2HVQn3Ym0D2LaYkpYy8xRkkgXK/NGhcoPFRXuzA ElA2S/WDNzitf+XjXRr88i5mYPLkvK1jESiwx+Ti46gUpnV/JRyzt5uPUYZtl4Fnh2yc wXUaajYJZ6K/IRwRLYlKEfd/1wZ/uPZ2lkPO4vtqnV+WlZl8NxknoDu2s6doqnWhlEne aTzg== X-Forwarded-Encrypted: i=1; AJvYcCU18K6a2Y0QObY2nlXZZI/v3mUFddYowxBAJKp3lYVAWjB40A/7Y8whTd3sO/IghnM0ffV8QYXC7NI=@lists.freedesktop.org X-Gm-Message-State: AOJu0YxrQGSSLjFuDODaXj1aR8Tsj4NhHzGXltbTDhdJ9B+GcnFufb/8 M6oijC5zZD2hnAZ4vq8C/NZWEorsWT1gBRRAUiKhkvWbYhfbSOOqZOt2 X-Gm-Gg: AZuq6aJH9nhVViHj674g6LyahXHEQe/IADX2908Z97tkN8UhXqtC2m6qBznqi5bmKYs 5ZaoB2yvTGo+jFrRzxmm2wGCTdJil1weVarqXlmSuJufAgT0ouqNxkSm7txwDQK+cmp8Ors6ma8 AfNRUDl1fNq4EJjDYHTxkj0H+DnAlBmSR8xXBbrmo1+GwhwqLZXWyQMR8ego6a2WgwqGOpsk03A JhbAxXDmGmd+tXHC/9Id1eemgKYjvdeZR3aO9BHQynGesITpYn64t9UUuQE6GZbBCp07qbX2MMs 95ipgGD/Bw7sblIDTqTeKid3s26cHWAEFwb8j+Zv/9w4oepgdejjZu4n4N5J6ZD4Ahelhc0MgJ8 muqwcGSxuchgVj6yyX0c41YHuiaU7XZC1xdvzKUBan8EWWCaVgVgMMT/RhyFOgxsCEFcT3W4uLl dak8NHZFAfPv6gCTplW7aNYdI/tu1glmUIv2R6XsQs7NWt2JgeVJmQS1bB+NoRTLug9tqJ7KLoZ ApAcl8EXUcE1JUDpPyRW9TSILn8cdwShsVJAqe0Jyk= X-Received: by 2002:a05:690e:1281:b0:64a:e61f:a6f7 with SMTP id 956f58d0204a3-64c21b599a4mr13503566d50.71.1771541084386; Thu, 19 Feb 2026 14:44:44 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64c22fb1d22sm7453050d50.17.2026.02.19.14.44.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 14:44:44 -0800 (PST) From: Ethan Tidmore To: Anitha Chrisanthus , Edmund Dea , David Airlie , Simona Vetter Cc: Sam Ravnborg , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH] drm/kmb: Fix error pointer dereference Date: Thu, 19 Feb 2026 16:44:26 -0600 Message-ID: <20260219224426.1122073-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Fri, 20 Feb 2026 08:44:31 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The function kmb_dsi_init() can return an error pointer and is checked for it, and once confirm here in this code block below, goes to the label err_free1: kmb->kmb_dsi = kmb_dsi_init(dsi_pdev); if (IS_ERR(kmb->kmb_dsi)) { drm_err(&kmb->drm, "failed to initialize DSI\n"); ret = PTR_ERR(kmb->kmb_dsi); goto err_free1; } At the label itself it dereferences the confirmed error pointer. err_free1: dev_set_drvdata(dev, NULL); kmb_dsi_host_unregister(kmb->kmb_dsi); return ret; } Add check for error pointer before running kmb_dsi_host_unregister(). Fixes: 7f7b96a8a0a18 ("drm/kmb: Add support for KeemBay Display") Signed-off-by: Ethan Tidmore --- drivers/gpu/drm/kmb/kmb_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/kmb/kmb_drv.c b/drivers/gpu/drm/kmb/kmb_drv.c index 7c2eb1152fc2..9eabbce7574f 100644 --- a/drivers/gpu/drm/kmb/kmb_drv.c +++ b/drivers/gpu/drm/kmb/kmb_drv.c @@ -576,7 +576,8 @@ static int kmb_probe(struct platform_device *pdev) drm_mode_config_cleanup(&kmb->drm); err_free1: dev_set_drvdata(dev, NULL); - kmb_dsi_host_unregister(kmb->kmb_dsi); + if (!IS_ERR(kmb->kmb_dsi)) + kmb_dsi_host_unregister(kmb->kmb_dsi); return ret; } -- 2.53.0