From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CC2DC54F5B for ; Fri, 20 Feb 2026 06:06:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8FE1710E139; Fri, 20 Feb 2026 06:06:17 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ysOn/ZQp"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2AA4F10E139; Fri, 20 Feb 2026 06:06:16 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 4209B61843; Fri, 20 Feb 2026 06:06:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 276E2C116D0; Fri, 20 Feb 2026 06:06:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1771567574; bh=K4J5kwrWG6Klaz0TWaWDwYqm9sura75BmlC5zDrxEic=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ysOn/ZQp+kpa+h+su/QdYoLZ9kPZfUB18kZEl0AJHkHijbDfpt0RdrOevuMjaVu81 l1PvMbTSwjKI86Bd9q1r25ghHZKdw5pWXi95I7G6jOF1Qg4KM01QWvN+HICS2qXn1A 3Z1DD67/W89jg84AxoptP8KaqH7t077dKwYf5hlM= Date: Fri, 20 Feb 2026 07:06:11 +0100 From: Greg KH To: Koen Koning Cc: dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, Joel Fernandes , Matthew Auld , Danilo Krummrich , Chunming Zhou , Alex Deucher , Lucas Stach , Matthew Brost , Philipp Stanner , Christian =?iso-8859-1?Q?K=F6nig?= , stable@vger.kernel.org Subject: Re: [PATCH v3 2/3] drm/sched: fix module_init() usage Message-ID: <2026022007-radiator-schnapps-e557@gregkh> References: <20260216111902.110286-1-koen.koning@linux.intel.com> <20260219213858.370675-1-koen.koning@linux.intel.com> <20260219213858.370675-3-koen.koning@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20260219213858.370675-3-koen.koning@linux.intel.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Feb 19, 2026 at 10:38:57PM +0100, Koen Koning wrote: > Use subsys_initcall() instead of module_init() (which compiles to > device_initcall() for built-ins) for sched_fence, so its initialization > code always runs before any (built-in) drivers. > This happened to work correctly so far due to the order of linking in > the Makefiles, but this should not be relied upon. The linking order of Makefiles should ALWAYS be relied on. If that were to somehow change, so many things will blow up. But be careful, none of this fixes the issue if you use modules, so you still have to have symbols resolving properly. >=20 > Fixes: 4983e48c85392 ("drm/sched: move fence slab handling to module init= /exit") > Cc: Chunming Zhou > Cc: Alex Deucher > Cc: Lucas Stach > Cc: Matthew Brost > Cc: Danilo Krummrich > Cc: Philipp Stanner > Cc: "Christian K=F6nig" > Cc: Matthew Auld > Cc: stable@vger.kernel.org Why is this for stable if it doesn't actually fix a real issue? thanks, greg k-h