From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94EA4E98E12 for ; Mon, 23 Feb 2026 09:18:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DCE2E10E2A9; Mon, 23 Feb 2026 09:18:05 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Fz7QiV0k"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id C265D10E2A6; Mon, 23 Feb 2026 09:18:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771838284; x=1803374284; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=7L5Si+U91dVFjEdTKtV+P5IUccmHiFVoNzP7dhZfTzM=; b=Fz7QiV0ka8ueVJdq0dqyXphfFWX2jLU/gDXnmk6oqycOgQ21dWwsorqu eOJLKe5U+roTaWPX7/u2Cc61D6ZKgigD+yM0TSaToLGIj0YkBe0QhxLRA izuRaZroKOjvuT7xx5zFZb927Bza3v+F8/ZKg8uRk/ajcFpc8L0e8VAoT dgUMeZ1AUmOPaWfMF0vYqE92Ck3cneKgcebxGIojQ1btMZBSzLKwxzHfp pQXvyvhg5Yf56q4ce5x8gcyAv0zRyIrU4Uf8HHlqxbw91jkvpgWD8krfO jeYOCfhm84aEtcw/nLjnl32GuM2zNW6i/4UdjlKLVhv1qj0wLY9bMPil5 w==; X-CSE-ConnectionGUID: yihhWUDJR62Ced18z4wBwQ== X-CSE-MsgGUID: /E8IzwRLRIy7xgy+a4qchQ== X-IronPort-AV: E=McAfee;i="6800,10657,11709"; a="76690801" X-IronPort-AV: E=Sophos;i="6.21,306,1763452800"; d="scan'208";a="76690801" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2026 01:18:03 -0800 X-CSE-ConnectionGUID: xmuhz2RXT+yJFm5tug3SQA== X-CSE-MsgGUID: +rzWI/oOSwWQ44k5vlghDw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,306,1763452800"; d="scan'208";a="220048838" Received: from srr4-3-linux-106-armuthy.iind.intel.com ([10.190.238.56]) by fmviesa005.fm.intel.com with ESMTP; 23 Feb 2026 01:17:58 -0800 From: Arun R Murthy Date: Mon, 23 Feb 2026 14:46:04 +0530 Subject: [PATCH v10 6/7] drm/i915/display: Error codes for async flip failures MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260223-atomic-v10-6-f59c8def2e70@intel.com> References: <20260223-atomic-v10-0-f59c8def2e70@intel.com> In-Reply-To: <20260223-atomic-v10-0-f59c8def2e70@intel.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , xaver.hugl@kde.org, harry.wentland@amd.com, uma.shankar@intel.com, louis.chauvet@bootlin.com, naveen1.kumar@intel.com, ramya.krishna.yella@intel.com Cc: "Imported from f20260210-atomic-v9-5-525c88fd2402"@intel.com, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, Arun R Murthy , Suraj Kandpal X-Mailer: b4 0.15-dev X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" For failures in async flip atomic check/commit path return user readable error codes in struct drm_atomic_state. v8: Replaced DRM_MODE_ATOMIC_ASYNC_NOT_SUPP_PLANE, DRM_MODE_ATOMIC_ASYNC_MODIFIER_NOT_SUPP with INVALUD_API_USAGE (Xaver) Signed-off-by: Arun R Murthy Reviewed-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_display.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index 33821cc2948b6ea1f96a8adceb459a08c255d9e3..b648dbe1f0b3c70eef093f32e3e35d9187961d94 100644 --- a/drivers/gpu/drm/i915/display/intel_display.c +++ b/drivers/gpu/drm/i915/display/intel_display.c @@ -6055,9 +6055,10 @@ static int intel_async_flip_check_uapi(struct intel_atomic_state *state, } if (intel_crtc_needs_modeset(new_crtc_state)) { - drm_dbg_kms(display->drm, - "[CRTC:%d:%s] modeset required\n", - crtc->base.base.id, crtc->base.name); + drm_mode_atomic_add_error_msg(&state->base.error_code, + DRM_MODE_ATOMIC_CRTC_NEED_FULL_MODESET, + "[CRTC:%d:%s] requires full modeset", + crtc->base.base.id, crtc->base.name); return -EINVAL; } @@ -6124,9 +6125,10 @@ static int intel_async_flip_check_hw(struct intel_atomic_state *state, struct in } if (intel_crtc_needs_modeset(new_crtc_state)) { - drm_dbg_kms(display->drm, - "[CRTC:%d:%s] modeset required\n", - crtc->base.base.id, crtc->base.name); + drm_mode_atomic_add_error_msg(&state->base.error_code, + DRM_MODE_ATOMIC_CRTC_NEED_FULL_MODESET, + "[CRTC:%d:%s] requires full modeset", + crtc->base.base.id, crtc->base.name); return -EINVAL; } @@ -6164,11 +6166,12 @@ static int intel_async_flip_check_hw(struct intel_atomic_state *state, struct in if (!intel_plane_can_async_flip(plane, new_plane_state->hw.fb->format, new_plane_state->hw.fb->modifier)) { - drm_dbg_kms(display->drm, - "[PLANE:%d:%s] pixel format %p4cc / modifier 0x%llx does not support async flip\n", - plane->base.base.id, plane->base.name, - &new_plane_state->hw.fb->format->format, - new_plane_state->hw.fb->modifier); + drm_mode_atomic_add_error_msg(&state->base.error_code, + DRM_MODE_ATOMIC_INVALID_API_USAGE, + "[PLANE:%d:%s] pixel format %p4cc / 0x%llx modifier does not support async flip", + plane->base.base.id, plane->base.name, + &new_plane_state->hw.fb->format->format, + new_plane_state->hw.fb->modifier); return -EINVAL; } -- 2.25.1