From: Hayden Heins <hayden.heins@gmail.com>
To: harry.wentland@amd.com, sunpeng.li@amd.com, siqueira@igalia.com
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
Hayden Heins <hayden.heins@gmail.com>
Subject: [PATCH] drm/amd/display: Fix incorrect log message in LTTPR mode selection
Date: Sun, 22 Feb 2026 21:51:56 -0500 [thread overview]
Message-ID: <20260223025156.27490-1-hayden.heins@gmail.com> (raw)
The driver was logging that it chose NON_TRANSPARENT mode while actually
returning TRANSPARENT mode in the case where vbios_lttpr_aware is set
but vbios_lttpr_force_non_transparent is not.This upgades the log message
to match what the code is actually doing.
Signed-off-by: Hayden Heins <hayden.heins@gmail.com>
---
.../amd/display/dc/link/protocols/link_dp_training_8b_10b.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training_8b_10b.c b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training_8b_10b.c
index 66d0fb1b9..889c81aba 100644
--- a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training_8b_10b.c
+++ b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training_8b_10b.c
@@ -166,7 +166,8 @@ enum lttpr_mode dp_decide_8b_10b_lttpr_mode(struct dc_link *link)
DC_LOG_DC("chose LTTPR_MODE_NON_TRANSPARENT due to VBIOS DCE_INFO_CAPS_LTTPR_SUPPORT_ENABLE set to 1.\n");
return LTTPR_MODE_NON_TRANSPARENT;
} else {
- DC_LOG_DC("chose LTTPR_MODE_NON_TRANSPARENT by default due to VBIOS not set DCE_INFO_CAPS_LTTPR_SUPPORT_ENABLE set to 1.\n");
+ DC_LOG_DC("chose LTTPR_MODE_TRANSPARENT by default due to VBIOS not set "
+ "DCE_INFO_CAPS_LTTPR_SUPPORT_ENABLE set to 1.\n");
return LTTPR_MODE_TRANSPARENT;
}
}
--
2.53.0
next reply other threads:[~2026-02-23 9:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 2:51 Hayden Heins [this message]
2026-02-24 0:28 ` Claude review: drm/amd/display: Fix incorrect log message in LTTPR mode selection Claude Code Review Bot
2026-02-24 0:28 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260223025156.27490-1-hayden.heins@gmail.com \
--to=hayden.heins@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=siqueira@igalia.com \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox