[PATCH] drm/amd/display: Fix incorrect log message in LTTPR mode selection

[PATCH] drm/amd/display: Fix incorrect log message in LTTPR mode selection

[Hayden Heins]

The driver was logging that it chose NON_TRANSPARENT mode while actually
returning TRANSPARENT mode in the case where vbios_lttpr_aware is set
but vbios_lttpr_force_non_transparent is not.This upgades the log message
to match what the code is actually doing.

Signed-off-by: Hayden Heins <hayden.heins@gmail.com>
---
 .../amd/display/dc/link/protocols/link_dp_training_8b_10b.c    | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training_8b_10b.c b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training_8b_10b.c
index 66d0fb1b9..889c81aba 100644
--- a/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training_8b_10b.c
+++ b/drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_training_8b_10b.c
@@ -166,7 +166,8 @@ enum lttpr_mode dp_decide_8b_10b_lttpr_mode(struct dc_link *link)
 			DC_LOG_DC("chose LTTPR_MODE_NON_TRANSPARENT due to VBIOS DCE_INFO_CAPS_LTTPR_SUPPORT_ENABLE set to 1.\n");
 			return LTTPR_MODE_NON_TRANSPARENT;
 		} else {
-			DC_LOG_DC("chose LTTPR_MODE_NON_TRANSPARENT by default due to VBIOS not set DCE_INFO_CAPS_LTTPR_SUPPORT_ENABLE set to 1.\n");
+			DC_LOG_DC("chose LTTPR_MODE_TRANSPARENT by default due to VBIOS not set "
+				"DCE_INFO_CAPS_LTTPR_SUPPORT_ENABLE set to 1.\n");
 			return LTTPR_MODE_TRANSPARENT;
 		}
 	}
-- 
2.53.0

Claude review: drm/amd/display: Fix incorrect log message in LTTPR mode selection

[Claude Code Review Bot]

Overall Series Review

Subject: drm/amd/display: Fix incorrect log message in LTTPR mode selection
Author: Hayden Heins <hayden.heins@gmail.com>
Patches: 1
Reviewed: 2026-02-24T10:28:00.718441

---

This is a single-patch submission that fixes a log message in the AMDGPU display driver's LTTPR (Link Training Tunable PHY Repeater) mode selection for 8b/10b DP link training. The code at line 171 returns `LTTPR_MODE_TRANSPARENT`, but the log message previously said `LTTPR_MODE_NON_TRANSPARENT`. The fix changes the log to say `LTTPR_MODE_TRANSPARENT`, matching the actual return value.

The fix is correct and straightforward. There are no resource management, locking, or UAPI concerns.

---
Generated by Claude Code Patch Reviewer

Claude review: drm/amd/display: Fix incorrect log message in LTTPR mode selection

[Claude Code Review Bot]

Patch Review

The bug is real: when `vbios_lttpr_aware` is true but `vbios_lttpr_force_non_transparent` is false, the code returns `LTTPR_MODE_TRANSPARENT` but the old log message said `LTTPR_MODE_NON_TRANSPARENT`. The fix correctly changes the log to match the return value.

> -			DC_LOG_DC("chose LTTPR_MODE_NON_TRANSPARENT by default due to VBIOS not set DCE_INFO_CAPS_LTTPR_SUPPORT_ENABLE set to 1.\n");
> +			DC_LOG_DC("chose LTTPR_MODE_TRANSPARENT by default due to VBIOS not set "
> +				"DCE_INFO_CAPS_LTTPR_SUPPORT_ENABLE set to 1.\n");
>  			return LTTPR_MODE_TRANSPARENT;

The log text fix is correct. The string split across two lines is fine — the compiler concatenates adjacent string literals.

One minor note: the commit message has a typo — "This upgades the log message" should be "This updates the log message". Also, "upgades" aside, the phrasing is a bit unusual; something like "Fix the log message to match" would be more standard. This doesn't affect the code itself but is worth fixing before applying if the maintainer cares.

No other issues found. The patch is correct and ready to apply (modulo the commit message typo).

---
Generated by Claude Code Patch Reviewer