public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: "David E. Box" <david.e.box@linux.intel.com>
To: thomas.hellstrom@linux.intel.com, rodrigo.vivi@intel.com,
	irenic.rajneesh@gmail.com, ilpo.jarvinen@linux.intel.com,
	srinivas.pandruvada@linux.intel.com,
	intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	xi.pardee@linux.intel.com
Cc: david.e.box@linux.intel.com, hansg@kernel.org,
	linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org
Subject: [PATCH v5 0/6] platform/x86/intel/vsec: Prep for ACPI PMT discovery
Date: Tue, 24 Feb 2026 17:50:06 -0800	[thread overview]
Message-ID: <20260224-upstream-pmt-acpi-v5-v5-0-8dd73bcf049c@linux.intel.com> (raw)

This series updates intel_vsec to improve const-correctness, decouple
helper APIs from PCI, enhance error handling, and plumb ACPI-based Intel
Platform Monitoring Technology (PMT) discovery through the vsec layer. It
is preparatory infrastructure for follow-on PMT core/telemetry and
PMC/SSRAM series that add ACPI discovery and support for new platforms.

The series is organized as follows:

Patches 1-2 refactor and improve const-correctness of base_addr handling.
Patch 1 makes base_addr an explicit parameter throughout the call chain,
clarifying ownership and removing conditional logic. Patch 2 then makes the
platform info data structure read-only, preventing unintended modifications
to shared driver data.

Patches 3-4 decouple the vsec layer from PCI-specific types, updating
helper APIs and data structures to use generic struct device instead of
struct pci_dev.  This enables vsec to work with both PCI and ACPI parent
devices.

Patch 5 enhances error visibility by returning meaningful error codes from
the registration path instead of collapsing to boolean success/failure.

Patch 6 adds infrastructure for ACPI-based PMT discovery, allowing client
drivers to consume discovery data from either PCI or ACPI sources.

Signed-off-by: David E. Box <david.e.box@linux.intel.com>

David E. Box (6):
      platform/x86/intel/vsec: Refactor base_addr handling
      platform/x86/intel/vsec: Make driver_data info const
      platform/x86/intel/vsec: Decouple add/link helpers from PCI
      platform/x86/intel/vsec: Switch exported helpers from pci_dev to device
      platform/x86/intel/vsec: Return real error codes from registration path
      platform/x86/intel/vsec: Plumb ACPI PMT discovery tables through vsec

 drivers/gpu/drm/xe/xe_debugfs.c                  |   2 +-
 drivers/gpu/drm/xe/xe_hwmon.c                    |   2 +-
 drivers/gpu/drm/xe/xe_vsec.c                     |   7 +-
 drivers/gpu/drm/xe/xe_vsec.h                     |   4 +-
 drivers/platform/x86/intel/pmc/core.c            |   4 +-
 drivers/platform/x86/intel/pmc/ssram_telemetry.c |   2 +-
 drivers/platform/x86/intel/pmt/class.c           |   8 +-
 drivers/platform/x86/intel/pmt/class.h           |   5 +-
 drivers/platform/x86/intel/pmt/discovery.c       |   4 +-
 drivers/platform/x86/intel/pmt/telemetry.c       |  13 +--
 drivers/platform/x86/intel/pmt/telemetry.h       |  12 +--
 drivers/platform/x86/intel/sdsi.c                |   5 +-
 drivers/platform/x86/intel/vsec.c                | 121 ++++++++++++++---------
 drivers/platform/x86/intel/vsec_tpmi.c           |  10 +-
 include/linux/intel_vsec.h                       |  39 ++++++--
 15 files changed, 144 insertions(+), 94 deletions(-)
---
base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
-- 

             reply	other threads:[~2026-02-25  1:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25  1:50 David E. Box [this message]
2026-02-25  1:50 ` [PATCH v5 1/6] platform/x86/intel/vsec: Refactor base_addr handling David E. Box
2026-02-27  4:12   ` Claude review: " Claude Code Review Bot
2026-02-25  1:50 ` [PATCH v5 2/6] platform/x86/intel/vsec: Make driver_data info const David E. Box
2026-02-27  4:12   ` Claude review: " Claude Code Review Bot
2026-02-25  1:50 ` [PATCH v5 3/6] platform/x86/intel/vsec: Decouple add/link helpers from PCI David E. Box
2026-02-27  4:12   ` Claude review: " Claude Code Review Bot
2026-02-25  1:50 ` [PATCH v5 4/6] platform/x86/intel/vsec: Switch exported helpers from pci_dev to device David E. Box
2026-02-27  4:12   ` Claude review: " Claude Code Review Bot
2026-02-25  1:50 ` [PATCH v5 5/6] platform/x86/intel/vsec: Return real error codes from registration path David E. Box
2026-02-27  4:12   ` Claude review: " Claude Code Review Bot
2026-02-25  1:50 ` [PATCH v5 6/6] platform/x86/intel/vsec: Plumb ACPI PMT discovery tables through vsec David E. Box
2026-02-27  4:12   ` Claude review: " Claude Code Review Bot
2026-02-27  4:12 ` Claude review: platform/x86/intel/vsec: Prep for ACPI PMT discovery Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260224-upstream-pmt-acpi-v5-v5-0-8dd73bcf049c@linux.intel.com \
    --to=david.e.box@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=irenic.rajneesh@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=thomas.hellstrom@linux.intel.com \
    --cc=xi.pardee@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox