From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14EC6F357D5 for ; Wed, 25 Feb 2026 07:42:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5396310E6C8; Wed, 25 Feb 2026 07:42:34 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="EPYgKety"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EVr0I95h"; dkim-atps=neutral Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3DF2A10E6C8 for ; Wed, 25 Feb 2026 07:42:33 +0000 (UTC) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61P4KTpj3333690 for ; Wed, 25 Feb 2026 07:42:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=U+vqTvzL08oUPkG0pMAzCq HOh982jZJf7ubG7c1Z69Y=; b=EPYgKetyn525mInCE9ZPJUyzmns/5mZClS2JrU evfiJuNT+QjDexyhZ6HAu7+RcUf3YIbKAwOyVK0EQNTJ+pAFfd3Ds5Q7QfSdORF+ jwOsEMgotIjP/97u/5nbUOiSp4qMmCpGUX/qh6ZTQzYJ3nJPmspYj/ihVMoqI+Ln kd3l/AsOx5ynFNRzNyWwnjiTIHP9Gs7QhO1gie4qYgwQkto5K1LxKzy9FKIdlRNX PMtV0pxvB5lzDcs5IsDnGoNJqB9EV31gmP7RZ6FPs2oUZwwmnB7Y+iLg6zCIMffe yDwL3zH6ul6apVLtepUOTo1n8FoDzlyPt41YadHC//W9/1tg== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4chh47238b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 25 Feb 2026 07:42:32 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-35658758045so4529844a91.3 for ; Tue, 24 Feb 2026 23:42:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772005352; x=1772610152; darn=lists.freedesktop.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=U+vqTvzL08oUPkG0pMAzCqHOh982jZJf7ubG7c1Z69Y=; b=EVr0I95hoLjFP3FBuqs6af8dle1MUcLUJ3ZQqsxilMDY0bu5FjT1SRFOiIa78GWh5/ 9pB93tu/NJENOzm0O87iDxjodlIUC9G4pOGHP9FqKEcicuhDVur3kQc07i4g0h9wuW4h l3apaFdpT5meRUsTDvBELQB2ogPZ9YLgfIz2ok1THBvHAHcYdJ8h5lmbY2hBOmvyRbo5 RNZ5YiUdZF5+1Xp73unnON956cqer2nrH4tzI52udng5TqP81ONPwUE5Uf724DWIK/Im B5v3/m2iJmLH4DG55koQSFE1F8iWv6leC+codUX4M0no6oSgBkbOND4yNiHuWhKDl4sZ U7sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772005352; x=1772610152; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=U+vqTvzL08oUPkG0pMAzCqHOh982jZJf7ubG7c1Z69Y=; b=FZke63fXZXra6NldilRoFMzA8kXokSzXFM0OUZggbKZdS9C/Hp3RnIyxMJAcFwQ1q4 xl18p9Aaw15xF0IHpCyWKuZ9rtc0bQSDvQEQUGoV23eFBMxwo/6VNc9cCqVkGvDpN0jH Pe8Xtr7AYnDs1jVNv7icGGo3Hkuk1gt5dRXHwfAK8QXb/DpH5nxa/sb+n9+MenfnONeB pHxPutapZQchlYVsBwvtEEMuqXJ7428vXC4X2xYoGdiZiuCLwGE1w+lpFTaFobyfiTxL jpk5t/mOzcDt34V4PRQT62ATuYk+Kw8RSey5o4DigH0ID6qLfmLdcssQWCCHmU5c66mf k3kg== X-Forwarded-Encrypted: i=1; AJvYcCXDstXb+fB/8QnOVAbl7yI37dB/FAG11FOi9FoTM70CdTKvoqZRyOC6kYs0FB6z7fP0c7tupAnqx08=@lists.freedesktop.org X-Gm-Message-State: AOJu0YwEpfHppf0ItEiQRFHAld/2jekIX4wmY/xNhN+sSK+8L7raga15 ws0pRGugRpyNQdtgEsD6PcijMBytRq2b4bOMOd/Qmm5etBfvidIXvVZLHP7Gb7ccLFmb64qYu3w deDnDD2+fg8oHR/KBWpOn2PtU7M3bY1cOmB/cP3R2F+UgHmMJsCid3nd1dms0WEwkpffQyJU= X-Gm-Gg: ATEYQzziwLF/S9t+kAy5RNHpiVYbu3Hzkt76+qbxx/ytaee1W8GtFcuJhLa3WZYbxeW NaFqjMg3uRPOG2Jx86r/2JkIGFvxL1kuPn+Xogdh7WbCa2pryMGX2ksWLkoqI8PR85afW6/70DA dfKjH/vdm4Qv2aEb8wbf3B5LJ6pFCeibl1WxJZojEr1qspiwpHX8b2uYgmZq2kNRBJrw06yjHfi JAFz27iCr+coRErtdKhLqU6eMMmA+bRAUBv4lxDOytSg74gRMgS6HT2+IqAfV0Jy3tVkuaQ1QaY LOEIzrxtcjZU0lE4Wk3LBjNfeffEW7MvsK98XNZGvNFvtpWSBlVmF1dZryN6fg04CD+7zVdJAx7 6tvAu1KQ2Wwn3vFZZ4wAq8uAmey93r6qHfcqvhtBdjrXfjA== X-Received: by 2002:a17:90b:5185:b0:340:b912:536 with SMTP id 98e67ed59e1d1-3590f1f3c09mr1234210a91.31.1772005351813; Tue, 24 Feb 2026 23:42:31 -0800 (PST) X-Received: by 2002:a17:90b:5185:b0:340:b912:536 with SMTP id 98e67ed59e1d1-3590f1f3c09mr1234196a91.31.1772005351377; Tue, 24 Feb 2026 23:42:31 -0800 (PST) Received: from hu-akhilpo-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3590158f91esm1927304a91.4.2026.02.24.23.42.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 23:42:31 -0800 (PST) From: Akhil P Oommen Date: Wed, 25 Feb 2026 13:11:57 +0530 Subject: [PATCH] drm/msm/a6xx: Fix the bogus protect error on X2-85 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260225-glymur-protect-fix-v1-1-0deddedf9277@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAMSnnmkC/yWMQQ6CMBBFr0Jm7URoggpXMSzaMuAkluK0GA3h7 k7s4i/eT97bIZEwJeirHYTenDguCs2pAv+wy0zIozKY2lxqY1qcn9+wCa4SM/mME3+wa9zNXX1 L3WRBxVVI73/0PhQWem3azuUEZxOhjyFw7qtRAoYUzjos3nAcP4xza5mZAAAA X-Change-ID: 20260225-glymur-protect-fix-91b8b7c5e9fa To: Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Akhil P Oommen X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1772005346; l=1838; i=akhilpo@oss.qualcomm.com; s=20240726; h=from:subject:message-id; bh=J3GZ7dzqZ1AcdI0/dHMdYTU0hkgLk6CGn3qfq3mlT6I=; b=PoyQmorEsIc22SUrz1GbWovaZ8y+5pprIsoIsAOY0gtLA/IuQ9aPpSNQI0mWdYtRLMRHUDPFA Ujpy3kmfDWXDS0pf8lGrPQi018H7SvZOTgGGpnf/Vbed399bpyws9Ip X-Developer-Key: i=akhilpo@oss.qualcomm.com; a=ed25519; pk=lmVtttSHmAUYFnJsQHX80IIRmYmXA4+CzpGcWOOsfKA= X-Proofpoint-ORIG-GUID: N38tAxsGm7QsHHPNOM2RVOYsGE7xqPHp X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI1MDA3NCBTYWx0ZWRfX9wAmcBLIrdSJ Avgz6rqDxI7g8QajVzAICKo12/t5rLV1SbW8Jr0fHmZY1Sk6Z3sBlgxOg3RNMASsGNvXJyubtWY zUDJUuWwT6DJbBZvV4zBWw5/3MmU0cU/DhR83RJjDAd6+wiTUSEmojHU8y86+hZ+bmFJ8AGN2KY Obu/69Tg1k68iiAZX+VOQqRQf30/FofDT/7e5kPyoGChtPYnokX6veCAzaUvxE9o7WNz+J6Kb0l Sr3JtFHpNZrTsx/wHEWBi0UmC4DFCJ30tHRPbpLKa5N2SNE/FW57cRkmeHCqoIkIsdIGvzqq3AV vdT0uZdg92QQGal2Ziz8icMu/tR30utLwCgnquUHf4Zmfxw1RveSagQVSph+09FMNRsbKvVwDb2 IoDLq9hm/ASc9XA0SUaxjDO0BwamfpJ6Tt1I+mUX1sMDVQNUVY/zKUSRJohs54hEIzpoBsGWRpA uHhNcxMea23Z4VHuK3g== X-Authority-Analysis: v=2.4 cv=fvDRpV4f c=1 sm=1 tr=0 ts=699ea7e8 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=kDI2okBShA6p0kcQ2G4A:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-GUID: N38tAxsGm7QsHHPNOM2RVOYsGE7xqPHp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-24_03,2026-02-23_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 adultscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602250074 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Update the X2-85 gpu's register protect count configuration with the correct count_max value to avoid blocking the entire MMIO region from the UMD. Protect configurations are a bit complicated on A8xx. There are 2 set of protect registers with different counts: Global and Pipe-specific. The last-span-unbound feature is available only on the Pipe-specific protect registers. Due to this, we cannot use the BUILD_BUG sanity check for A8x protect configurations, so remove the A840 entry from there. Fixes: 01ff3bf27215 ("drm/msm/a8xx: Add support for Adreno X2-85 GPU") Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c index 550a53a7865e..38561f26837e 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c @@ -1759,7 +1759,7 @@ static const u32 x285_protect_regs[] = { A6XX_PROTECT_NORDWR(0x27c06, 0x0000), }; -DECLARE_ADRENO_PROTECT(x285_protect, 64); +DECLARE_ADRENO_PROTECT(x285_protect, 15); static const struct adreno_reglist_pipe a840_nonctxt_regs[] = { { REG_A8XX_CP_SMMU_STREAM_ID_LPAC, 0x00000101, BIT(PIPE_NONE) }, @@ -1966,5 +1966,4 @@ static inline __always_unused void __build_asserts(void) BUILD_BUG_ON(a660_protect.count > a660_protect.count_max); BUILD_BUG_ON(a690_protect.count > a690_protect.count_max); BUILD_BUG_ON(a730_protect.count > a730_protect.count_max); - BUILD_BUG_ON(a840_protect.count > a840_protect.count_max); } --- base-commit: ac47870fd795549f03d57e0879fc730c79119f4b change-id: 20260225-glymur-protect-fix-91b8b7c5e9fa Best regards, -- Akhil P Oommen