From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58F3CF357DA for ; Wed, 25 Feb 2026 10:11:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ADC6010E357; Wed, 25 Feb 2026 10:11:44 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="Zj+lvS5Y"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id B903B10E229 for ; Wed, 25 Feb 2026 10:11:42 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 630574364F; Wed, 25 Feb 2026 10:11:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAC4FC116D0; Wed, 25 Feb 2026 10:11:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772014302; bh=Jbx5GGqMd2E6b2ZjyMeLVTjfKScq4nrq/KUgU6bjUCE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Zj+lvS5Y+00B0Fj39FquAhjKWkqYbaE61U5/IZSPgWXnFy7HiTa3uNnHHywfXCP8m ixEh6FTZMIzZXbi5LnrTB+qkHDX3tiYenX448XirD+t5O535TDh0kYtq2pdREcWGAe p031f9LHV2sgmnUsZjxPAeApzfhnt8edwyY4Fxbm/SefYnwpI8ghT27Id8RcGsJ5Rs XlMqcvBZ9/C34H9mpDxdKvByxWeLaOMZc32AAbzZDHQzcW99puYbWHlpGyOJft1kX0 BO3pkbBDmpevoh2IgkpH3P6JpqKk4QsF2uJfm/22ZdtB0x9+9g7aWVQlPfEB2N6eej qKZd3CY/NOxog== Date: Wed, 25 Feb 2026 11:11:39 +0100 From: Maxime Ripard To: Erick Karanja Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Liu Ying , Dmitry Baryshkov , Luca Ceresoli , Shengjiu Wang , Andy Yan , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFT] drm/bridge: dw-hdmi: Replace calls to deprecated HDMI/audio detection functions Message-ID: <20260225-lush-dexterous-chimpanzee-ebdb6a@houat> References: <20260225093051.12031-1-karanja99erick@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha384; protocol="application/pgp-signature"; boundary="ljelcul7uze7np3h" Content-Disposition: inline In-Reply-To: <20260225093051.12031-1-karanja99erick@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --ljelcul7uze7np3h Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH RFT] drm/bridge: dw-hdmi: Replace calls to deprecated HDMI/audio detection functions MIME-Version: 1.0 Hi, On Wed, Feb 25, 2026 at 12:30:50PM +0300, Erick Karanja wrote: > Replace calls to the deprecated drm_detect_hdmi_monitor() and > drm_detect_monitor_audio() functions. Calling drm_edid_connector_update() > updates connector->display_info.is_hdmi and connector->display_info.has_a= udio. > The driver should read these fields from connector->display_info instead = of > calling the deprecated functions directly. >=20 > Signed-off-by: Erick Karanja > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 17 +++-------------- > 1 file changed, 3 insertions(+), 14 deletions(-) >=20 > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/= bridge/synopsys/dw-hdmi.c > index 3b77e73ac0ea..ddc4ae40d94e 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -2472,7 +2472,6 @@ static const struct drm_edid *dw_hdmi_edid_read(str= uct dw_hdmi *hdmi, > struct drm_connector *connector) > { > const struct drm_edid *drm_edid; > - const struct edid *edid; > =20 > if (!hdmi->ddc) > return NULL; > @@ -2482,19 +2481,9 @@ static const struct drm_edid *dw_hdmi_edid_read(st= ruct dw_hdmi *hdmi, > dev_dbg(hdmi->dev, "failed to get edid\n"); > return NULL; > } > - > - /* > - * FIXME: This should use connector->display_info.is_hdmi and > - * connector->display_info.has_audio from a path that has read the EDID > - * and called drm_edid_connector_update(). > - */ > - edid =3D drm_edid_raw(drm_edid); > - > - dev_dbg(hdmi->dev, "got edid: width[%d] x height[%d]\n", > - edid->width_cm, edid->height_cm); > - > - hdmi->sink_is_hdmi =3D drm_detect_hdmi_monitor(edid); > - hdmi->sink_has_audio =3D drm_detect_monitor_audio(edid); > + drm_edid_connector_update(connector, drm_edid); > + hdmi->sink_is_hdmi =3D connector->display_info.is_hdmi; > + hdmi->sink_has_audio =3D connector->display_info.has_audio; You should get rid of sink_is_hdmi and sink_has_audio, and you'll don't need to call any function anymore, deprecated or otherwise. Maxime --ljelcul7uze7np3h Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCaZ7K2gAKCRAnX84Zoj2+ djCvAXwJZPj4Z8NxSM3hG7+lpMa/QXpPdPtrtr9WZ8bpKzUDAEOxzaP2FughL6ZA VFy8FfMBgNj8KNyWFKlN56axzc0sQga2XyqZ8bEfqRZmjjluie/Fm0kZBM26CsYG GDzFG3mCFA== =RjVs -----END PGP SIGNATURE----- --ljelcul7uze7np3h--