public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Antonios Christidis <a-christidis@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Frank Binns <frank.binns@imgtec.com>,
	Matt Coster <matt.coster@imgtec.com>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-clk@vger.kernel.org
Subject: Re: [PATCH 2/5] dt-bindings: gpu: img: Add J721e SoC specific compatible
Date: Wed, 25 Feb 2026 12:06:56 +0100	[thread overview]
Message-ID: <20260225-malamute-of-perpetual-typhoon-2f0f65@quoll> (raw)
In-Reply-To: <20260224-gpu_dts-v1-2-cc5ddffe140c@ti.com>

On Tue, Feb 24, 2026 at 12:09:16PM -0600, Antonios Christidis wrote:
> Add J721e SoC specific compatible.
> 
> Signed-off-by: Antonios Christidis <a-christidis@ti.com>
> ---
>  Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> index a1f54dbae3f3..56249d1e65aa 100644
> --- a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> +++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> @@ -44,7 +44,11 @@ properties:
>                - ti,j721s2-gpu
>            - const: img,img-bxs-4-64
>            - const: img,img-rogue
> -
> +      - items:
> +          - enum:
> +              - ti,j721e-gpu
> +          - const: img,img-ge8430
> +          - const: img,img-rogue
>        # This legacy combination of compatible strings was introduced early on
>        # before the more specific GPU identifiers were used.
>        - items:
> @@ -103,6 +107,7 @@ allOf:
>                - ti,am62-gpu
>                - ti,am62p-gpu
>                - ti,j721s2-gpu
> +              - ti,j721e-gpu

What about img,img-ge8430? Why this one does not have constraints?

What about all other constraints?

>      then:
>        properties:
>          clocks:

Best regards,
Krzysztof


  parent reply	other threads:[~2026-02-25 11:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-24 18:09 [PATCH 0/5] drm/imagination: add support for j721e,j784s4,j722s,am62p Antonios Christidis
2026-02-24 18:09 ` [PATCH 1/5] arm64: dts: ti: k3-j721e: Add GPU node Antonios Christidis
2026-02-27  4:48   ` Claude review: " Claude Code Review Bot
2026-02-24 18:09 ` [PATCH 2/5] dt-bindings: gpu: img: Add J721e SoC specific compatible Antonios Christidis
2026-02-24 23:09   ` Andrew Davis
2026-02-25 11:06   ` Krzysztof Kozlowski [this message]
2026-02-27  4:48   ` Claude review: " Claude Code Review Bot
2026-02-24 18:09 ` [PATCH 3/5] arm64: dts: ti: k3-j784s4: Add GPU node Antonios Christidis
2026-02-27  4:48   ` Claude review: " Claude Code Review Bot
2026-02-24 18:09 ` [PATCH 4/5] arm64: dts: ti: add " a-christidis
2026-02-27  4:48   ` Claude review: " Claude Code Review Bot
2026-02-24 18:09 ` [PATCH 5/5] clk: keystone: don't cache clock rate a-christidis
2026-02-27  4:48   ` Claude review: " Claude Code Review Bot
2026-02-25  1:05 ` [PATCH 0/5] drm/imagination: add support for j721e,j784s4,j722s,am62p Nishanth Menon
2026-02-27  4:48 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260225-malamute-of-perpetual-typhoon-2f0f65@quoll \
    --to=krzk@kernel.org \
    --cc=a-christidis@ti.com \
    --cc=airlied@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=frank.binns@imgtec.com \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matt.coster@imgtec.com \
    --cc=mripard@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=ssantosh@kernel.org \
    --cc=tzimmermann@suse.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox