From: David Heidelberg via B4 Relay <devnull+david.ixit.cz@kernel.org>
To: Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <jesszhan0024@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Dzmitry Sankouski <dsankouski@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>
Cc: Casey Connolly <casey.connolly@linaro.org>,
marijn.suijten@somainline.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org,
David Heidelberg <david@ixit.cz>
Subject: [PATCH 2/4] drm/panel: Clean up S6E3FC2X01 config dependencies
Date: Thu, 26 Feb 2026 12:57:37 +0100 [thread overview]
Message-ID: <20260226-panel-clean-up-kconfig-dep-v1-2-bb28a2355b4c@ixit.cz> (raw)
In-Reply-To: <20260226-panel-clean-up-kconfig-dep-v1-0-bb28a2355b4c@ixit.cz>
From: David Heidelberg <david@ixit.cz>
As per the config name this Display IC features a DSI command-mode
interface (or the command to switch to video mode is not
known/documented) and does not use any of the video-mode helper
utilities, hence should not select VIDEOMODE_HELPERS. In addition it
uses devm_gpiod_get() and related functions from GPIOLIB.
Fixes: 88148c30ef26 ("drm/panel: Add Samsung S6E3FC2X01 DDIC with AMS641RW panel")
Signed-off-by: David Heidelberg <david@ixit.cz>
---
drivers/gpu/drm/panel/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 2fd3222ba2e3b..a81ea7755c03f 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -830,10 +830,9 @@ config DRM_PANEL_SAMSUNG_S6D7AA0
config DRM_PANEL_SAMSUNG_S6E3FC2X01
tristate "Samsung S6E3FC2X01 DSI panel controller"
- depends on OF
+ depends on OF && GPIOLIB
depends on DRM_MIPI_DSI
depends on BACKLIGHT_CLASS_DEVICE
- select VIDEOMODE_HELPERS
help
Say Y or M here if you want to enable support for the
Samsung S6E3FC2 DDIC and connected MIPI DSI panel.
--
2.51.0
next prev parent reply other threads:[~2026-02-26 11:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 11:57 [PATCH 0/4] drm/panel: Small Kconfig cleanup David Heidelberg via B4 Relay
2026-02-26 11:57 ` [PATCH 1/4] drm/panel: Clean up SOFEF00 config dependencies David Heidelberg via B4 Relay
2026-02-27 2:17 ` Claude review: " Claude Code Review Bot
2026-02-26 11:57 ` David Heidelberg via B4 Relay [this message]
2026-02-27 2:17 ` Claude review: drm/panel: Clean up S6E3FC2X01 " Claude Code Review Bot
2026-02-26 11:57 ` [PATCH 3/4] drm/panel: Clean up S6E3HA2 config dependencies and fill help text David Heidelberg via B4 Relay
2026-02-27 2:17 ` Claude review: " Claude Code Review Bot
2026-02-26 11:57 ` [PATCH 4/4] drm/panel: Enable GPIOLIB for panels which uses functions from it David Heidelberg via B4 Relay
2026-02-27 2:17 ` Claude review: " Claude Code Review Bot
2026-02-27 2:17 ` Claude review: drm/panel: Small Kconfig cleanup Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260226-panel-clean-up-kconfig-dep-v1-2-bb28a2355b4c@ixit.cz \
--to=devnull+david.ixit.cz@kernel.org \
--cc=airlied@gmail.com \
--cc=casey.connolly@linaro.org \
--cc=david@ixit.cz \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=dsankouski@gmail.com \
--cc=jesszhan0024@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marijn.suijten@somainline.org \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=phone-devel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox