[PATCH 0/4] drm/panel: Small Kconfig cleanup

[PATCH 0/4] drm/panel: Small Kconfig cleanup

[David Heidelberg via B4 Relay]

Inspired by looking at Marijn patch. Since Marijn patch is not merged yet,
appending patch to my series.

Signed-off-by: David Heidelberg <david@ixit.cz>
---
David Heidelberg (3):
      drm/panel: Clean up S6E3FC2X01 config dependencies
      drm/panel: Clean up S6E3HA2 config dependencies and fill help text
      drm/panel: Enable GPIOLIB for panels which uses functions from it

Marijn Suijten (1):
      drm/panel: Clean up SOFEF00 config dependencies

 drivers/gpu/drm/panel/Kconfig | 25 +++++++++++++++----------
 1 file changed, 15 insertions(+), 10 deletions(-)
---
base-commit: 877552aa875839314afad7154b5a561889e87ea9
change-id: 20260224-panel-clean-up-kconfig-dep-7dc39c351ef8

Best regards,
-- 
David Heidelberg <david@ixit.cz>

[PATCH 1/4] drm/panel: Clean up SOFEF00 config dependencies

[David Heidelberg via B4 Relay]

From: Marijn Suijten <marijn.suijten@somainline.org>

As per the config name this Display IC features a DSI command-mode
interface (or the command to switch to video mode is not
known/documented) and does not use any of the video-mode helper
utilities, hence should not select VIDEOMODE_HELPERS.  In addition it
uses devm_gpiod_get() and related functions from GPIOLIB.

Fixes: 5933baa36e26 ("drm/panel/samsung-sofef00: Add panel for OnePlus 6/T devices")
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Casey Connolly <casey.connolly@linaro.org>
Reviewed-by: David Heidelberg <david@ixit.cz>
Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
---
 drivers/gpu/drm/panel/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 79264f7bbd0e2..2fd3222ba2e3b 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -909,10 +909,10 @@ config DRM_PANEL_SAMSUNG_S6E8AA5X01_AMS561RA01
 
 config DRM_PANEL_SAMSUNG_SOFEF00
 	tristate "Samsung SOFEF00 DSI panel controller"
+	depends on GPIOLIB
 	depends on OF
 	depends on DRM_MIPI_DSI
 	depends on BACKLIGHT_CLASS_DEVICE
-	select VIDEOMODE_HELPERS
 	help
 	  Say Y or M here if you want to enable support for the Samsung AMOLED
 	  panel SOFEF00 DDIC and connected panel.

-- 
2.51.0

Claude review: drm/panel: Clean up SOFEF00 config dependencies

[Claude Code Review Bot]

Patch Review

**Author:** Marijn Suijten

This patch removes `select VIDEOMODE_HELPERS` and adds `depends on GPIOLIB` to `DRM_PANEL_SAMSUNG_SOFEF00`.

Verified in `panel-samsung-sofef00.c`:
- Uses `devm_gpiod_get()` and `gpiod_set_value_cansleep()` - GPIOLIB dependency is correct
- Does not include `<video/videomode.h>` or use any videomode helper functions - removing `select VIDEOMODE_HELPERS` is correct
- The driver defines `drm_display_mode` directly, not via `display_timing` conversion

The `depends on GPIOLIB` is placed before the existing `depends on OF` line, which is a reasonable ordering (alphabetical would put GPIOLIB first anyway since it comes after BACKLIGHT but before OF - though there's no strict convention here).

**Reviewed-by tags present from Neil Armstrong, Casey Connolly, and David Heidelberg.**

**No issues.** Looks good.

---

---
Generated by Claude Code Patch Reviewer

[PATCH 2/4] drm/panel: Clean up S6E3FC2X01 config dependencies

[David Heidelberg via B4 Relay]

From: David Heidelberg <david@ixit.cz>

As per the config name this Display IC features a DSI command-mode
interface (or the command to switch to video mode is not
known/documented) and does not use any of the video-mode helper
utilities, hence should not select VIDEOMODE_HELPERS.  In addition it
uses devm_gpiod_get() and related functions from GPIOLIB.

Fixes: 88148c30ef26 ("drm/panel: Add Samsung S6E3FC2X01 DDIC with AMS641RW panel")
Signed-off-by: David Heidelberg <david@ixit.cz>
---
 drivers/gpu/drm/panel/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 2fd3222ba2e3b..a81ea7755c03f 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -830,10 +830,9 @@ config DRM_PANEL_SAMSUNG_S6D7AA0
 
 config DRM_PANEL_SAMSUNG_S6E3FC2X01
 	tristate "Samsung S6E3FC2X01 DSI panel controller"
-	depends on OF
+	depends on OF && GPIOLIB
 	depends on DRM_MIPI_DSI
 	depends on BACKLIGHT_CLASS_DEVICE
-	select VIDEOMODE_HELPERS
 	help
 	  Say Y or M here if you want to enable support for the
 	  Samsung S6E3FC2 DDIC and connected MIPI DSI panel.

-- 
2.51.0

Claude review: drm/panel: Clean up S6E3FC2X01 config dependencies

[Claude Code Review Bot]

Patch Review

**Author:** David Heidelberg

Same pattern as patch 1: removes `select VIDEOMODE_HELPERS`, adds `depends on GPIOLIB` for `DRM_PANEL_SAMSUNG_S6E3FC2X01`.

Verified in `panel-samsung-s6e3fc2x01.c`:
- Uses `devm_gpiod_get()` and `gpiod_set_value_cansleep()` - correct
- No videomode helper usage - correct to remove

The diff changes `depends on OF` to `depends on OF && GPIOLIB`, consolidating onto one line. This is consistent with how patch 4 handles the same change for other drivers.

**No issues.** Looks good.

---

---
Generated by Claude Code Patch Reviewer

[PATCH 3/4] drm/panel: Clean up S6E3HA2 config dependencies and fill help text

[David Heidelberg via B4 Relay]

From: David Heidelberg <david@ixit.cz>

As per the config name this Display IC features a DSI command-mode
interface (or the command to switch to video mode is not
known/documented) and does not use any of the video-mode helper
utilities, hence should not select VIDEOMODE_HELPERS. In addition it
uses devm_gpiod_get() and related functions from GPIOLIB.

Fixes: 779679d3c164 ("drm/panel: Add support for S6E3HA8 panel driver")
Signed-off-by: David Heidelberg <david@ixit.cz>
---
 drivers/gpu/drm/panel/Kconfig | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index a81ea7755c03f..4e7b4808f6e7c 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -849,11 +849,17 @@ config DRM_PANEL_SAMSUNG_S6E3HA2
 
 config DRM_PANEL_SAMSUNG_S6E3HA8
 	tristate "Samsung S6E3HA8 DSI video mode panel"
-	depends on OF
+	depends on OF && GPIOLIB
 	depends on DRM_MIPI_DSI
 	depends on BACKLIGHT_CLASS_DEVICE
 	select DRM_DISPLAY_DSC_HELPER
-	select VIDEOMODE_HELPERS
+	help
+	  Say Y or M here if you want to enable support for the
+	  Samsung S6E3HA8 DDIC and connected MIPI DSI panel.
+	  Currently supported panels:
+
+	    Samsung AMB577PX01 (found in the Samsung S9 smartphone)
+
 
 config DRM_PANEL_SAMSUNG_S6E63J0X03
 	tristate "Samsung S6E63J0X03 DSI command mode panel"

-- 
2.51.0

Claude review: drm/panel: Clean up S6E3HA2 config dependencies and fill help text

[Claude Code Review Bot]

Patch Review

**Author:** David Heidelberg

**Subject line typo:** The subject says "S6E3HA**2**" but the patch modifies `DRM_PANEL_SAMSUNG_S6E3HA**8**`. The Fixes tag correctly references the S6E3HA8 commit (`779679d3c164`), and the added help text correctly says "Samsung S6E3HA8 DDIC". The subject should read "S6E3HA8".

**Misleading commit message:** The commit message says:

> As per the config name this Display IC features a DSI command-mode interface

But the Kconfig entry it modifies is:

```
tristate "Samsung S6E3HA8 DSI video mode panel"
```

And the driver sets video-mode flags:

```c
dsi->mode_flags = MIPI_DSI_CLOCK_NON_CONTINUOUS |
    MIPI_DSI_MODE_VIDEO_NO_HFP | MIPI_DSI_MODE_VIDEO_NO_HBP |
    MIPI_DSI_MODE_VIDEO_NO_HSA | MIPI_DSI_MODE_NO_EOT_PACKET;
```

The commit message appears to be copy-pasted from the SOFEF00 patch (patch 1) without being adapted. The justification for removing `select VIDEOMODE_HELPERS` still holds - the driver doesn't use `display_timing`/`videomode` structs regardless of whether it's video or command mode - but the commit message should be corrected to avoid confusion.

The help text addition is a nice improvement:

```
+	  Say Y or M here if you want to enable support for the
+	  Samsung S6E3HA8 DDIC and connected MIPI DSI panel.
+	  Currently supported panels:
+
+	    Samsung AMB577PX01 (found in the Samsung S9 smartphone)
```

The substantive changes (remove `select VIDEOMODE_HELPERS`, add `depends on GPIOLIB`) are correct.

**Minor nit:** There's a trailing blank line after the panel list in the help text (two blank lines before the next `config` entry). Not a functional issue but slightly inconsistent with typical Kconfig style.

**Requested: Fix subject line from "S6E3HA2" to "S6E3HA8", and update commit message to not claim command-mode for a video-mode panel.**

---

---
Generated by Claude Code Patch Reviewer

[PATCH 4/4] drm/panel: Enable GPIOLIB for panels which uses functions from it

[David Heidelberg via B4 Relay]

From: David Heidelberg <david@ixit.cz>

These panels used on sdm845 devices are using GPIOLIB functions,
ensure it's enabled.

Signed-off-by: David Heidelberg <david@ixit.cz>
---
 drivers/gpu/drm/panel/Kconfig | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 4e7b4808f6e7c..3e819b4b23962 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -107,7 +107,7 @@ config DRM_PANEL_BOE_TV101WUM_LL2
 
 config DRM_PANEL_EBBG_FT8719
 	tristate "EBBG FT8719 panel driver"
-	depends on OF
+	depends on OF && GPIOLIB
 	depends on DRM_MIPI_DSI
 	depends on BACKLIGHT_CLASS_DEVICE
 	help
@@ -432,7 +432,7 @@ config DRM_PANEL_LG_LG4573
 
 config DRM_PANEL_LG_SW43408
 	tristate "LG SW43408 panel"
-	depends on OF
+	depends on OF && GPIOLIB
 	depends on DRM_MIPI_DSI
 	depends on BACKLIGHT_CLASS_DEVICE
 	select DRM_DISPLAY_DSC_HELPER
@@ -536,7 +536,7 @@ config DRM_PANEL_NOVATEK_NT36523
 
 config DRM_PANEL_NOVATEK_NT36672A
 	tristate "Novatek NT36672A DSI panel"
-	depends on OF
+	depends on OF && GPIOLIB
 	depends on DRM_MIPI_DSI
 	depends on BACKLIGHT_CLASS_DEVICE
 	help
@@ -546,7 +546,7 @@ config DRM_PANEL_NOVATEK_NT36672A
 
 config DRM_PANEL_NOVATEK_NT36672E
 	tristate "Novatek NT36672E DSI panel"
-	depends on OF
+	depends on OF && GPIOLIB
 	depends on DRM_MIPI_DSI
 	depends on BACKLIGHT_CLASS_DEVICE
 	help
@@ -1182,7 +1182,7 @@ config DRM_PANEL_VISIONOX_R66451
 
 config DRM_PANEL_VISIONOX_RM69299
 	tristate "Visionox RM69299"
-	depends on OF
+	depends on OF && GPIOLIB
 	depends on DRM_MIPI_DSI
 	depends on BACKLIGHT_CLASS_DEVICE
 	help

-- 
2.51.0

Claude review: drm/panel: Enable GPIOLIB for panels which uses functions from it

[Claude Code Review Bot]

Patch Review

**Author:** David Heidelberg

Adds `depends on GPIOLIB` (via `depends on OF && GPIOLIB`) to five panel configs:
- `DRM_PANEL_EBBG_FT8719`
- `DRM_PANEL_LG_SW43408`
- `DRM_PANEL_NOVATEK_NT36672A`
- `DRM_PANEL_NOVATEK_NT36672E`
- `DRM_PANEL_VISIONOX_RM69299`

I verified all five driver source files use `devm_gpiod_get()` and `gpiod_set_value()` / `gpiod_set_value_cansleep()`. All five changes are correct.

**Minor grammar nit in subject:** "which uses" should be "which use" (plural).

**No functional issues.** Looks good.

---
Generated by Claude Code Patch Reviewer

Claude review: drm/panel: Small Kconfig cleanup

[Claude Code Review Bot]

Overall Series Review

Subject: drm/panel: Small Kconfig cleanup
Author: David Heidelberg via B4 Relay <devnull+david.ixit.cz@kernel.org>
Patches: 5
Reviewed: 2026-02-27T12:17:12.191285

---

This is a 4-patch Kconfig cleanup series for DRM panel drivers. The changes fall into two categories: (1) removing unnecessary `select VIDEOMODE_HELPERS` from three Samsung panel configs, and (2) adding missing `depends on GPIOLIB` to eight panel drivers that call `devm_gpiod_get()` and related functions.

All changes are correct in substance - I verified every panel driver source file and confirmed they all use GPIOLIB functions and none use videomode helper functions. The series is low-risk and improves Kconfig correctness.

There are two issues worth noting: a subject line typo in patch 3, and a misleading commit message in patch 3 that was copy-pasted from the SOFEF00 patch.

**Verdict: The series is correct and should be applied, with minor commit message fixes requested for patch 3.**

---

---
Generated by Claude Code Patch Reviewer