From: Randy Dunlap <rdunlap@infradead.org>
To: dri-devel@lists.freedesktop.org
Cc: Randy Dunlap <rdunlap@infradead.org>,
Rob Herring <robh@kernel.org>,
Tomeu Vizoso <tomeu@tomeuvizoso.net>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>
Subject: [PATCH] accel: Arm Ethos-U NPU: fix all uapi kernel-doc warnings
Date: Thu, 26 Feb 2026 13:58:23 -0800 [thread overview]
Message-ID: <20260226215823.989380-1-rdunlap@infradead.org> (raw)
Use correct struct names, struct member names, and kernel-doc
format to resolve all kernel-doc warnings:
Warning: include/uapi/drm/ethosu_accel.h:81 expecting prototype for struct
drm_ethosu_gpu_info. Prototype was for struct drm_ethosu_npu_info instead
Warning: include/uapi/drm/ethosu_accel.h:81 struct member 'config' not
described in 'drm_ethosu_npu_info'
Warning: include/uapi/drm/ethosu_accel.h:81 struct member 'sram_size' not
described in 'drm_ethosu_npu_info'
Warning: include/uapi/drm/ethosu_accel.h:172 expecting prototype for struct
drm_ethosu_wait_bo. Prototype was for struct drm_ethosu_bo_wait instead
Warning: include/uapi/drm/ethosu_accel.h:172 struct member 'handle' not
described in 'drm_ethosu_bo_wait'
Warning: include/uapi/drm/ethosu_accel.h:172 struct member 'pad' not
described in 'drm_ethosu_bo_wait'
Warning: include/uapi/drm/ethosu_accel.h:172 struct member 'timeout_ns' not
described in 'drm_ethosu_bo_wait'
Warning: include/uapi/drm/ethosu_accel.h:208 struct member 'cmd_bo' not
described in 'drm_ethosu_job'
Warning: include/uapi/drm/ethosu_accel.h:208 struct member 'sram_size' not
described in 'drm_ethosu_job'
Warning: include/uapi/drm/ethosu_accel.h:208 struct member
'region_bo_handles' not described in 'drm_ethosu_job'
Warning: include/uapi/drm/ethosu_accel.h:224 struct member 'jobs' not
described in 'drm_ethosu_submit'
Warning: include/uapi/drm/ethosu_accel.h:224 struct member 'job_count' not
described in 'drm_ethosu_submit'
Warning: include/uapi/drm/ethosu_accel.h:224 struct member 'pad' not
described in 'drm_ethosu_submit'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Rob Herring <robh@kernel.org>
Cc: Tomeu Vizoso <tomeu@tomeuvizoso.net>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Airlie <airlied@gmail.com>
Cc: Simona Vetter <simona@ffwll.ch>
include/uapi/drm/ethosu_accel.h | 24 ++++++++++++++----------
1 file changed, 14 insertions(+), 10 deletions(-)
--- linux-next-20260226.orig/include/uapi/drm/ethosu_accel.h
+++ linux-next-20260226/include/uapi/drm/ethosu_accel.h
@@ -60,7 +60,7 @@ enum drm_ethosu_dev_query_type {
};
/**
- * struct drm_ethosu_gpu_info - NPU information
+ * struct drm_ethosu_npu_info - NPU information
*
* Structure grouping all queryable information relating to the NPU.
*/
@@ -75,9 +75,10 @@ struct drm_ethosu_npu_info {
#define DRM_ETHOSU_VERSION_MINOR(x) (((x) >> 4) & 0xff)
#define DRM_ETHOSU_VERSION_STATUS(x) ((x) & 0xf)
- /** @gpu_rev: GPU revision. */
+ /** @config: NPU revision. */
__u32 config;
+ /** @sram_size: NPU SRAM size (KB) */
__u32 sram_size;
};
@@ -159,7 +160,7 @@ struct drm_ethosu_bo_mmap_offset {
};
/**
- * struct drm_ethosu_wait_bo - ioctl argument for waiting for
+ * struct drm_ethosu_bo_wait - ioctl argument for waiting for
* completion of the last DRM_ETHOSU_SUBMIT on a BO.
*
* This is useful for cases where multiple processes might be
@@ -167,9 +168,12 @@ struct drm_ethosu_bo_mmap_offset {
* completed.
*/
struct drm_ethosu_bo_wait {
+ /** @handle: BO handle */
__u32 handle;
+ /** @pad: Reserved, must be zero. */
__u32 pad;
- __s64 timeout_ns; /* absolute */
+ /** @timeout_ns: Absolute timeout in ns. */
+ __s64 timeout_ns;
};
struct drm_ethosu_cmdstream_bo_create {
@@ -197,14 +201,14 @@ struct drm_ethosu_cmdstream_bo_create {
* sequentially on the same core, to benefit from memory residency in SRAM.
*/
struct drm_ethosu_job {
- /** Input: BO handle for cmdstream. */
+ /** @cmd_bo: Input: BO handle for cmdstream. */
__u32 cmd_bo;
- /** Input: Amount of SRAM to use. */
+ /** @sram_size: Input: Amount of SRAM to use. */
__u32 sram_size;
#define ETHOSU_MAX_REGIONS 8
- /** Input: Array of BO handles for each region. */
+ /** @region_bo_handles: Input: Array of BO handles for each region. */
__u32 region_bo_handles[ETHOSU_MAX_REGIONS];
};
@@ -214,13 +218,13 @@ struct drm_ethosu_job {
* The kernel will schedule the execution of these jobs in dependency order.
*/
struct drm_ethosu_submit {
- /** Input: Pointer to an array of struct drm_ethosu_job. */
+ /** @jobs: Input: Pointer to an array of struct drm_ethosu_job. */
__u64 jobs;
- /** Input: Number of jobs passed in. */
+ /** @job_count: Input: Number of jobs passed in. */
__u32 job_count;
- /** Reserved, must be zero. */
+ /** @pad: Reserved, must be zero. */
__u32 pad;
};
next reply other threads:[~2026-02-26 21:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 21:58 Randy Dunlap [this message]
2026-02-27 1:37 ` Claude review: accel: Arm Ethos-U NPU: fix all uapi kernel-doc warnings Claude Code Review Bot
2026-02-27 1:37 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260226215823.989380-1-rdunlap@infradead.org \
--to=rdunlap@infradead.org \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tomeu@tomeuvizoso.net \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox