From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF5F0FEE4ED for ; Sat, 28 Feb 2026 11:28:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D540110E0A6; Sat, 28 Feb 2026 11:28:30 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="T6op2CQ3"; dkim-atps=neutral Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8325C10E0A6 for ; Sat, 28 Feb 2026 11:28:29 +0000 (UTC) Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-483770e0b25so25458545e9.0 for ; Sat, 28 Feb 2026 03:28:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772278108; x=1772882908; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=lPMQsCRzdgUsnGe3LplGdHC9I0aaGaZ1j+ZQBXbed9c=; b=T6op2CQ3sPBSAy9pPMFT4EKRWcRBoamA7rwNnUEz2JPwK1H/2tX93LHIYaNpnbFuXl u4q/5p1SnjL2juHVLlu39qSAUybDDCg8MpYT56k/gUvBv4SW6QZ/4/JKlRo36qeU37vi FxxQbpp4opcn4nJYiGqMAKi08/eTVrrZPGO4V89VHgFXJQ4Ye3eU1SoHINpxJGw8iHUM jpF0bV0q6Vtvs0PHeUiGGIqY6z9m+iFpRCJ3qVNCipIc3AsFXmMi6YApQx1JSaXt1L/q EaxEk2b2mIOxADAKtbsyNM3D69ntFcVPVVPg7DFlItK2nA8UmhF0pxZP8ycInhRpo5u6 H/RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772278108; x=1772882908; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lPMQsCRzdgUsnGe3LplGdHC9I0aaGaZ1j+ZQBXbed9c=; b=qWRIkPi3G+xjTIHXWsJ3fvVel1mQYiI7kld0Osm3ZfYrDXrchNiRnd52QKyipp0rLN 44skPYS9r2jy26x+08A38f3RjSfX+/U69OAjJfUwYlHYU3VxGOkZoJWhT5lKX8evvoN8 XOgqsNWXedAO9yZB6Ey7hxfoT4JXWVOKJNnQs7H/f5EcCELjjCe2PIKHwpjtjVu8vAyn 5srLsZL41P5ak9UkGEIWCzAwzZs2RNBNM60DKVPmtBrBTTPZYqqKcQ66/mQn1TOwa7CO hG0BaUPdGvy5oEZlsBSJdPastsTA53o5CWuqhjg/89R6VX3u4lx3NNpmlVQLzaDeHsdM T4ZQ== X-Forwarded-Encrypted: i=1; AJvYcCV/Xg5Q5+uhq1Jly3WdxR8SDK2YA9XcWADsizLpp2mviMJtlsp28grszmj4kGUI9XULwsfPdoS1se8=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yx2bauzSTALb5gtK0zKW13J4cj8pr8UD8sUggev/TND8lnYpQu4 Q2S72Ov611owEVPNIyS5ASzpIqB9nMe79iFX8LYPztrx6Y1oXC9S/CIM X-Gm-Gg: ATEYQzyNTBXnaF+nny/yQbTSZSYmsG8jsHi3+ZfezefJfsojKKZNirMQ1GjVaC3dyAL HQ1nhwr7/fvQX7h4QhUjXKOWubk6UywACN/Jd5e8x3Iyhb7pQgnwxwLD57lQFXLI5FQC9L0dsZ5 fa5LJ2nzd3X5jNq7tOKNvM6BI5C1fQhCKU9Z2WnkUyE/4bWnV92Ph0JZyNp2koqI542BH2IvJo4 Efh3ZuD8xjGrzOdqWNYia7aP7tZXwR97D07pfE6sxuIHXsqcxqCo4h8+/PGks6HifewcMRQPi5k w63omKx5Odgr+L6O4iuhoQypzBBWExb7/3WqpifJIa14TMQzzf9nPk0AJnUkC96KoWGZmBIgjWx YBtrnKr/AvcGydGVyPUOKGBEr4ldqFXIFBEuROsnssTAtXHRNwtEWWEGa1JooiAxi+gbhsTDRfR v2uoJUvkxTYnrqqHtZ1xF+BUm6Urc= X-Received: by 2002:a05:600c:5308:b0:483:c490:8c0 with SMTP id 5b1f17b1804b1-483c9bdb6d6mr93362665e9.11.1772278107808; Sat, 28 Feb 2026 03:28:27 -0800 (PST) Received: from toolbox.. ([87.200.95.144]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bd702e7bsm310980275e9.5.2026.02.28.03.28.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Feb 2026 03:28:27 -0800 (PST) From: Christian Hewitt To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dmitry Baryshkov , Cristian Ciocaltea , Detlev Casanova , Douglas Anderson , Andy Yan , Sugar Zhang , Luca Ceresoli , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] drm/bridge: dw-hdmi-qp: fix multi-channel audio output Date: Sat, 28 Feb 2026 11:28:22 +0000 Message-ID: <20260228112822.4056354-1-christianshewitt@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Jonas Karlman Channel Allocation (PB4) and Level Shift Information (PB5) are configured with values from PB1 and PB2 due to the wrong offset being used. This results in missing audio channels or incorrect speaker placement when playing multi-channel audio. Use the correct offset to fix multi-channel audio output. Fixes: fd0141d1a8a2 ("drm/bridge: synopsys: Add audio support for dw-hdmi-qp") Reported-by: Christian Hewitt Signed-off-by: Jonas Karlman Signed-off-by: Christian Hewitt Reviewed-by: Cristian Ciocaltea --- Changes in v2: - Add my SoB as requested in v1 [0] - Add Cristians review [0] https://patchwork.kernel.org/project/dri-devel/patch/20251206072718.2039874-1-christianshewitt@gmail.com/ drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c index ab7fed6214e0..facfb7526928 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c @@ -848,7 +848,7 @@ static int dw_hdmi_qp_config_audio_infoframe(struct dw_hdmi_qp *hdmi, regmap_bulk_write(hdmi->regm, PKT_AUDI_CONTENTS0, &header_bytes, 1); regmap_bulk_write(hdmi->regm, PKT_AUDI_CONTENTS1, &buffer[3], 1); - regmap_bulk_write(hdmi->regm, PKT_AUDI_CONTENTS2, &buffer[4], 1); + regmap_bulk_write(hdmi->regm, PKT_AUDI_CONTENTS2, &buffer[7], 1); /* Enable ACR, AUDI, AMD */ dw_hdmi_qp_mod(hdmi, -- 2.43.0