From: Alok Tiwari <alok.a.tiwari@oracle.com>
To: jacek.lawrynowicz@linux.intel.com, andersson@kernel.org,
quic_pkanojiy@quicinc.com, ogabbay@kernel.org,
jeff.hugo@oss.qualcomm.com, carl.vanderlip@oss.qualcomm.com,
dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org
Cc: alok.a.tiwarilinux@gmail.com, alok.a.tiwari@oracle.com
Subject: [PATCH] accel/qaic Fix HELLO_RESP mode sourced from wrong rx field
Date: Sun, 1 Mar 2026 01:12:11 -0800 [thread overview]
Message-ID: <20260301091214.171263-1-alok.a.tiwari@oracle.com> (raw)
sahara_hello() handles SAHARA_HELLO_CMD and validates fields from
context->rx->hello. When building the HELLO_RESP, copy the mode from the
received HELLO request (rx->hello.mode) rather than rx->hello_resp.mode.
Fixes: 76b801aa2198 ("accel/qaic: Add Sahara implementation for firmware loading")
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
---
drivers/accel/qaic/sahara.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/accel/qaic/sahara.c b/drivers/accel/qaic/sahara.c
index fd3c3b2d1fd3..99bf832e2825 100644
--- a/drivers/accel/qaic/sahara.c
+++ b/drivers/accel/qaic/sahara.c
@@ -325,7 +325,7 @@ static void sahara_hello(struct sahara_context *context)
context->tx[0]->hello_resp.version = cpu_to_le32(SAHARA_VERSION);
context->tx[0]->hello_resp.version_compat = cpu_to_le32(SAHARA_VERSION);
context->tx[0]->hello_resp.status = cpu_to_le32(SAHARA_SUCCESS);
- context->tx[0]->hello_resp.mode = context->rx->hello_resp.mode;
+ context->tx[0]->hello_resp.mode = context->rx->hello.mode;
ret = mhi_queue_buf(context->mhi_dev, DMA_TO_DEVICE, context->tx[0],
SAHARA_HELLO_LENGTH, MHI_EOT);
--
2.50.1
next reply other threads:[~2026-03-01 9:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-01 9:12 Alok Tiwari [this message]
2026-03-03 3:59 ` Claude review: accel/qaic Fix HELLO_RESP mode sourced from wrong rx field Claude Code Review Bot
2026-03-03 3:59 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260301091214.171263-1-alok.a.tiwari@oracle.com \
--to=alok.a.tiwari@oracle.com \
--cc=alok.a.tiwarilinux@gmail.com \
--cc=andersson@kernel.org \
--cc=carl.vanderlip@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.lawrynowicz@linux.intel.com \
--cc=jeff.hugo@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=ogabbay@kernel.org \
--cc=quic_pkanojiy@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox