From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6F81EDEBF7 for ; Tue, 3 Mar 2026 21:15:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0F9A510E8D3; Tue, 3 Mar 2026 21:15:41 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="OCESQA4c"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1640F10E8D3 for ; Tue, 3 Mar 2026 21:15:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772572538; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=irBf4YUdN1+vibh8PKUSXKnT1yGXKOqgKyvxp0mJGPY=; b=OCESQA4clh8Axb1EjczquFMRnGOxVQ0eJn0FXweTVNSIxFkuzc2tNJ9bFvcsjNAOLNxk9z Tzwha96xnUDt8Puun9MztQK61kbNN+O9W/1yep/mDbg01mbH1wtQMk3u13R44FXdv7jg+o TRHQ8bldEBnrh6Kg+VGFCL1XExIfl38= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-nN0wyHOyPDOdTfCNFFgDhA-1; Tue, 03 Mar 2026 16:15:37 -0500 X-MC-Unique: nN0wyHOyPDOdTfCNFFgDhA-1 X-Mimecast-MFC-AGG-ID: nN0wyHOyPDOdTfCNFFgDhA_1772572537 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-506ab115571so476613961cf.0 for ; Tue, 03 Mar 2026 13:15:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772572537; x=1773177337; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=irBf4YUdN1+vibh8PKUSXKnT1yGXKOqgKyvxp0mJGPY=; b=KXvtDG3pOoanMRTETmBwa0leaIT1IdF3KJJbjz57+XFfdC8noe64bSyojiDvODVHP9 I9UFjnFNzc1+gwiTl4wyLmi6adV0OsNKSRuWH0E9v70TXS6M+PHFSPTugrhmm4JRpovc hwVlsRhAoGg+EJbv0SyFHkynr8bw+xR7nTL5UIvMMxfPCz68EqpIJhldmYf9UjezxMx0 5HXXRvo4vVft04FtvjQabUKo+zQn2IW0XMTWExY/JWmtLFkjmDU6348/oO8u062iJfAg GbnyvYmjDamUTgnRQFkJVXPrMLAS1zFqHwbHA0w8N6GK/xX9wF0IFnmzYlhSRtOhOk0b Ytgw== X-Forwarded-Encrypted: i=1; AJvYcCWmtND8O1v+Qssd94zdl5zDXD6adtKiIKe6v/7zVH44UwGRe8+5nGb0D+eGNOgLhgOP1ikuee4k5GU=@lists.freedesktop.org X-Gm-Message-State: AOJu0YwgnvJNGE9gVWIJKQhgmokjENLRYcFaTLxUjZCjCb8JUrhP1XXx EZhHAGu4qBrhLWpq14Sg6YpBZ0vSOJ8coP8BWglDSyNwNFCulPPdBPc5ddUDmjIUayFvSbMnBpb lSXUnxWfea6W1KU4hSTqwfTGZ7D82VY1aH4d3+udJ9kjbBzLj/XQI/gZes991GjjyFMsLEPkP9x faOMLBcBExm5uNhMIGfH5wff5UP49H2MkxzCdEhVwR10A20CwH1iA6lnXa X-Gm-Gg: ATEYQzz+EDUrfl/Xr5OhEmp4hIt5yukFUUQymSnQxJgbH6vT6lDQ02oF/k8YcslKbEz VtUpjOISbQZe8IitHY3TbosnToduukLttWUZ8IXxrvcnyB2P638MetuFvpwmhIWtbd+aa5RtjBa mr6vfHgCqFn6PUd69ciKprzMBXauTEwcqilFhqMDCuF9sv3K1ecUTRhYz1k1BFl0E9ieqG3BxYr kXCQtwjHXypf58w8efs5KV3iBuPWNIAw3ZseFmQms8AT77ebWuMxZ3+/O3f2GDM9wk9l7Lvmf/D nTZ7UrxUiNXy/Reip5F6tkPKCtl1ILrA9epVWWDp6/Qoupi2nYnZKZrKb+n3PHAQ5sfNSUZNWs1 bn2naePOxSQlA4kgFzZUN8ONL7w== X-Received: by 2002:a05:622a:1891:b0:502:9abb:c919 with SMTP id d75a77b69052e-5075287910dmr225478431cf.10.1772572536611; Tue, 03 Mar 2026 13:15:36 -0800 (PST) X-Received: by 2002:a05:622a:1891:b0:502:9abb:c919 with SMTP id d75a77b69052e-5075287910dmr225477351cf.10.1772572535732; Tue, 03 Mar 2026 13:15:35 -0800 (PST) Received: from [172.16.1.8] ([2607:f2c0:b1e3:9a00:3c7:56c2:f819:96d2]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5074481c0e5sm156286991cf.0.2026.03.03.13.15.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 13:15:35 -0800 (PST) From: Peter Colberg Date: Tue, 03 Mar 2026 16:15:22 -0500 Subject: [PATCH v3 02/10] fpga: dfl-pci: set driver flag to disable SR-IOV on remove() MIME-Version: 1.0 Message-Id: <20260303-rust-pci-sriov-v3-2-4443c35f0c88@redhat.com> References: <20260303-rust-pci-sriov-v3-0-4443c35f0c88@redhat.com> In-Reply-To: <20260303-rust-pci-sriov-v3-0-4443c35f0c88@redhat.com> To: Danilo Krummrich , Bjorn Helgaas , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Miguel Ojeda , Alex Gaynor , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Abdiel Janulgue , Daniel Almeida , Robin Murphy , Greg Kroah-Hartman , Dave Ertman , Ira Weiny , Leon Romanovsky , David Airlie , Simona Vetter , Jonathan Corbet , Xu Yilun , Tom Rix , Moritz Fischer , "Rafael J. Wysocki" , Boqun Feng Cc: linux-pci@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandre Courbot , Alistair Popple , Joel Fernandes , John Hubbard , Zhi Wang , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-fpga@vger.kernel.org, driver-core@lists.linux.dev, Peter Colberg , Jason Gunthorpe X-Mailer: b4 0.14.2 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pRRXFjbneXZP_W3a3O3Jw8lneKolJlgwVXpQVwgJtpc_1772572537 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Set the flag managed_sriov in the pci_driver structure to show how a PCI driver may opt into disabling the Single Root I/O Virtualization (SR-IOV) capability of the device when the driver is removed. Merge the function cci_remove_feature_devs() into cci_pci_remove(). Signed-off-by: Peter Colberg --- Changes in v2: - Demonstrate flag managed_sriov for dfl-pci driver. --- drivers/fpga/dfl-pci.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c index e25205c6d8f00cec579016acade28e743812c924..2410e6f3efe100a635eebfdb21f28f62a3759890 100644 --- a/drivers/fpga/dfl-pci.c +++ b/drivers/fpga/dfl-pci.c @@ -125,15 +125,6 @@ static int cci_init_drvdata(struct pci_dev *pcidev) return 0; } -static void cci_remove_feature_devs(struct pci_dev *pcidev) -{ - struct cci_drvdata *drvdata = pci_get_drvdata(pcidev); - - /* remove all children feature devices */ - dfl_fpga_feature_devs_remove(drvdata->cdev); - cci_pci_free_irq(pcidev); -} - static int *cci_pci_create_irq_table(struct pci_dev *pcidev, unsigned int nvec) { unsigned int i; @@ -425,10 +416,11 @@ static int cci_pci_sriov_configure(struct pci_dev *pcidev, int num_vfs) static void cci_pci_remove(struct pci_dev *pcidev) { - if (dev_is_pf(&pcidev->dev)) - cci_pci_sriov_configure(pcidev, 0); + struct cci_drvdata *drvdata = pci_get_drvdata(pcidev); - cci_remove_feature_devs(pcidev); + /* remove all children feature devices */ + dfl_fpga_feature_devs_remove(drvdata->cdev); + cci_pci_free_irq(pcidev); } static struct pci_driver cci_pci_driver = { @@ -437,6 +429,7 @@ static struct pci_driver cci_pci_driver = { .probe = cci_pci_probe, .remove = cci_pci_remove, .sriov_configure = cci_pci_sriov_configure, + .managed_sriov = true, }; module_pci_driver(cci_pci_driver); -- 2.53.0