From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B720CE67A68 for ; Tue, 3 Mar 2026 05:20:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D554510E637; Tue, 3 Mar 2026 05:20:04 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Vz3K5me3"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id 02CE710E0DA; Tue, 3 Mar 2026 05:20:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1772515202; x=1804051202; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=IOayjJtDTZfdMge/Pz0t18B/ED4I6iuq6j8Enn7Aolk=; b=Vz3K5me3wBZKblIbai+cXBjUPSldWI8kwWQmkOArSt3Em4qy19uvWEaL bAiFb8EL4NvWZ63FivrAw4jFBh46jGfV296+LiRGsEl5DVUplEFfTAH52 dzekZEIfRE5kej/8u9xu5n3kW1O3/KDIHy3Qr7NCWHim2nSjQbMp9CLC0 K8rjESQ7qjogGOHmPr3xaPX0r3wp3Am1AUb+hNOgYcRcYprp8kWt+Yz/7 sVfWrInF2tryKQJDvbD5gfZaqQaaaiNVtm7I2dWnbOimtvejJ+/uuo380 UP0/VH2g5nb9IJtMcITQul/oFzZoq6ADabcn9nYpxDYud2N/MbLYcz/4q g==; X-CSE-ConnectionGUID: U1iP33s2RRimwzq18Y+jSg== X-CSE-MsgGUID: C/Q4cJ4uRNSntFm/TxG57Q== X-IronPort-AV: E=McAfee;i="6800,10657,11717"; a="73445427" X-IronPort-AV: E=Sophos;i="6.21,321,1763452800"; d="scan'208";a="73445427" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2026 21:20:01 -0800 X-CSE-ConnectionGUID: UjTuAvspSjq1BXUSTS30KQ== X-CSE-MsgGUID: pro2r6E4Se63EWLhoU3WjA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,321,1763452800"; d="scan'208";a="217110179" Received: from debox1-desk4.jf.intel.com ([10.88.27.138]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2026 21:20:01 -0800 From: "David E. Box" To: thomas.hellstrom@linux.intel.com, rodrigo.vivi@intel.com, irenic.rajneesh@gmail.com, ilpo.jarvinen@linux.intel.com, srinivas.pandruvada@linux.intel.com, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, xi.pardee@linux.intel.com Cc: david.e.box@linux.intel.com, hansg@kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: [PATCH v7 5/6] platform/x86/intel/vsec: Return real error codes from registration path Date: Mon, 2 Mar 2026 21:19:52 -0800 Message-ID: <20260303051953.1453372-6-david.e.box@linux.intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260303051953.1453372-1-david.e.box@linux.intel.com> References: <20260303051953.1453372-1-david.e.box@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Stop collapsing registration results into booleans. Make intel_vsec_walk_header() return int and propagate the first non-zero error from intel_vsec_register_device(). intel_vsec_register() now returns that error directly and 0 on success. This preserves success behavior while surfacing meaningful errors instead of hiding them behind a bool/-ENODEV, which makes debugging and probe ordering issues clearer. Reviewed-by: Ilpo J=C3=A4rvinen Signed-off-by: David E. Box --- Changes in v7: - No change =20=20=20=20 Changes in v6: - No change =20=20=20=20 Changes in v5: - No change =20=20=20=20 Changes in v4: - No change =20=20 Changes in v3: - No change =20=20=20 Changes in v2: - No change (previous patch 3) drivers/platform/x86/intel/vsec.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/platform/x86/intel/vsec.c b/drivers/platform/x86/intel= /vsec.c index a547e4b98245..34b2c19ecff0 100644 --- a/drivers/platform/x86/intel/vsec.c +++ b/drivers/platform/x86/intel/vsec.c @@ -461,20 +461,19 @@ static int intel_vsec_register_device(struct device *= dev, return -EAGAIN; } =20 -static bool intel_vsec_walk_header(struct device *dev, - const struct intel_vsec_platform_info *info) +static int intel_vsec_walk_header(struct device *dev, + const struct intel_vsec_platform_info *info) { struct intel_vsec_header **header =3D info->headers; - bool have_devices =3D false; int ret; =20 for ( ; *header; header++) { ret =3D intel_vsec_register_device(dev, *header, info, info->base_addr); - if (!ret) - have_devices =3D true; + if (ret) + return ret; } =20 - return have_devices; + return 0; } =20 static bool intel_vsec_walk_dvsec(struct pci_dev *pdev, @@ -580,10 +579,7 @@ int intel_vsec_register(struct device *dev, if (!dev || !info || !info->headers) return -EINVAL; =20 - if (!intel_vsec_walk_header(dev, info)) - return -ENODEV; - else - return 0; + return intel_vsec_walk_header(dev, info); } EXPORT_SYMBOL_NS_GPL(intel_vsec_register, "INTEL_VSEC"); =20 --=20 2.43.0