* [PATCH v4 0/3] drm: bridge: add support for Triple 10-BIT
@ 2026-03-03 8:20 Svyatoslav Ryhel
2026-03-03 8:20 ` [PATCH v4 1/3] dt-bindigs: display: extend the LVDS codec with Triple 10-BIT LVDS Transmitter Svyatoslav Ryhel
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Svyatoslav Ryhel @ 2026-03-03 8:20 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
David Airlie, Simona Vetter, Svyatoslav Ryhel
Cc: dri-devel, devicetree, linux-kernel
Triple 10-BIT LVDS Transmitter is used in Microsoft Surface RT and
MStar TSUMU88ADT3-LF-1 HDMI bridge is used in ASUS Transformer AiO
P1801-T.
Link to v3: https://lore.kernel.org/lkml/20250824092728.105643-1-clamor95@gmail.com/
---
Changes on switching from v3 to v4:
- rebased on top of v7.0
Changes on switching from v2 to v3:
- place mstar,tsumu88adt3-lf-1 alphabetically
- fix typos
Changes on switching from v1 to v2:
- sort compatible alphabetically in schema
---
David Heidelberg (1):
dt-bindigs: display: extend the LVDS codec with Triple 10-BIT LVDS
Transmitter
Maxim Schwalm (1):
drm/bridge: simple-bridge: Add support for MStar TSUMU88ADT3-LF-1
Svyatoslav Ryhel (1):
dt-bindigs: display: extend the simple bridge with MStar
TSUMU88ADT3-LF-1 bridge
.../devicetree/bindings/display/bridge/lvds-codec.yaml | 1 +
.../devicetree/bindings/display/bridge/simple-bridge.yaml | 1 +
drivers/gpu/drm/bridge/simple-bridge.c | 5 +++++
3 files changed, 7 insertions(+)
--
2.51.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v4 1/3] dt-bindigs: display: extend the LVDS codec with Triple 10-BIT LVDS Transmitter
2026-03-03 8:20 [PATCH v4 0/3] drm: bridge: add support for Triple 10-BIT Svyatoslav Ryhel
@ 2026-03-03 8:20 ` Svyatoslav Ryhel
2026-03-03 21:49 ` Claude review: " Claude Code Review Bot
2026-03-03 8:20 ` [PATCH v4 2/3] dt-bindigs: display: extend the simple bridge with MStar TSUMU88ADT3-LF-1 bridge Svyatoslav Ryhel
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Svyatoslav Ryhel @ 2026-03-03 8:20 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
David Airlie, Simona Vetter, Svyatoslav Ryhel
Cc: dri-devel, devicetree, linux-kernel
From: David Heidelberg <david@ixit.cz>
LVDS transmitter used in the Microsoft Surface RT.
Signed-off-by: David Heidelberg <david@ixit.cz>
Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
Reviewed-by: Robert Foss <rfoss@kernel.org>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
---
Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
index 4f52e35d0253..90ddedbba738 100644
--- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
@@ -33,6 +33,7 @@ properties:
oneOf:
- items:
- enum:
+ - idt,v103 # For the Triple 10-BIT LVDS Transmitter
- onnn,fin3385 # OnSemi FIN3385
- ti,ds90c185 # For the TI DS90C185 FPD-Link Serializer
- ti,ds90c187 # For the TI DS90C187 FPD-Link Serializer
--
2.51.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v4 2/3] dt-bindigs: display: extend the simple bridge with MStar TSUMU88ADT3-LF-1 bridge
2026-03-03 8:20 [PATCH v4 0/3] drm: bridge: add support for Triple 10-BIT Svyatoslav Ryhel
2026-03-03 8:20 ` [PATCH v4 1/3] dt-bindigs: display: extend the LVDS codec with Triple 10-BIT LVDS Transmitter Svyatoslav Ryhel
@ 2026-03-03 8:20 ` Svyatoslav Ryhel
2026-03-03 21:49 ` Claude review: " Claude Code Review Bot
2026-03-03 8:20 ` [PATCH v4 3/3] drm/bridge: simple-bridge: Add support for MStar TSUMU88ADT3-LF-1 Svyatoslav Ryhel
2026-03-03 21:49 ` Claude review: drm: bridge: add support for Triple 10-BIT Claude Code Review Bot
3 siblings, 1 reply; 8+ messages in thread
From: Svyatoslav Ryhel @ 2026-03-03 8:20 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
David Airlie, Simona Vetter, Svyatoslav Ryhel
Cc: dri-devel, devicetree, linux-kernel
A simple bridge used in ASUS Transformer AiO P1801-T.
Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
Reviewed-by: Robert Foss <rfoss@kernel.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
---
.../devicetree/bindings/display/bridge/simple-bridge.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml b/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml
index e6808419f625..7636c24906ba 100644
--- a/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml
@@ -30,6 +30,7 @@ properties:
- algoltek,ag6311
- asl-tek,cs5263
- dumb-vga-dac
+ - mstar,tsumu88adt3-lf-1
- parade,ps185hdm
- radxa,ra620
- realtek,rtd2171
--
2.51.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v4 3/3] drm/bridge: simple-bridge: Add support for MStar TSUMU88ADT3-LF-1
2026-03-03 8:20 [PATCH v4 0/3] drm: bridge: add support for Triple 10-BIT Svyatoslav Ryhel
2026-03-03 8:20 ` [PATCH v4 1/3] dt-bindigs: display: extend the LVDS codec with Triple 10-BIT LVDS Transmitter Svyatoslav Ryhel
2026-03-03 8:20 ` [PATCH v4 2/3] dt-bindigs: display: extend the simple bridge with MStar TSUMU88ADT3-LF-1 bridge Svyatoslav Ryhel
@ 2026-03-03 8:20 ` Svyatoslav Ryhel
2026-03-03 21:49 ` Claude review: " Claude Code Review Bot
2026-03-03 21:49 ` Claude review: drm: bridge: add support for Triple 10-BIT Claude Code Review Bot
3 siblings, 1 reply; 8+ messages in thread
From: Svyatoslav Ryhel @ 2026-03-03 8:20 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
David Airlie, Simona Vetter, Svyatoslav Ryhel
Cc: dri-devel, devicetree, linux-kernel
From: Maxim Schwalm <maxim.schwalm@gmail.com>
A simple HDMI bridge used in ASUS Transformer AiO P1801-T.
Signed-off-by: Maxim Schwalm <maxim.schwalm@gmail.com>
Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
Reviewed-by: Robert Foss <rfoss@kernel.org>
---
drivers/gpu/drm/bridge/simple-bridge.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/bridge/simple-bridge.c b/drivers/gpu/drm/bridge/simple-bridge.c
index 8aa31ca3c72d..cc13c98f9be6 100644
--- a/drivers/gpu/drm/bridge/simple-bridge.c
+++ b/drivers/gpu/drm/bridge/simple-bridge.c
@@ -270,6 +270,11 @@ static const struct of_device_id simple_bridge_match[] = {
.data = &(const struct simple_bridge_info) {
.connector_type = DRM_MODE_CONNECTOR_HDMIA,
},
+ }, {
+ .compatible = "mstar,tsumu88adt3-lf-1",
+ .data = &(const struct simple_bridge_info) {
+ .connector_type = DRM_MODE_CONNECTOR_HDMIA,
+ },
}, {
.compatible = "parade,ps185hdm",
.data = &(const struct simple_bridge_info) {
--
2.51.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Claude review: drm: bridge: add support for Triple 10-BIT
2026-03-03 8:20 [PATCH v4 0/3] drm: bridge: add support for Triple 10-BIT Svyatoslav Ryhel
` (2 preceding siblings ...)
2026-03-03 8:20 ` [PATCH v4 3/3] drm/bridge: simple-bridge: Add support for MStar TSUMU88ADT3-LF-1 Svyatoslav Ryhel
@ 2026-03-03 21:49 ` Claude Code Review Bot
3 siblings, 0 replies; 8+ messages in thread
From: Claude Code Review Bot @ 2026-03-03 21:49 UTC (permalink / raw)
To: dri-devel-reviews
Overall Series Review
Subject: drm: bridge: add support for Triple 10-BIT
Author: Svyatoslav Ryhel <clamor95@gmail.com>
Patches: 4
Reviewed: 2026-03-04T07:49:52.137530
---
This is a straightforward 3-patch series adding device-tree bindings and driver support for two simple, non-programmable display bridges: the IDT V103 Triple 10-BIT LVDS Transmitter (used in Microsoft Surface RT) and the MStar TSUMU88ADT3-LF-1 HDMI bridge (used in ASUS Transformer AiO P1801-T).
The patches are minimal and clean. Alphabetical ordering is correctly maintained in all three files. The series already carries Reviewed-by tags from Robert Foss on all patches, plus Acked-by from Rob Herring (patch 1) and Conor Dooley (patch 2). This is v4, with the only change from v3 being a rebase onto v7.0.
**One recurring nit:** The subject prefix in patches 1 and 2 reads "dt-bindigs" instead of "dt-bindings". This typo has persisted across all four versions of the series.
No functional issues found. The series is ready to apply.
---
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 8+ messages in thread
* Claude review: dt-bindigs: display: extend the LVDS codec with Triple 10-BIT LVDS Transmitter
2026-03-03 8:20 ` [PATCH v4 1/3] dt-bindigs: display: extend the LVDS codec with Triple 10-BIT LVDS Transmitter Svyatoslav Ryhel
@ 2026-03-03 21:49 ` Claude Code Review Bot
0 siblings, 0 replies; 8+ messages in thread
From: Claude Code Review Bot @ 2026-03-03 21:49 UTC (permalink / raw)
To: dri-devel-reviews
Patch Review
**Author:** David Heidelberg / Svyatoslav Ryhel
Adds `idt,v103` to the lvds-codec.yaml compatible enum as an LVDS encoder with the `lvds-encoder` fallback compatible.
```yaml
+ - idt,v103 # For the Triple 10-BIT LVDS Transmitter
```
- **Alphabetical ordering:** Correct. `idt,v103` sorts before `onnn,fin3385`.
- **Placement:** Correctly placed in the first `oneOf` block (LVDS encoders with `lvds-encoder` fallback), which is appropriate for a transmitter.
- **Comment style:** Follows the existing pattern of inline comments (`# For the ...`).
**Nit:** Subject says "dt-bindigs" — should be "dt-bindings".
No other issues.
---
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 8+ messages in thread
* Claude review: dt-bindigs: display: extend the simple bridge with MStar TSUMU88ADT3-LF-1 bridge
2026-03-03 8:20 ` [PATCH v4 2/3] dt-bindigs: display: extend the simple bridge with MStar TSUMU88ADT3-LF-1 bridge Svyatoslav Ryhel
@ 2026-03-03 21:49 ` Claude Code Review Bot
0 siblings, 0 replies; 8+ messages in thread
From: Claude Code Review Bot @ 2026-03-03 21:49 UTC (permalink / raw)
To: dri-devel-reviews
Patch Review
**Author:** Svyatoslav Ryhel
Adds `mstar,tsumu88adt3-lf-1` to the simple-bridge.yaml compatible enum.
```yaml
+ - mstar,tsumu88adt3-lf-1
```
- **Alphabetical ordering:** Correct. `mstar,...` sorts after `dumb-vga-dac` and before `parade,ps185hdm`.
- **Placement:** In the standalone `enum` block (bridges without a fallback compatible), which is appropriate for this device.
**Nit:** Same subject typo — "dt-bindigs" should be "dt-bindings".
No other issues.
---
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 8+ messages in thread
* Claude review: drm/bridge: simple-bridge: Add support for MStar TSUMU88ADT3-LF-1
2026-03-03 8:20 ` [PATCH v4 3/3] drm/bridge: simple-bridge: Add support for MStar TSUMU88ADT3-LF-1 Svyatoslav Ryhel
@ 2026-03-03 21:49 ` Claude Code Review Bot
0 siblings, 0 replies; 8+ messages in thread
From: Claude Code Review Bot @ 2026-03-03 21:49 UTC (permalink / raw)
To: dri-devel-reviews
Patch Review
**Author:** Maxim Schwalm / Svyatoslav Ryhel
Adds the `of_device_id` entry for the MStar bridge in the simple-bridge driver.
```c
+ }, {
+ .compatible = "mstar,tsumu88adt3-lf-1",
+ .data = &(const struct simple_bridge_info) {
+ .connector_type = DRM_MODE_CONNECTOR_HDMIA,
+ },
```
- **Alphabetical ordering:** Correct. Placed after `asl-tek,cs5263` and before `parade,ps185hdm` in the `of_device_id` table.
- **Connector type:** `DRM_MODE_CONNECTOR_HDMIA` is correct for an HDMI bridge.
- **No timings:** The entry does not specify `.timings`, which means the bridge has no special timing constraints. This is consistent with other HDMI bridge entries in the table (e.g., `algoltek,ag6311`, `parade,ps185hdm`, `radxa,ra620`), and matches the cover letter description of a simple HDMI bridge.
- **Code style:** Matches the existing compound literal pattern used throughout the table.
No issues.
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2026-03-03 21:49 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-03 8:20 [PATCH v4 0/3] drm: bridge: add support for Triple 10-BIT Svyatoslav Ryhel
2026-03-03 8:20 ` [PATCH v4 1/3] dt-bindigs: display: extend the LVDS codec with Triple 10-BIT LVDS Transmitter Svyatoslav Ryhel
2026-03-03 21:49 ` Claude review: " Claude Code Review Bot
2026-03-03 8:20 ` [PATCH v4 2/3] dt-bindigs: display: extend the simple bridge with MStar TSUMU88ADT3-LF-1 bridge Svyatoslav Ryhel
2026-03-03 21:49 ` Claude review: " Claude Code Review Bot
2026-03-03 8:20 ` [PATCH v4 3/3] drm/bridge: simple-bridge: Add support for MStar TSUMU88ADT3-LF-1 Svyatoslav Ryhel
2026-03-03 21:49 ` Claude review: " Claude Code Review Bot
2026-03-03 21:49 ` Claude review: drm: bridge: add support for Triple 10-BIT Claude Code Review Bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox