* [PATCH 1/5] dt-bindings: display: samsung,s6d7aa0: Document port
2026-03-06 12:02 [PATCH 0/5] dt-bindings: display: panel: Few cleanups and fixes Krzysztof Kozlowski
@ 2026-03-06 12:02 ` Krzysztof Kozlowski
2026-03-08 22:53 ` Claude review: " Claude Code Review Bot
2026-03-06 12:02 ` [PATCH 2/5] dt-bindings: display: innolux,p097pfg: Document ports Krzysztof Kozlowski
` (4 subsequent siblings)
5 siblings, 1 reply; 12+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-06 12:02 UTC (permalink / raw)
To: Artur Weber, Neil Armstrong, Jessica Zhang, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Dzmitry Sankouski,
Tomi Valkeinen, Laurent Pinchart, Konrad Dybcio
Cc: dri-devel, devicetree, linux-kernel, linux-renesas-soc,
Krzysztof Kozlowski
This MIPI-DSI LCD panel must be connected to something, thus add missing
port property, already used in DTS. Reported by dtbs_check:
qcom/msm8916-samsung-gt58.dtb: panel@0 (samsung,lsl080al03): 'port' does not match any of the regexes: '^pinctrl-[0-9]+$'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
.../devicetree/bindings/display/panel/samsung,s6d7aa0.yaml | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6d7aa0.yaml b/Documentation/devicetree/bindings/display/panel/samsung,s6d7aa0.yaml
index 939da65114bf..1f753b706911 100644
--- a/Documentation/devicetree/bindings/display/panel/samsung,s6d7aa0.yaml
+++ b/Documentation/devicetree/bindings/display/panel/samsung,s6d7aa0.yaml
@@ -44,6 +44,8 @@ properties:
vmipi-supply:
description: VMIPI supply, usually 1.8v.
+ port: true
+
required:
- compatible
- reg
@@ -65,6 +67,12 @@ examples:
power-supply = <&display_3v3_supply>;
reset-gpios = <&gpf0 4 GPIO_ACTIVE_LOW>;
backlight = <&backlight>;
+
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&mdss_dsi0_out>;
+ };
+ };
};
};
--
2.51.0
^ permalink raw reply related [flat|nested] 12+ messages in thread* Claude review: dt-bindings: display: samsung,s6d7aa0: Document port
2026-03-06 12:02 ` [PATCH 1/5] dt-bindings: display: samsung,s6d7aa0: Document port Krzysztof Kozlowski
@ 2026-03-08 22:53 ` Claude Code Review Bot
0 siblings, 0 replies; 12+ messages in thread
From: Claude Code Review Bot @ 2026-03-08 22:53 UTC (permalink / raw)
To: dri-devel-reviews
Patch Review
This adds the missing `port: true` property and a corresponding example to `samsung,s6d7aa0.yaml`. The binding uses `additionalProperties: false` (line 54 post-patch), so `port: true` must be explicitly listed. The commit message includes the `dtbs_check` error being fixed:
```
qcom/msm8916-samsung-gt58.dtb: panel@0 (samsung,lsl080al03): 'port' does not match any of the regexes: '^pinctrl-[0-9]+$'
```
The `port: true` is correctly placed after the supply properties and before `required:`, and the example endpoint follows standard DT conventions. No issues.
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 2/5] dt-bindings: display: innolux,p097pfg: Document ports
2026-03-06 12:02 [PATCH 0/5] dt-bindings: display: panel: Few cleanups and fixes Krzysztof Kozlowski
2026-03-06 12:02 ` [PATCH 1/5] dt-bindings: display: samsung,s6d7aa0: Document port Krzysztof Kozlowski
@ 2026-03-06 12:02 ` Krzysztof Kozlowski
2026-03-08 22:53 ` Claude review: " Claude Code Review Bot
2026-03-06 12:02 ` [PATCH 3/5] dt-bindings: display: panel: Drop redundant properties Krzysztof Kozlowski
` (3 subsequent siblings)
5 siblings, 1 reply; 12+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-06 12:02 UTC (permalink / raw)
To: Artur Weber, Neil Armstrong, Jessica Zhang, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Dzmitry Sankouski,
Tomi Valkeinen, Laurent Pinchart, Konrad Dybcio
Cc: dri-devel, devicetree, linux-kernel, linux-renesas-soc,
Krzysztof Kozlowski
This MIPI-DSI LCD panel must be connected to something. According to
scarce web data it supports two channels and it is already used like
this in DTS. Reported by dtbs_check:
rockchip/rk3399-gru-scarlet-inx.dtb: panel@0 (innolux,p097pfg): 'ports' does not match any of the regexes: '^pinctrl-[0-9]+$'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
.../bindings/display/panel/innolux,p097pfg.yaml | 26 +++++++++++++++++++++-
1 file changed, 25 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/panel/innolux,p097pfg.yaml b/Documentation/devicetree/bindings/display/panel/innolux,p097pfg.yaml
index 4164e3f7061d..7c75e01797f6 100644
--- a/Documentation/devicetree/bindings/display/panel/innolux,p097pfg.yaml
+++ b/Documentation/devicetree/bindings/display/panel/innolux,p097pfg.yaml
@@ -10,7 +10,7 @@ maintainers:
- Lin Huang <hl@rock-chips.com>
allOf:
- - $ref: panel-common.yaml#
+ - $ref: panel-common-dual.yaml#
properties:
compatible:
@@ -28,6 +28,9 @@ properties:
avee-supply:
description: The regulator that provides negative voltage
+ port: true
+ ports: true
+
required:
- compatible
- reg
@@ -52,6 +55,27 @@ examples:
avee-supply = <&avee>;
backlight = <&backlight>;
enable-gpios = <&gpio1 13 GPIO_ACTIVE_HIGH>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ mipi_in_panel: endpoint {
+ remote-endpoint = <&mipi_out_panel>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ mipi1_in_panel: endpoint {
+ remote-endpoint = <&mipi1_out_panel>;
+ };
+ };
+ };
};
};
--
2.51.0
^ permalink raw reply related [flat|nested] 12+ messages in thread* Claude review: dt-bindings: display: innolux,p097pfg: Document ports
2026-03-06 12:02 ` [PATCH 2/5] dt-bindings: display: innolux,p097pfg: Document ports Krzysztof Kozlowski
@ 2026-03-08 22:53 ` Claude Code Review Bot
0 siblings, 0 replies; 12+ messages in thread
From: Claude Code Review Bot @ 2026-03-08 22:53 UTC (permalink / raw)
To: dri-devel-reviews
Patch Review
Changes the `$ref` from `panel-common.yaml#` to `panel-common-dual.yaml#` and adds `port: true` / `ports: true` with a dual-port example. This is correct because:
- `panel-common-dual.yaml` extends `panel-common.yaml` with dual-link `ports` support
- The `p097pfg` is a dual-channel MIPI-DSI panel (confirmed by the two-port example with `port@0` and `port@1`)
- The commit message notes this is "already used like this in DTS"
The example with two ports (`mipi_in_panel` / `mipi1_in_panel`) is correctly structured. No issues.
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 3/5] dt-bindings: display: panel: Drop redundant properties
2026-03-06 12:02 [PATCH 0/5] dt-bindings: display: panel: Few cleanups and fixes Krzysztof Kozlowski
2026-03-06 12:02 ` [PATCH 1/5] dt-bindings: display: samsung,s6d7aa0: Document port Krzysztof Kozlowski
2026-03-06 12:02 ` [PATCH 2/5] dt-bindings: display: innolux,p097pfg: Document ports Krzysztof Kozlowski
@ 2026-03-06 12:02 ` Krzysztof Kozlowski
2026-03-08 22:53 ` Claude review: " Claude Code Review Bot
2026-03-06 12:02 ` [PATCH 4/5] dt-bindings: display: panel: Align style of additionalProperties Krzysztof Kozlowski
` (2 subsequent siblings)
5 siblings, 1 reply; 12+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-06 12:02 UTC (permalink / raw)
To: Artur Weber, Neil Armstrong, Jessica Zhang, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Dzmitry Sankouski,
Tomi Valkeinen, Laurent Pinchart, Konrad Dybcio
Cc: dri-devel, devicetree, linux-kernel, linux-renesas-soc,
Krzysztof Kozlowski
The purpose of common schemas, like panel-common.yaml, is to list
applicable properties. It can list common ABI, e.g. "label" property,
and pure hardware related properties like power supply or GPIOs. In the
second case it means that all panels have these supplies or GPIOs.
This is the only meaning when hardware property is allowed in common
schema, because bindings are precise and we do not define common schemas
for "possible" hardware configurations.
Following this, all panel bindings which reference common schema and use
"unevaluatedProperties: false" do not need to list these common parts.
Simplify such bindings to also reduce copy-paste code and review time
for new contributions.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml | 5 -----
Documentation/devicetree/bindings/display/panel/himax,hx83112a.yaml | 2 --
Documentation/devicetree/bindings/display/panel/ilitek,ili9163.yaml | 4 ----
Documentation/devicetree/bindings/display/panel/ilitek,ili9322.yaml | 3 ---
Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml | 2 --
.../devicetree/bindings/display/panel/innolux,ej030na.yaml | 5 -----
.../devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.yaml | 5 -----
.../devicetree/bindings/display/panel/lgphilips,lb035q02.yaml | 4 ----
Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml | 4 ----
.../devicetree/bindings/display/panel/novatek,nt36523.yaml | 3 ---
.../devicetree/bindings/display/panel/novatek,nt36672a.yaml | 3 ---
.../devicetree/bindings/display/panel/raydium,rm692e5.yaml | 2 --
Documentation/devicetree/bindings/display/panel/samsung,ld9040.yaml | 4 ----
.../devicetree/bindings/display/panel/samsung,lms380kf01.yaml | 6 ------
.../devicetree/bindings/display/panel/samsung,lms397kf04.yaml | 6 ------
.../devicetree/bindings/display/panel/samsung,s6d27a1.yaml | 6 ------
.../devicetree/bindings/display/panel/samsung,s6e3ha8.yaml | 4 ----
.../devicetree/bindings/display/panel/samsung,s6e63m0.yaml | 2 --
.../devicetree/bindings/display/panel/sitronix,st7701.yaml | 6 ------
.../devicetree/bindings/display/panel/sitronix,st7789v.yaml | 6 ------
Documentation/devicetree/bindings/display/panel/sony,acx565akm.yaml | 4 ----
Documentation/devicetree/bindings/display/panel/tpo,td.yaml | 5 -----
22 files changed, 91 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml b/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml
index 0aa2d3fbadaa..72cbb9ee5eae 100644
--- a/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml
+++ b/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml
@@ -20,11 +20,6 @@ properties:
reg:
maxItems: 1
- backlight: true
- port: true
- power-supply: true
- reset-gpios: true
-
required:
- compatible
- reg
diff --git a/Documentation/devicetree/bindings/display/panel/himax,hx83112a.yaml b/Documentation/devicetree/bindings/display/panel/himax,hx83112a.yaml
index 56bcd152f43c..2c60d0cd704e 100644
--- a/Documentation/devicetree/bindings/display/panel/himax,hx83112a.yaml
+++ b/Documentation/devicetree/bindings/display/panel/himax,hx83112a.yaml
@@ -33,8 +33,6 @@ properties:
vsp-supply:
description: Negative source voltage rail
- port: true
-
required:
- compatible
- reg
diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9163.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9163.yaml
index ef5a2240b684..cc80d0e90f1a 100644
--- a/Documentation/devicetree/bindings/display/panel/ilitek,ili9163.yaml
+++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9163.yaml
@@ -34,10 +34,6 @@ properties:
maxItems: 1
description: Display data/command selection (D/CX)
- backlight: true
- reset-gpios: true
- rotation: true
-
required:
- compatible
- reg
diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9322.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9322.yaml
index 4bdc33d12306..c97bfd0f2ebc 100644
--- a/Documentation/devicetree/bindings/display/panel/ilitek,ili9322.yaml
+++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9322.yaml
@@ -29,9 +29,6 @@ properties:
reg:
maxItems: 1
- reset-gpios: true
- port: true
-
vcc-supply:
description: Core voltage supply
diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml
index 5f41758c96d5..3cada0f82951 100644
--- a/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml
+++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml
@@ -40,8 +40,6 @@ properties:
spi-max-frequency:
const: 10000000
- port: true
-
vci-supply:
description: Analog voltage supply (2.5 .. 3.3V)
diff --git a/Documentation/devicetree/bindings/display/panel/innolux,ej030na.yaml b/Documentation/devicetree/bindings/display/panel/innolux,ej030na.yaml
index c7df9a7f6589..59cc7edb22bb 100644
--- a/Documentation/devicetree/bindings/display/panel/innolux,ej030na.yaml
+++ b/Documentation/devicetree/bindings/display/panel/innolux,ej030na.yaml
@@ -20,11 +20,6 @@ properties:
reg:
maxItems: 1
- backlight: true
- port: true
- power-supply: true
- reset-gpios: true
-
required:
- compatible
- reg
diff --git a/Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.yaml b/Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.yaml
index d86c916f7b55..fe7ad266e1b0 100644
--- a/Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.yaml
+++ b/Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.yaml
@@ -20,11 +20,6 @@ properties:
reg:
maxItems: 1
- backlight: true
- port: true
- power-supply: true
- reset-gpios: true
-
spi-3wire: true
required:
diff --git a/Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml b/Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml
index 3de17fd8513b..3c8c65c6a869 100644
--- a/Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml
+++ b/Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml
@@ -20,10 +20,6 @@ properties:
reg:
maxItems: 1
- label: true
- enable-gpios: true
- port: true
-
spi-cpha: true
spi-cpol: true
diff --git a/Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml b/Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml
index 1cffe4d6d498..eb9eeba92359 100644
--- a/Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml
+++ b/Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml
@@ -24,10 +24,6 @@ properties:
reg:
maxItems: 1
- label: true
- port: true
- reset-gpios: true
-
spi-max-frequency:
maximum: 10000000
diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
index c4bae4f77085..b9300a1f2646 100644
--- a/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
+++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
@@ -37,9 +37,6 @@ properties:
vddio-supply:
description: regulator that supplies the I/O voltage
- rotation: true
- backlight: true
-
required:
- compatible
- reg
diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml
index 800a2f0a4dad..5d16d8511725 100644
--- a/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml
+++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml
@@ -47,9 +47,6 @@ properties:
vddneg-supply:
description: phandle of the negative boost supply regulator
- port: true
- backlight: true
-
required:
- compatible
- reg
diff --git a/Documentation/devicetree/bindings/display/panel/raydium,rm692e5.yaml b/Documentation/devicetree/bindings/display/panel/raydium,rm692e5.yaml
index 7ad223f98253..616a5f3ec9fc 100644
--- a/Documentation/devicetree/bindings/display/panel/raydium,rm692e5.yaml
+++ b/Documentation/devicetree/bindings/display/panel/raydium,rm692e5.yaml
@@ -34,8 +34,6 @@ properties:
vddio-supply:
description: I/O voltage rail
- port: true
-
required:
- compatible
- reg
diff --git a/Documentation/devicetree/bindings/display/panel/samsung,ld9040.yaml b/Documentation/devicetree/bindings/display/panel/samsung,ld9040.yaml
index bc92b16c95b9..2e64fba472cc 100644
--- a/Documentation/devicetree/bindings/display/panel/samsung,ld9040.yaml
+++ b/Documentation/devicetree/bindings/display/panel/samsung,ld9040.yaml
@@ -20,10 +20,6 @@ properties:
reg:
maxItems: 1
- display-timings: true
- port: true
- reset-gpios: true
-
vdd3-supply:
description: core voltage supply
diff --git a/Documentation/devicetree/bindings/display/panel/samsung,lms380kf01.yaml b/Documentation/devicetree/bindings/display/panel/samsung,lms380kf01.yaml
index 74c2a617c2ff..828b7d7ba17f 100644
--- a/Documentation/devicetree/bindings/display/panel/samsung,lms380kf01.yaml
+++ b/Documentation/devicetree/bindings/display/panel/samsung,lms380kf01.yaml
@@ -31,8 +31,6 @@ properties:
configuration.
maxItems: 1
- reset-gpios: true
-
vci-supply:
description: regulator that supplies the VCI analog voltage
usually around 3.0 V
@@ -41,8 +39,6 @@ properties:
description: regulator that supplies the VCCIO voltage usually
around 1.8 V
- backlight: true
-
spi-cpha: true
spi-cpol: true
@@ -50,8 +46,6 @@ properties:
spi-max-frequency:
maximum: 1200000
- port: true
-
required:
- compatible
- reg
diff --git a/Documentation/devicetree/bindings/display/panel/samsung,lms397kf04.yaml b/Documentation/devicetree/bindings/display/panel/samsung,lms397kf04.yaml
index 4cecf502a150..c04d47e59f24 100644
--- a/Documentation/devicetree/bindings/display/panel/samsung,lms397kf04.yaml
+++ b/Documentation/devicetree/bindings/display/panel/samsung,lms397kf04.yaml
@@ -23,8 +23,6 @@ properties:
reg:
maxItems: 1
- reset-gpios: true
-
vci-supply:
description: regulator that supplies the VCI analog voltage
usually around 3.0 V
@@ -33,8 +31,6 @@ properties:
description: regulator that supplies the VCCIO voltage usually
around 1.8 V
- backlight: true
-
spi-cpha: true
spi-cpol: true
@@ -44,8 +40,6 @@ properties:
maximum 300 ns minimum cycle which gives around 3 MHz max frequency
maximum: 3000000
- port: true
-
required:
- compatible
- reg
diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6d27a1.yaml b/Documentation/devicetree/bindings/display/panel/samsung,s6d27a1.yaml
index d74904164719..0d57f97e8a76 100644
--- a/Documentation/devicetree/bindings/display/panel/samsung,s6d27a1.yaml
+++ b/Documentation/devicetree/bindings/display/panel/samsung,s6d27a1.yaml
@@ -30,8 +30,6 @@ properties:
configuration.
maxItems: 1
- reset-gpios: true
-
vci-supply:
description: regulator that supplies the VCI analog voltage
usually around 3.0 V
@@ -40,8 +38,6 @@ properties:
description: regulator that supplies the VCCIO voltage usually
around 1.8 V
- backlight: true
-
spi-cpha: true
spi-cpol: true
@@ -49,8 +45,6 @@ properties:
spi-max-frequency:
maximum: 1200000
- port: true
-
required:
- compatible
- reg
diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha8.yaml b/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha8.yaml
index 05a78429aaea..00ce5a4e1c6b 100644
--- a/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha8.yaml
+++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha8.yaml
@@ -22,10 +22,6 @@ properties:
reg:
maxItems: 1
- reset-gpios: true
-
- port: true
-
vdd3-supply:
description: VDD regulator
diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.yaml b/Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.yaml
index c47e2a1a30e5..b65f0688bdf0 100644
--- a/Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.yaml
+++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.yaml
@@ -21,8 +21,6 @@ properties:
reg:
maxItems: 1
- reset-gpios: true
- port: true
default-brightness: true
max-brightness: true
diff --git a/Documentation/devicetree/bindings/display/panel/sitronix,st7701.yaml b/Documentation/devicetree/bindings/display/panel/sitronix,st7701.yaml
index 1e434240ea3f..044b84d8638d 100644
--- a/Documentation/devicetree/bindings/display/panel/sitronix,st7701.yaml
+++ b/Documentation/devicetree/bindings/display/panel/sitronix,st7701.yaml
@@ -49,12 +49,6 @@ properties:
If not set, the controller is in 3-line SPI mode.
Disallowed for DSI.
- port: true
- reset-gpios: true
- rotation: true
-
- backlight: true
-
required:
- compatible
- reg
diff --git a/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml b/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml
index c35d4f2ab9a4..e4fa05163d2d 100644
--- a/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml
+++ b/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml
@@ -24,12 +24,6 @@ properties:
reg:
maxItems: 1
- reset-gpios: true
- power-supply: true
- backlight: true
- port: true
- rotation: true
-
spi-cpha: true
spi-cpol: true
diff --git a/Documentation/devicetree/bindings/display/panel/sony,acx565akm.yaml b/Documentation/devicetree/bindings/display/panel/sony,acx565akm.yaml
index 5a8260224b74..12e5ad504001 100644
--- a/Documentation/devicetree/bindings/display/panel/sony,acx565akm.yaml
+++ b/Documentation/devicetree/bindings/display/panel/sony,acx565akm.yaml
@@ -20,10 +20,6 @@ properties:
reg:
maxItems: 1
- label: true
- reset-gpios: true
- port: true
-
required:
- compatible
- port
diff --git a/Documentation/devicetree/bindings/display/panel/tpo,td.yaml b/Documentation/devicetree/bindings/display/panel/tpo,td.yaml
index 7edd29df4bbb..855911588d73 100644
--- a/Documentation/devicetree/bindings/display/panel/tpo,td.yaml
+++ b/Documentation/devicetree/bindings/display/panel/tpo,td.yaml
@@ -25,11 +25,6 @@ properties:
reg:
maxItems: 1
- label: true
- reset-gpios: true
- backlight: true
- port: true
-
spi-cpha: true
spi-cpol: true
--
2.51.0
^ permalink raw reply related [flat|nested] 12+ messages in thread* Claude review: dt-bindings: display: panel: Drop redundant properties
2026-03-06 12:02 ` [PATCH 3/5] dt-bindings: display: panel: Drop redundant properties Krzysztof Kozlowski
@ 2026-03-08 22:53 ` Claude Code Review Bot
0 siblings, 0 replies; 12+ messages in thread
From: Claude Code Review Bot @ 2026-03-08 22:53 UTC (permalink / raw)
To: dri-devel-reviews
Patch Review
This is the largest patch, removing redundant `": true"` property declarations from 22 bindings. The logic is sound: bindings that use `$ref: panel-common.yaml#` combined with `unevaluatedProperties: false` already inherit all properties from the common schema. Properties like `port`, `reset-gpios`, `backlight`, `power-supply`, `label`, `rotation`, and `display-timings` are all defined in `panel-common.yaml` and don't need to be re-declared.
I verified several files (e.g., `abt,y030xx067a.yaml`, `sitronix,st7701.yaml`) and confirmed they use `unevaluatedProperties: false` with `$ref: panel-common.yaml#`, making the removed declarations truly redundant.
One subtle point worth noting: `samsung,s6e63m0.yaml` retains `default-brightness: true` and `max-brightness: true` after removing `reset-gpios: true` and `port: true`. This is correct since `default-brightness` and `max-brightness` are NOT in `panel-common.yaml` (they're panel-specific extensions). No issues.
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 4/5] dt-bindings: display: panel: Align style of additionalProperties
2026-03-06 12:02 [PATCH 0/5] dt-bindings: display: panel: Few cleanups and fixes Krzysztof Kozlowski
` (2 preceding siblings ...)
2026-03-06 12:02 ` [PATCH 3/5] dt-bindings: display: panel: Drop redundant properties Krzysztof Kozlowski
@ 2026-03-06 12:02 ` Krzysztof Kozlowski
2026-03-08 22:53 ` Claude review: " Claude Code Review Bot
2026-03-06 12:02 ` [PATCH 5/5] dt-bindings: display: panel: Align style of "true" properties Krzysztof Kozlowski
2026-03-08 22:53 ` Claude review: dt-bindings: display: panel: Few cleanups and fixes Claude Code Review Bot
5 siblings, 1 reply; 12+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-06 12:02 UTC (permalink / raw)
To: Artur Weber, Neil Armstrong, Jessica Zhang, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Dzmitry Sankouski,
Tomi Valkeinen, Laurent Pinchart, Konrad Dybcio
Cc: dri-devel, devicetree, linux-kernel, linux-renesas-soc,
Krzysztof Kozlowski
For code readability the bindings are expected to follow order shown in
example-schema.yaml - put the additionalProperties/unevaluatedProperties
entry at the end, after listing all required properties and possible
"allOf:if:then:" conditions. Meaning of this style is to close the
schema, after listing what it contains, with final "nothing more is
allowed".
Move the code around adjusting it to coding style. No functional
impact.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
.../devicetree/bindings/display/panel/advantech,idk-1110wr.yaml | 4 ++--
.../devicetree/bindings/display/panel/advantech,idk-2121wr.yaml | 4 ++--
.../devicetree/bindings/display/panel/bananapi,s070wv20-ct16.yaml | 4 ++--
Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.yaml | 4 ++--
Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml | 4 ++--
Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml | 4 ++--
.../devicetree/bindings/display/panel/mitsubishi,aa104xd12.yaml | 4 ++--
.../devicetree/bindings/display/panel/mitsubishi,aa121td01.yaml | 4 ++--
.../devicetree/bindings/display/panel/orisetech,otm8009a.yaml | 4 ++--
Documentation/devicetree/bindings/display/panel/pda,91-00156-a0.yaml | 4 ++--
Documentation/devicetree/bindings/display/panel/raydium,rm68200.yaml | 4 ++--
.../devicetree/bindings/display/panel/samsung,atna33xc20.yaml | 4 ++--
.../devicetree/bindings/display/panel/sgd,gktw70sdae4se.yaml | 4 ++--
.../devicetree/bindings/display/panel/startek,kd070fhfid015.yaml | 4 ++--
Documentation/devicetree/bindings/display/panel/visionox,r66451.yaml | 4 ++--
Documentation/devicetree/bindings/display/panel/visionox,rm69299.yaml | 4 ++--
.../devicetree/bindings/display/panel/visionox,vtdr6130.yaml | 4 ++--
17 files changed, 34 insertions(+), 34 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml b/Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml
index f6fea9085aab..76b48836ddf6 100644
--- a/Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml
+++ b/Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml
@@ -41,8 +41,6 @@ properties:
panel-timing: true
port: true
-additionalProperties: false
-
required:
- compatible
- data-mapping
@@ -51,6 +49,8 @@ required:
- panel-timing
- port
+additionalProperties: false
+
examples:
- |+
panel {
diff --git a/Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.yaml b/Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.yaml
index 05ca3b2385f8..c9b066e69e2f 100644
--- a/Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.yaml
+++ b/Documentation/devicetree/bindings/display/panel/advantech,idk-2121wr.yaml
@@ -56,8 +56,6 @@ properties:
- port@0
- port@1
-additionalProperties: false
-
required:
- compatible
- width-mm
@@ -65,6 +63,8 @@ required:
- data-mapping
- panel-timing
+additionalProperties: false
+
examples:
- |+
panel-lvds {
diff --git a/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.yaml b/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.yaml
index bbf127fb28f7..46e7cff5b2fa 100644
--- a/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.yaml
+++ b/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16.yaml
@@ -22,10 +22,10 @@ properties:
enable-gpios: true
port: true
-additionalProperties: false
-
required:
- compatible
- power-supply
+additionalProperties: false
+
...
diff --git a/Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.yaml b/Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.yaml
index 287e2feb6533..9a2c532dbc92 100644
--- a/Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.yaml
+++ b/Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.yaml
@@ -22,10 +22,10 @@ properties:
backlight: true
port: true
-additionalProperties: false
-
required:
- compatible
- power-supply
+additionalProperties: false
+
...
diff --git a/Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml b/Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml
index 5725a587e35c..182a2b825e1c 100644
--- a/Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml
+++ b/Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml
@@ -54,8 +54,6 @@ required:
- vcc-supply
- iovcc-supply
-additionalProperties: false
-
allOf:
- $ref: panel-common.yaml#
- if:
@@ -68,6 +66,8 @@ allOf:
required:
- reset-gpios
+additionalProperties: false
+
examples:
- |
#include <dt-bindings/gpio/gpio.h>
diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml
index 3cada0f82951..aeb7cb26c058 100644
--- a/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml
+++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml
@@ -49,8 +49,6 @@ properties:
vddi-led-supply:
description: Voltage supply for the LED driver (1.65 .. 3.3 V)
-unevaluatedProperties: false
-
required:
- compatible
- reg
@@ -66,6 +64,8 @@ then:
required:
- port
+unevaluatedProperties: false
+
examples:
- |+
#include <dt-bindings/gpio/gpio.h>
diff --git a/Documentation/devicetree/bindings/display/panel/mitsubishi,aa104xd12.yaml b/Documentation/devicetree/bindings/display/panel/mitsubishi,aa104xd12.yaml
index 96621b89ae9e..43e98bb07c38 100644
--- a/Documentation/devicetree/bindings/display/panel/mitsubishi,aa104xd12.yaml
+++ b/Documentation/devicetree/bindings/display/panel/mitsubishi,aa104xd12.yaml
@@ -47,8 +47,6 @@ properties:
panel-timing: true
port: true
-additionalProperties: false
-
required:
- compatible
- data-mapping
@@ -57,6 +55,8 @@ required:
- panel-timing
- port
+additionalProperties: false
+
examples:
- |+
diff --git a/Documentation/devicetree/bindings/display/panel/mitsubishi,aa121td01.yaml b/Documentation/devicetree/bindings/display/panel/mitsubishi,aa121td01.yaml
index 37f01d847aac..2af993d73619 100644
--- a/Documentation/devicetree/bindings/display/panel/mitsubishi,aa121td01.yaml
+++ b/Documentation/devicetree/bindings/display/panel/mitsubishi,aa121td01.yaml
@@ -44,8 +44,6 @@ properties:
panel-timing: true
port: true
-additionalProperties: false
-
required:
- compatible
- vcc-supply
@@ -55,6 +53,8 @@ required:
- panel-timing
- port
+additionalProperties: false
+
examples:
- |+
panel {
diff --git a/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.yaml b/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.yaml
index 1e4f140f48b8..1f697dab832b 100644
--- a/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.yaml
+++ b/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.yaml
@@ -31,12 +31,12 @@ properties:
reset-gpios:
maxItems: 1
-additionalProperties: false
-
required:
- compatible
- reg
+additionalProperties: false
+
examples:
- |
dsi {
diff --git a/Documentation/devicetree/bindings/display/panel/pda,91-00156-a0.yaml b/Documentation/devicetree/bindings/display/panel/pda,91-00156-a0.yaml
index ccd3623b4955..871e4c2d9824 100644
--- a/Documentation/devicetree/bindings/display/panel/pda,91-00156-a0.yaml
+++ b/Documentation/devicetree/bindings/display/panel/pda,91-00156-a0.yaml
@@ -21,11 +21,11 @@ properties:
backlight: true
port: true
-additionalProperties: false
-
required:
- compatible
- power-supply
- backlight
+additionalProperties: false
+
...
diff --git a/Documentation/devicetree/bindings/display/panel/raydium,rm68200.yaml b/Documentation/devicetree/bindings/display/panel/raydium,rm68200.yaml
index 46fe1014ebc4..8fb7c013dfb8 100644
--- a/Documentation/devicetree/bindings/display/panel/raydium,rm68200.yaml
+++ b/Documentation/devicetree/bindings/display/panel/raydium,rm68200.yaml
@@ -33,13 +33,13 @@ properties:
reset-gpios:
maxItems: 1
-additionalProperties: false
-
required:
- compatible
- power-supply
- reg
+additionalProperties: false
+
examples:
- |
dsi {
diff --git a/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml b/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml
index f1723e910252..1bbe0da3997c 100644
--- a/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml
+++ b/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml
@@ -43,13 +43,13 @@ properties:
no-hpd: true
hpd-gpios: true
-additionalProperties: false
-
required:
- compatible
- enable-gpios
- power-supply
+additionalProperties: false
+
examples:
- |
#include <dt-bindings/clock/qcom,rpmh.h>
diff --git a/Documentation/devicetree/bindings/display/panel/sgd,gktw70sdae4se.yaml b/Documentation/devicetree/bindings/display/panel/sgd,gktw70sdae4se.yaml
index e32d9188a3e0..1beb4ba92248 100644
--- a/Documentation/devicetree/bindings/display/panel/sgd,gktw70sdae4se.yaml
+++ b/Documentation/devicetree/bindings/display/panel/sgd,gktw70sdae4se.yaml
@@ -41,8 +41,6 @@ properties:
panel-timing: true
port: true
-additionalProperties: false
-
required:
- compatible
- port
@@ -51,6 +49,8 @@ required:
- height-mm
- panel-timing
+additionalProperties: false
+
examples:
- |+
panel {
diff --git a/Documentation/devicetree/bindings/display/panel/startek,kd070fhfid015.yaml b/Documentation/devicetree/bindings/display/panel/startek,kd070fhfid015.yaml
index d817f998cddc..0819f38a9d2c 100644
--- a/Documentation/devicetree/bindings/display/panel/startek,kd070fhfid015.yaml
+++ b/Documentation/devicetree/bindings/display/panel/startek,kd070fhfid015.yaml
@@ -31,8 +31,6 @@ properties:
power-supply: true
-additionalProperties: false
-
required:
- compatible
- enable-gpios
@@ -42,6 +40,8 @@ required:
- port
- power-supply
+additionalProperties: false
+
examples:
- |
#include <dt-bindings/gpio/gpio.h>
diff --git a/Documentation/devicetree/bindings/display/panel/visionox,r66451.yaml b/Documentation/devicetree/bindings/display/panel/visionox,r66451.yaml
index 187840bb76c7..49ef45c03593 100644
--- a/Documentation/devicetree/bindings/display/panel/visionox,r66451.yaml
+++ b/Documentation/devicetree/bindings/display/panel/visionox,r66451.yaml
@@ -25,8 +25,6 @@ properties:
port: true
reset-gpios: true
-additionalProperties: false
-
required:
- compatible
- reg
@@ -35,6 +33,8 @@ required:
- reset-gpios
- port
+additionalProperties: false
+
examples:
- |
#include <dt-bindings/gpio/gpio.h>
diff --git a/Documentation/devicetree/bindings/display/panel/visionox,rm69299.yaml b/Documentation/devicetree/bindings/display/panel/visionox,rm69299.yaml
index f0a82f0ff790..f61a528c0413 100644
--- a/Documentation/devicetree/bindings/display/panel/visionox,rm69299.yaml
+++ b/Documentation/devicetree/bindings/display/panel/visionox,rm69299.yaml
@@ -36,8 +36,6 @@ properties:
port: true
reset-gpios: true
-additionalProperties: false
-
required:
- compatible
- reg
@@ -46,6 +44,8 @@ required:
- reset-gpios
- port
+additionalProperties: false
+
examples:
- |
dsi {
diff --git a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml
index d5a8295106c1..c99f4146f1bb 100644
--- a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml
+++ b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml
@@ -26,8 +26,6 @@ properties:
port: true
reset-gpios: true
-additionalProperties: false
-
required:
- compatible
- reg
@@ -37,6 +35,8 @@ required:
- reset-gpios
- port
+additionalProperties: false
+
examples:
- |
#include <dt-bindings/gpio/gpio.h>
--
2.51.0
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 5/5] dt-bindings: display: panel: Align style of "true" properties
2026-03-06 12:02 [PATCH 0/5] dt-bindings: display: panel: Few cleanups and fixes Krzysztof Kozlowski
` (3 preceding siblings ...)
2026-03-06 12:02 ` [PATCH 4/5] dt-bindings: display: panel: Align style of additionalProperties Krzysztof Kozlowski
@ 2026-03-06 12:02 ` Krzysztof Kozlowski
2026-03-08 22:53 ` Claude review: " Claude Code Review Bot
2026-03-08 22:53 ` Claude review: dt-bindings: display: panel: Few cleanups and fixes Claude Code Review Bot
5 siblings, 1 reply; 12+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-06 12:02 UTC (permalink / raw)
To: Artur Weber, Neil Armstrong, Jessica Zhang, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Dzmitry Sankouski,
Tomi Valkeinen, Laurent Pinchart, Konrad Dybcio
Cc: dri-devel, devicetree, linux-kernel, linux-renesas-soc,
Krzysztof Kozlowski
For code readability, several bindings which list allowed properties
with ": true" syntax group them in one place, without line breaks
between each. Align a few bindings to match this style. No functional
impact.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
.../devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml | 1 -
Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml | 3 ---
.../devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml | 2 --
.../devicetree/bindings/display/panel/leadtek,ltk050h3146w.yaml | 1 +
.../devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml | 1 +
.../devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml | 5 ++---
.../devicetree/bindings/display/panel/novatek,nt35510.yaml | 3 ++-
.../devicetree/bindings/display/panel/renesas,r61307.yaml | 3 +--
.../devicetree/bindings/display/panel/renesas,r69328.yaml | 1 -
.../devicetree/bindings/display/panel/rocktech,jh057n00900.yaml | 5 ++---
.../bindings/display/panel/sony,tulip-truly-nt35521.yaml | 2 --
.../devicetree/bindings/display/panel/startek,kd070fhfid015.yaml | 7 ++-----
12 files changed, 11 insertions(+), 23 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml b/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml
index 92df69e80a82..f288fa2390c9 100644
--- a/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml
+++ b/Documentation/devicetree/bindings/display/panel/feiyang,fy07024di26a30d.yaml
@@ -28,7 +28,6 @@ properties:
port: true
reset-gpios: true
-
backlight: true
required:
diff --git a/Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml b/Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml
index 182a2b825e1c..84e840e0224f 100644
--- a/Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml
+++ b/Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml
@@ -33,11 +33,8 @@ properties:
maxItems: 1
reset-gpios: true
-
backlight: true
-
rotation: true
-
port: true
vcc-supply:
diff --git a/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml b/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
index 5802fb3c9ffe..2fa07ec55b08 100644
--- a/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
+++ b/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
@@ -35,9 +35,7 @@ properties:
description: supply regulator for VCCIO, usually 1.8V
reset-gpios: true
-
backlight: true
-
port: true
required:
diff --git a/Documentation/devicetree/bindings/display/panel/leadtek,ltk050h3146w.yaml b/Documentation/devicetree/bindings/display/panel/leadtek,ltk050h3146w.yaml
index 5fcea62fd58f..2f49a6bbf3d7 100644
--- a/Documentation/devicetree/bindings/display/panel/leadtek,ltk050h3146w.yaml
+++ b/Documentation/devicetree/bindings/display/panel/leadtek,ltk050h3146w.yaml
@@ -25,6 +25,7 @@ properties:
backlight: true
port: true
reset-gpios: true
+
iovcc-supply:
description: regulator that supplies the iovcc voltage
vci-supply:
diff --git a/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml b/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml
index b0e2c82232d3..3f56047f4469 100644
--- a/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml
+++ b/Documentation/devicetree/bindings/display/panel/leadtek,ltk500hd1829.yaml
@@ -24,6 +24,7 @@ properties:
backlight: true
port: true
reset-gpios: true
+
iovcc-supply:
description: regulator that supplies the iovcc voltage
vcc-supply:
diff --git a/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml b/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml
index 74ff772973d6..b8b153a6e6cc 100644
--- a/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml
+++ b/Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml
@@ -22,7 +22,6 @@ properties:
- mantix,mlaf057we51-x
- ys,ys57pss36bh5gq
- port: true
reg:
maxItems: 1
description: DSI virtual channel
@@ -36,13 +35,13 @@ properties:
vddi-supply:
description: 1.8V I/O voltage supply
- reset-gpios: true
-
mantix,tp-rstn-gpios:
maxItems: 1
description: second reset line that triggers DSI config load
backlight: true
+ port: true
+ reset-gpios: true
required:
- compatible
diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
index b39fd0c5a48a..43d134daf0ac 100644
--- a/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
+++ b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
@@ -28,13 +28,14 @@ properties:
reg:
maxItems: 1
- reset-gpios: true
vdd-supply:
description: regulator that supplies the vdd voltage
vddi-supply:
description: regulator that supplies the vddi voltage
+
backlight: true
port: true
+ reset-gpios: true
required:
- compatible
diff --git a/Documentation/devicetree/bindings/display/panel/renesas,r61307.yaml b/Documentation/devicetree/bindings/display/panel/renesas,r61307.yaml
index 90cce221c0d1..3d7761717b74 100644
--- a/Documentation/devicetree/bindings/display/panel/renesas,r61307.yaml
+++ b/Documentation/devicetree/bindings/display/panel/renesas,r61307.yaml
@@ -33,8 +33,6 @@ properties:
iovcc-supply:
description: Regulator for 1.8V IO power supply.
- backlight: true
-
renesas,gamma:
$ref: /schemas/types.yaml#/definitions/uint32
description:
@@ -51,6 +49,7 @@ properties:
type: boolean
description: digital contrast adjustment
+ backlight: true
reset-gpios: true
port: true
diff --git a/Documentation/devicetree/bindings/display/panel/renesas,r69328.yaml b/Documentation/devicetree/bindings/display/panel/renesas,r69328.yaml
index 1cd219b510ee..740185f778a1 100644
--- a/Documentation/devicetree/bindings/display/panel/renesas,r69328.yaml
+++ b/Documentation/devicetree/bindings/display/panel/renesas,r69328.yaml
@@ -33,7 +33,6 @@ properties:
description: Regulator for 1.8V IO power supply.
backlight: true
-
reset-gpios: true
port: true
diff --git a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
index 4ae152cc55e0..ebfc825b8346 100644
--- a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
+++ b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml
@@ -33,7 +33,6 @@ properties:
# Xingbangda XBD599 5.99" 720x1440 TFT LCD panel
- xingbangda,xbd599
- port: true
reg:
maxItems: 1
description: DSI virtual channel
@@ -44,9 +43,9 @@ properties:
iovcc-supply:
description: I/O voltage supply
- reset-gpios: true
-
backlight: true
+ port: true
+ reset-gpios: true
rotation: true
required:
diff --git a/Documentation/devicetree/bindings/display/panel/sony,tulip-truly-nt35521.yaml b/Documentation/devicetree/bindings/display/panel/sony,tulip-truly-nt35521.yaml
index a58a31349757..85c5dee65383 100644
--- a/Documentation/devicetree/bindings/display/panel/sony,tulip-truly-nt35521.yaml
+++ b/Documentation/devicetree/bindings/display/panel/sony,tulip-truly-nt35521.yaml
@@ -31,9 +31,7 @@ properties:
description: Negative 5V supply
reset-gpios: true
-
enable-gpios: true
-
port: true
required:
diff --git a/Documentation/devicetree/bindings/display/panel/startek,kd070fhfid015.yaml b/Documentation/devicetree/bindings/display/panel/startek,kd070fhfid015.yaml
index 0819f38a9d2c..7fd9364fa385 100644
--- a/Documentation/devicetree/bindings/display/panel/startek,kd070fhfid015.yaml
+++ b/Documentation/devicetree/bindings/display/panel/startek,kd070fhfid015.yaml
@@ -16,8 +16,6 @@ properties:
compatible:
const: startek,kd070fhfid015
- enable-gpios: true
-
iovcc-supply:
description: Reference to the regulator powering the panel IO pins.
@@ -25,11 +23,10 @@ properties:
maxItems: 1
description: DSI virtual channel
- reset-gpios: true
-
+ enable-gpios: true
port: true
-
power-supply: true
+ reset-gpios: true
required:
- compatible
--
2.51.0
^ permalink raw reply related [flat|nested] 12+ messages in thread* Claude review: dt-bindings: display: panel: Align style of "true" properties
2026-03-06 12:02 ` [PATCH 5/5] dt-bindings: display: panel: Align style of "true" properties Krzysztof Kozlowski
@ 2026-03-08 22:53 ` Claude Code Review Bot
0 siblings, 0 replies; 12+ messages in thread
From: Claude Code Review Bot @ 2026-03-08 22:53 UTC (permalink / raw)
To: dri-devel-reviews
Patch Review
Groups `": true"` property declarations together without blank line separations, and alphabetically sorts them where applicable (e.g., `backlight`, `port`, `reset-gpios`). Also moves some `": true"` properties that were scattered between other property definitions to a consolidated block.
For example in `mantix,mlaf057we51-x.yaml`, `port: true` was above `reg:` and `reset-gpios: true` was separated — the patch moves both to a clean group:
```yaml
backlight: true
port: true
reset-gpios: true
```
Pure cosmetic. The `himax,hx8394.yaml` change depends on patch 4 (which moved `additionalProperties` in that file), so the ordering within the series is correct. No issues.
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 12+ messages in thread
* Claude review: dt-bindings: display: panel: Few cleanups and fixes
2026-03-06 12:02 [PATCH 0/5] dt-bindings: display: panel: Few cleanups and fixes Krzysztof Kozlowski
` (4 preceding siblings ...)
2026-03-06 12:02 ` [PATCH 5/5] dt-bindings: display: panel: Align style of "true" properties Krzysztof Kozlowski
@ 2026-03-08 22:53 ` Claude Code Review Bot
5 siblings, 0 replies; 12+ messages in thread
From: Claude Code Review Bot @ 2026-03-08 22:53 UTC (permalink / raw)
To: dri-devel-reviews
Overall Series Review
Subject: dt-bindings: display: panel: Few cleanups and fixes
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Patches: 6
Reviewed: 2026-03-09T08:53:19.242039
---
This is a well-structured cleanup series from Krzysztof Kozlowski (a very experienced DT bindings maintainer) touching 50 panel binding YAML files. The series is purely mechanical/cosmetic with no functional changes, consisting of:
1. Two bug-fix patches adding missing `port`/`ports` documentation (patches 1-2)
2. One cleanup removing redundant property declarations already inherited from `panel-common.yaml` (patch 3)
3. Two style-alignment patches (patches 4-5)
The series is well-ordered (fixes first, then cleanups), each patch is self-contained, and the commit messages clearly explain the rationale. No issues found.
**Recommendation: Accept as-is.**
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 12+ messages in thread