From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37383FCB622 for ; Fri, 6 Mar 2026 16:47:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8FC9710EDDE; Fri, 6 Mar 2026 16:47:31 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="UgXDXmIx"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cDHeIM6p"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id A4BD710EDE3 for ; Fri, 6 Mar 2026 16:47:28 +0000 (UTC) Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626Fr6IB550283 for ; Fri, 6 Mar 2026 16:47:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tJzrziKqS66K8BTFV7yRFO0U3JoxSa5Zc+pCmKaMPzQ=; b=UgXDXmIxS0HdjyD7 y+NlaWZQ1s3gc+g591ESMTwKb598rpvC2HRitDqRmzUydFY2/29N8BXtxITMPGep 2I+CclEvBA8c9SNd9Si4LiN/VlKFoEbqwx6tesc+pZOsWxszr/VSaHKDtzcF9z4J RtCLM8LK2HjQJGFJbHFIJOtgAWYtKUjkZMjyhuHzksEqApBdifKSJwqY+nj5KcXj osSoRTlShdlZzAbhUpl7crxZk0XWDpRD+dLYFtpC0awcCuVsajZ8kntv8YPIg/3c WGtew1duxsckLmJq1xw55Hw0CkW6OYmwLCIWo1GdQqfhFytEYotfQqOkwTAzpM8S LhGIOA== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqruka67e-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 16:47:27 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cb706313beso1228040985a.3 for ; Fri, 06 Mar 2026 08:47:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772815647; x=1773420447; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=tJzrziKqS66K8BTFV7yRFO0U3JoxSa5Zc+pCmKaMPzQ=; b=cDHeIM6pUwSmTrZsiRObneZ+P+stZ3V23EhjvJa8yvkgZB4J2OPzhcoIPipWbxi/Hu nLlvUCCdGAOzDCEiWa0Vm1KLHpUkwZD1r26Iv9fTEaBg3CFYKDYLCU7bw5UklMA0eISL BZbxmVjT5OBgS8CQt23mBjVs7wU+8yJfXjF01NFW9v9+5ZSXJ50FagFdGQHxlKdabfX7 bhGNGkfreRyLBa93X31KCx+cIo9bDfThj699/D9+02rtGOK5OA1ERaBZ5IUIbckd/Dkg xPX4np0ez+6PMvsn0Wr6ngiDwAZYm6VW8h4uPrIP8YLKOm0lKwlHwKIOSaHAWGBHSgZz s+sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772815647; x=1773420447; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=tJzrziKqS66K8BTFV7yRFO0U3JoxSa5Zc+pCmKaMPzQ=; b=HN6YfYHqXkpVb4CbAMM6xDhzpi4Bgsp46mYeueWh4DL5h6PfUvdsZ4oKUrW2E70Fd+ 2S7PtnwXy04of5s2didzpzW09R4f74rjvNksEt2Rl+Iu8rRxCLZuLMW34jMJkZxJtd8x eumWZ+k14LGbdbSch4V+o7mcF6Z27oCtRhJDC9uNKhJ/+mPNYK18968Grjme2Q5ry0k7 X5MEYpkOfj+j/tOwcteymEW1Iq36EyoacfcfFK6ZBd29TDg0QvmfLijVqyCjSOqMxscc pzDMJPDOqb2Tl4UTzb527iyByktpfZSgZg/+ZBnO3GC/nVBUlpnVc0xUrG9e4sfEDCcM yKMA== X-Forwarded-Encrypted: i=1; AJvYcCVvPyyvkoiP7lsBk42IkwLuFhNlcHCQtzXy9jyINjhxjWCf+qqa0X74ElHnmVSkYbJNxSBBsvG8Wyw=@lists.freedesktop.org X-Gm-Message-State: AOJu0YwVb3RNEH3d3e29k40nxR7fndgaFooOE/TDZFWWZGl+YtdXYKTj U1qz2SmRsZRM4L6c7EqVm/qUM2IN5GWB+84bz+Ubj8P2FJFU0Vg36DHzkoqtIFwXOyKxMVbE5Ml 9gKI5ENKG4aCX72uoIslwB5uf1mma39UTaU/+g1Ybr9nmkgjJect9EjsnCRV4Nqjn97qZLLw= X-Gm-Gg: ATEYQzzEe567W/J/EL8YJlDHEYx6dlaGx7j0H/cHoLLhsZ+ao3xE28yMFtR0spPWzni uDRhM1wq8QJ5zsV0zhvl29ewU155kiw4pfoox32afOwiFIv+E7QE2lJuFSy8Dquau56uHbLIQKO qQRGZ+g+7iBZ+ruAv2HZErouSCiDrQjCdwZEjloGpzxsO3Y+qYaHiVk/ugH1ZpNLXUvyb+h5CZ1 MgdWsnkXWOZ1BqfPmyxokdsQk5wI2OmKAUnlejzVBIs+zoQrQrwi/5XM8APooGX1y3G1mIYIHEL fFaRBpluTw5mWzfqJbzC6XbLVGpnkVhrvJwgt3Ktn1T54nDSBGVkDq7sCp25/ApWsCJj9v99i3y nnvfo+9Uz3nk0nz8sEZqkvCKO5WQ/ijJgm8PfUjBmWpDzjFHkEt6ROydmkyPTzVOoVymgk89DaN Iu1RPWBXBkTbaniRDyDW9+9X6qI6q+qHsSjOY= X-Received: by 2002:a05:620a:2806:b0:8c7:9e6:3a72 with SMTP id af79cd13be357-8cd6d31f36emr346105685a.6.1772815646775; Fri, 06 Mar 2026 08:47:26 -0800 (PST) X-Received: by 2002:a05:620a:2806:b0:8c7:9e6:3a72 with SMTP id af79cd13be357-8cd6d31f36emr346101485a.6.1772815646235; Fri, 06 Mar 2026 08:47:26 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a13eaebd0asm213804e87.51.2026.03.06.08.47.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 08:47:25 -0800 (PST) From: Dmitry Baryshkov Date: Fri, 06 Mar 2026 18:47:13 +0200 Subject: [PATCH 07/24] drm/msm/mdss: use new helper to set min_acc length MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260306-ubwc-rework-v1-7-9cfdff12f2bb@oss.qualcomm.com> References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> In-Reply-To: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1420; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=jfhtlunzk9GwTp//Me1L6mf+GhU7QSZw7jcsDFdN4VI=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpqwUNlQJZkBObTPhQ9Zlm0bWm4Fh06JPeRJhSf /dUM7IqdyOJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaasFDQAKCRCLPIo+Aiko 1dqPB/43amVQBWWwwVe5xbDNn6w9ZozH9OsgFmzp4BgoeO0swcs8jgDuNpU2qDRl++Iw17k7dB3 PwRY0MLxk0C1p9uCnJgLUUHvOkVR5r04JLSOa8wVEhdtJ2TaX1ildgcrGv+gPHajDVq9pV4sgOK WlV1TjETXKWGnM1usLnGCVQey/xVtSn84DcYEaGi2sTnuBIuEzfu9p0/+7F0gZT+d1x9wKwy1QY DA7NNKqdL+Xglw+F0ZMuHcmhsHSJXnz+nVckTbbDpSNLwTdP1F7Aa/tIeiPdogDGArGGqAkvNhI nvXBFUiFTevcuEKfPkRDVLPU68kuiGJQgrEN621haTpd3THw X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDE1OSBTYWx0ZWRfXxNY8G9UX/EcW Kk1rRNLnKtmu2Jpz4eDWqrKAI2wbfZtRhMDYp1KAgrpUdFS8GxvudnGHT2DG6RVo+Uz3MPgtRq+ dEKJVdeO8MzKjLEKa9zGcWZ4IL16RDSSPOcKVCJD6m932jToHkqOw2HIuk9aUAFHQoBkjLf0D2H YrSVAoicbAalcYfTWWD0uoZN9NDZIztAic+SW7b5vbFS2rwRSQgACgjZ0xviWiNVTKGhgXYaytT NzswrU7ab/7Rvk8/vgZUIQoeiI6X1gKDquZBN83RLzWYJGzE3ghQPlbEOoAh/oNxnpMER1gbWp+ KUW31dTPx86/VBHTfuDC5uc1Y5qLdPtJtxY+RWBUtGIu/SjkC+ZUujwYvKKcxOFpOmy3ASq3ApC dWJAMfVu+Y6o2+0P103Fe5KbptVmT1EHC/+b5ufcPW8BCVpdQpp+XCbQswb2zsG+GzZ0YH7lKcv IWDKPi2umq4ubQ+lQog== X-Proofpoint-ORIG-GUID: 0ygfv4pRejSBWAoPjUP2v4TAqCsqB6IY X-Authority-Analysis: v=2.4 cv=DvZbOW/+ c=1 sm=1 tr=0 ts=69ab051f cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=X-e67srwgh_QgMMAbO4A:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-GUID: 0ygfv4pRejSBWAoPjUP2v4TAqCsqB6IY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_05,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 bulkscore=0 adultscore=0 suspectscore=0 clxscore=1015 phishscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060159 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Use freshly defined helper instead of hardcoding the checks in the driver. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 798a23fbc906..16bc9589f696 100644 --- a/drivers/gpu/drm/msm/msm_mdss.c +++ b/drivers/gpu/drm/msm/msm_mdss.c @@ -172,8 +172,7 @@ static void msm_mdss_setup_ubwc_v4(struct msm_mdss *msm_mdss) u32 value = MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle & 0x1) | MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); - if (data->ubwc_enc_version == UBWC_1_0) - value |= MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(1); + value |= MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(qcom_ubwc_min_acc_length_64b(data)); writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); } @@ -193,8 +192,7 @@ static void msm_mdss_setup_ubwc_v5(struct msm_mdss *msm_mdss) if (data->ubwc_enc_version == UBWC_3_0) value |= MDSS_UBWC_STATIC_UBWC_AMSBC; - if (data->ubwc_enc_version == UBWC_1_0) - value |= MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(1); + value |= MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(qcom_ubwc_min_acc_length_64b(data)); writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); } -- 2.47.3