[PATCH v2] docs/gpu: fix spelling mistakes in todo.rst

[PATCH v2] docs/gpu: fix spelling mistakes in todo.rst

[Mikael Rothig]

Signed-off-by: Mikael Rothig <mrrothig@gmail.com>
---
 Documentation/gpu/todo.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
index 520da44a04a6..686a94bead07 100644
--- a/Documentation/gpu/todo.rst
+++ b/Documentation/gpu/todo.rst
@@ -269,7 +269,7 @@ Various hold-ups:
   valid formats for atomic drivers.
 
 - Many drivers subclass drm_framebuffer, we'd need a embedding compatible
-  version of the varios drm_gem_fb_create functions. Maybe called
+  version of the various drm_gem_fb_create functions. Maybe called
   drm_gem_fb_create/_with_dirty/_with_funcs as needed.
 
 Contact: Simona Vetter
@@ -294,7 +294,7 @@ everything after it has done the write-protect/mkwrite trickery:
 
       vma->vm_page_prot = pgprot_wrprotect(vma->vm_page_prot);
 
-- Set the mkwrite and fsync callbacks with similar implementions to the core
+- Set the mkwrite and fsync callbacks with similar implementations to the core
   fbdev defio stuff. These should all work on plain ptes, they don't actually
   require a struct page.  uff. These should all work on plain ptes, they don't
   actually require a struct page.
@@ -882,7 +882,7 @@ Querying errors from drm_syncobj
 ================================
 
 The drm_syncobj container can be used by driver independent code to signal
-complection of submission.
+completion of submission.
 
 One minor feature still missing is a generic DRM IOCTL to query the error
 status of binary and timeline drm_syncobj.
-- 
2.49.0

Re: [PATCH v2] docs/gpu: fix spelling mistakes in todo.rst

[Randy Dunlap]

On 3/6/26 12:57 PM, Mikael Rothig wrote:
> Signed-off-by: Mikael Rothig <mrrothig@gmail.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

However:
a. There is no patch description in the email body.
   (see "The canonical patch format" in Documentation/process/submitting-patches.rst)
b. I would Cc: the appropriate maintainers as listed in the
   MAINTAINERS file:
   M:	David Airlie <airlied@gmail.com>
   M:	Simona Vetter <simona@ffwll.ch>

Thanks.

> ---
>  Documentation/gpu/todo.rst | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
> index 520da44a04a6..686a94bead07 100644
> --- a/Documentation/gpu/todo.rst
> +++ b/Documentation/gpu/todo.rst
> @@ -269,7 +269,7 @@ Various hold-ups:
>    valid formats for atomic drivers.
>  
>  - Many drivers subclass drm_framebuffer, we'd need a embedding compatible
> -  version of the varios drm_gem_fb_create functions. Maybe called
> +  version of the various drm_gem_fb_create functions. Maybe called
>    drm_gem_fb_create/_with_dirty/_with_funcs as needed.
>  
>  Contact: Simona Vetter
> @@ -294,7 +294,7 @@ everything after it has done the write-protect/mkwrite trickery:
>  
>        vma->vm_page_prot = pgprot_wrprotect(vma->vm_page_prot);
>  
> -- Set the mkwrite and fsync callbacks with similar implementions to the core
> +- Set the mkwrite and fsync callbacks with similar implementations to the core
>    fbdev defio stuff. These should all work on plain ptes, they don't actually
>    require a struct page.  uff. These should all work on plain ptes, they don't
>    actually require a struct page.
> @@ -882,7 +882,7 @@ Querying errors from drm_syncobj
>  ================================
>  
>  The drm_syncobj container can be used by driver independent code to signal
> -complection of submission.
> +completion of submission.
>  
>  One minor feature still missing is a generic DRM IOCTL to query the error
>  status of binary and timeline drm_syncobj.

-- 
~Randy

Claude review: Re: [PATCH v2] docs/gpu: fix spelling mistakes in todo.rst

[Claude Code Review Bot]

Overall Series Review

Subject: Re: [PATCH v2] docs/gpu: fix spelling mistakes in todo.rst
Author: Randy Dunlap <rdunlap@infradead.org>
Patches: 2
Reviewed: 2026-03-09T08:13:39.024304

---

This is a single documentation-only patch fixing three spelling mistakes in `Documentation/gpu/todo.rst`. The corrections are all valid: "varios" → "various", "implementions" → "implementations", and "complection" → "completion". The patch is trivially correct and low-risk.

However, there is one pre-existing issue in the file that the patch touches but does not fix, which is worth noting.

---
Generated by Claude Code Patch Reviewer

Claude review: Re: [PATCH v2] docs/gpu: fix spelling mistakes in todo.rst

[Claude Code Review Bot]

Patch Review

**Spelling fixes — all correct:**

1. Line 272: `varios` → `various` — correct fix.
2. Line 297: `implementions` → `implementations` — correct fix.
3. Line 885: `complection` → `completion` — correct fix.

**Issue: pre-existing duplicated text at the second hunk**

Looking at the context around the second fix (lines 297–300 in the tree):

```
- Set the mkwrite and fsync callbacks with similar implementions to the core
  fbdev defio stuff. These should all work on plain ptes, they don't actually
  require a struct page.  uff. These should all work on plain ptes, they don't
  actually require a struct page.
```

The sentence "These should all work on plain ptes, they don't actually require a struct page." appears to be duplicated, with what looks like a stray "uff." fragment between the copies. Since the patch is already touching this exact line, it would be a good opportunity to also fix this duplicated text. The author might consider cleaning that up in a follow-up or v3.

**Minor nit on the commit message:** The patch lacks a body/description. While for trivial spelling fixes this is common and acceptable, a one-line description like "Fix three spelling errors in the GPU TODO document" would be slightly more informative.

**Verdict:** The patch is correct as-is and suitable for merging. The duplicated text is a pre-existing issue and not a regression introduced by this patch.

---
Generated by Claude Code Patch Reviewer