[PATCH v2] dt-bindings: display: panel: Document the rotation property

[PATCH v2] dt-bindings: display: panel: Document the rotation property

[Luca Leonardo Scorcia]

The Jadard jd9365da-h3 driver already allows DRM to get the panel orientation
via the device tree rotation property (described in panel-common.yaml),
but it's currently not documented.
Describe it in the driver documentation to fix a dtbs_check error in
Xiaomi Mi Smart Clock x04g, where the panel is landscape-oriented.

Signed-off-by: Luca Leonardo Scorcia <l.scorcia@gmail.com>
---
v2: Review feedback: improved commit message to explain how the rotation
    property is used by the driver and why it's needed in the driver
    documentation.

 .../devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml  | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml b/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
index b8783eba3ddc..25024f4a63e1 100644
--- a/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
+++ b/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
@@ -33,9 +33,8 @@ properties:
     description: supply regulator for VCCIO, usually 1.8V
 
   reset-gpios: true
-
   backlight: true
-
+  rotation: true
   port: true
 
 required:
-- 
2.43.0

Re: [PATCH v2] dt-bindings: display: panel: Document the rotation property

[Krzysztof Kozlowski]

On Fri, Mar 06, 2026 at 12:44:21PM +0000, Luca Leonardo Scorcia wrote:
> The Jadard jd9365da-h3 driver already allows DRM to get the panel orientation

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

> via the device tree rotation property (described in panel-common.yaml),
> but it's currently not documented.
> Describe it in the driver documentation to fix a dtbs_check error in
> Xiaomi Mi Smart Clock x04g, where the panel is landscape-oriented.
> 
> Signed-off-by: Luca Leonardo Scorcia <l.scorcia@gmail.com>
> ---
> v2: Review feedback: improved commit message to explain how the rotation
>     property is used by the driver and why it's needed in the driver
>     documentation.
> 
>  .../devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml  | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

ONLY after these fixed:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

Claude review: dt-bindings: display: panel: Document the rotation property

[Claude Code Review Bot]

Overall Series Review

Subject: dt-bindings: display: panel: Document the rotation property
Author: Luca Leonardo Scorcia <l.scorcia@gmail.com>
Patches: 2
Reviewed: 2026-03-09T08:50:40.904203

---

This is a single, straightforward dt-bindings documentation fix. The Jadard jd9365da-h3 panel driver already parses the `rotation` property (via `of_drm_get_panel_orientation()` at line 1408 of `panel-jadard-jd9365da-h3.c`) and exposes it through `get_orientation`, but the YAML binding schema doesn't list `rotation` as an allowed property. This causes `dtbs_check` failures for any devicetree that sets `rotation` on this panel. The fix is correct and well-motivated.

The patch is **v2** and the commit message has been improved per review feedback to explain *why* the property is needed in the binding.

**Verdict: Looks good overall, with one minor formatting issue.**

---
Generated by Claude Code Patch Reviewer

Claude review: dt-bindings: display: panel: Document the rotation property

[Claude Code Review Bot]

Patch Review

**Correctness**: The addition of `rotation: true` is correct. Since this binding already does `allOf: - $ref: panel-common.yaml#`, specifying `rotation: true` allows the property and inherits its type/enum constraints from `panel-common.yaml` (which defines it as a `uint32` with `enum: [0, 90, 180, 270]`). This matches the pattern used for `backlight`, `port`, and `reset-gpios` in the same file.

**Formatting issue**: The patch inadvertently removes a blank line between `reset-gpios` and `backlight`:

```diff
   reset-gpios: true
-
   backlight: true
-
+  rotation: true
   port: true
```

The original file has blank lines separating each property entry for readability. The patch removes the blank line between `reset-gpios` and `backlight`, and also removes the blank line between `backlight` and `port` while inserting `rotation` there. The result would be:

```yaml
  reset-gpios: true
  backlight: true
  rotation: true
  port: true
```

This is a cosmetic style inconsistency compared to the rest of the properties block (which uses blank lines between `vdd-supply`, `vccio-supply`, `reset-gpios`, etc.). The `rotation: true` addition is fine, but the blank line removals appear unintentional and should be preserved. The patch should instead be:

```diff
   reset-gpios: true
 
   backlight: true
 
+  rotation: true
+
   port: true
```

**Minor**: It might be worth adding `rotation` to the example DT node to demonstrate its usage, though this is optional.

**Summary**: Functionally correct, solves a real `dtbs_check` regression. Recommend a respin just to preserve the blank-line formatting between property entries.

---
Generated by Claude Code Patch Reviewer