From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 303EEF513ED for ; Sat, 7 Mar 2026 15:05:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 52E0210E02C; Sat, 7 Mar 2026 15:05:16 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="p+u3PVQk"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0161C10E02C for ; Sat, 7 Mar 2026 15:05:14 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 957DF43FCE; Sat, 7 Mar 2026 15:05:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E24F9C19422; Sat, 7 Mar 2026 15:05:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772895914; bh=0hbBsl1lGdmRWPCfaDt1GzEaXdDJHOpPTiYFPKe55qs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p+u3PVQkYAROhrqZbLlUrMu9E9QCXmhSlwcpk8J1+R8IoIo7R6fdlG8LulK7OfNy0 XyH/m28DuIdXQPiH/VqTqTdSzPIMb+gHu/OaREJLnjRvFyb7ie9cAv2AWoSZWl4UjA fX9LxX0ojxuwyHG5odpeHnLfP6d9vEx/jvntfXVTD+kYjPuPwBAk+bHym4+mUkkYLC LT1SqbglXMD0s3/+NpeAz9K7Gxkz/PAxBWltJCT0cIos2QoiG4VUG3VN8/oNaeoq7j sLoAyU9ZuKarObDFqh1/hdeMxTTeqrZtu0BRmqQ5SiO6SbY5EhSlc0sOCD8MY7KLFS wE5bbz/e6LtoA== Date: Sat, 7 Mar 2026 16:05:12 +0100 From: Krzysztof Kozlowski To: Luca Leonardo Scorcia Cc: dri-devel@lists.freedesktop.org, Jagan Teki , Neil Armstrong , Jessica Zhang , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] dt-bindings: display: panel: Document the rotation property Message-ID: <20260307-dingo-of-nonconcrete-opportunity-ea70bd@quoll> References: <20260306124808.166776-1-l.scorcia@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260306124808.166776-1-l.scorcia@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Mar 06, 2026 at 12:44:21PM +0000, Luca Leonardo Scorcia wrote: > The Jadard jd9365da-h3 driver already allows DRM to get the panel orientation Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 Please run scripts/checkpatch.pl on the patches and fix reported warnings. After that, run also 'scripts/checkpatch.pl --strict' on the patches and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. > via the device tree rotation property (described in panel-common.yaml), > but it's currently not documented. > Describe it in the driver documentation to fix a dtbs_check error in > Xiaomi Mi Smart Clock x04g, where the panel is landscape-oriented. > > Signed-off-by: Luca Leonardo Scorcia > --- > v2: Review feedback: improved commit message to explain how the rotation > property is used by the driver and why it's needed in the driver > documentation. > > .../devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) ONLY after these fixed: Acked-by: Krzysztof Kozlowski Best regards, Krzysztof