From: vladimir.oltean@nxp.com
To: linux-phy@lists.infradead.org
Cc: Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-can@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-riscv@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev,
linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org,
netdev@vger.kernel.org, spacemit@lists.linux.dev,
UNGLinuxDriver@microchip.com,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Rob Clark <robin.clark@oss.qualcomm.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Jessica Zhang <jesszhan0024@gmail.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>
Subject: [PATCH v2 phy-next 11/24] drm/msm/dp: remove debugging prints with internal struct phy state
Date: Sun, 8 Mar 2026 13:39:56 +0200 [thread overview]
Message-ID: <20260308114009.2546587-12-vladimir.oltean@nxp.com> (raw)
In-Reply-To: <20260308114009.2546587-1-vladimir.oltean@nxp.com>
These do not provide much value, and will become hard to maintain once
the Generic PHY framework starts hiding the contents of struct phy from
consumers.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Acked-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
Cc: Rob Clark <robin.clark@oss.qualcomm.com>
Cc: Dmitry Baryshkov <lumag@kernel.org>
Cc: Abhinav Kumar <abhinav.kumar@linux.dev>
Cc: Jessica Zhang <jesszhan0024@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: Marijn Suijten <marijn.suijten@somainline.org>
Cc: David Airlie <airlied@gmail.com>
Cc: Simona Vetter <simona@ffwll.ch>
v1->v2: collect tag
---
drivers/gpu/drm/msm/dp/dp_ctrl.c | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c
index ef298c7d3e5e..cba8a71a2561 100644
--- a/drivers/gpu/drm/msm/dp/dp_ctrl.c
+++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c
@@ -1928,9 +1928,6 @@ void msm_dp_ctrl_phy_init(struct msm_dp_ctrl *msm_dp_ctrl)
msm_dp_ctrl_phy_reset(ctrl);
phy_init(phy);
-
- drm_dbg_dp(ctrl->drm_dev, "phy=%p init=%d power_on=%d\n",
- phy, phy->init_count, phy->power_count);
}
void msm_dp_ctrl_phy_exit(struct msm_dp_ctrl *msm_dp_ctrl)
@@ -1943,8 +1940,6 @@ void msm_dp_ctrl_phy_exit(struct msm_dp_ctrl *msm_dp_ctrl)
msm_dp_ctrl_phy_reset(ctrl);
phy_exit(phy);
- drm_dbg_dp(ctrl->drm_dev, "phy=%p init=%d power_on=%d\n",
- phy, phy->init_count, phy->power_count);
}
static int msm_dp_ctrl_reinitialize_mainlink(struct msm_dp_ctrl_private *ctrl)
@@ -1996,8 +1991,6 @@ static int msm_dp_ctrl_deinitialize_mainlink(struct msm_dp_ctrl_private *ctrl)
phy_exit(phy);
phy_init(phy);
- drm_dbg_dp(ctrl->drm_dev, "phy=%p init=%d power_on=%d\n",
- phy, phy->init_count, phy->power_count);
return 0;
}
@@ -2588,9 +2581,6 @@ void msm_dp_ctrl_off_link_stream(struct msm_dp_ctrl *msm_dp_ctrl)
/* aux channel down, reinit phy */
phy_exit(phy);
phy_init(phy);
-
- drm_dbg_dp(ctrl->drm_dev, "phy=%p init=%d power_on=%d\n",
- phy, phy->init_count, phy->power_count);
}
void msm_dp_ctrl_off_link(struct msm_dp_ctrl *msm_dp_ctrl)
@@ -2606,13 +2596,7 @@ void msm_dp_ctrl_off_link(struct msm_dp_ctrl *msm_dp_ctrl)
dev_pm_opp_set_rate(ctrl->dev, 0);
msm_dp_ctrl_link_clk_disable(&ctrl->msm_dp_ctrl);
- DRM_DEBUG_DP("Before, phy=%p init_count=%d power_on=%d\n",
- phy, phy->init_count, phy->power_count);
-
phy_power_off(phy);
-
- DRM_DEBUG_DP("After, phy=%p init_count=%d power_on=%d\n",
- phy, phy->init_count, phy->power_count);
}
void msm_dp_ctrl_off(struct msm_dp_ctrl *msm_dp_ctrl)
@@ -2638,8 +2622,6 @@ void msm_dp_ctrl_off(struct msm_dp_ctrl *msm_dp_ctrl)
msm_dp_ctrl_link_clk_disable(&ctrl->msm_dp_ctrl);
phy_power_off(phy);
- drm_dbg_dp(ctrl->drm_dev, "phy=%p init=%d power_on=%d\n",
- phy, phy->init_count, phy->power_count);
}
irqreturn_t msm_dp_ctrl_isr(struct msm_dp_ctrl *msm_dp_ctrl)
--
2.43.0
next prev parent reply other threads:[~2026-03-08 14:13 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-08 11:39 [PATCH v2 phy-next 00/24] Split Generic PHY consumer and provider API vladimir.oltean
2026-03-08 11:39 ` [PATCH v2 phy-next 01/24] ata: add <linux/pm_runtime.h> where missing vladimir.oltean
2026-03-08 11:39 ` [PATCH v2 phy-next 02/24] PCI: Add missing headers transitively included by <linux/phy/phy.h> vladimir.oltean
2026-03-08 11:39 ` [PATCH v2 phy-next 03/24] usb: add " vladimir.oltean
2026-03-08 11:39 ` [PATCH v2 phy-next 04/24] drm: add <linux/pm_runtime.h> where missing vladimir.oltean
2026-03-08 11:39 ` [PATCH v2 phy-next 05/24] phy: " vladimir.oltean
2026-03-08 11:39 ` [PATCH v2 phy-next 06/24] phy: spacemit: include missing <linux/phy/phy.h> vladimir.oltean
2026-03-08 11:39 ` [PATCH v2 phy-next 07/24] net: lan969x: include missing <linux/of.h> vladimir.oltean
2026-03-08 11:39 ` [PATCH v2 phy-next 08/24] PCI: Remove device links to PHY vladimir.oltean
2026-03-08 11:39 ` [PATCH v2 phy-next 09/24] ufs: exynos: stop poking into struct phy guts vladimir.oltean
2026-03-08 11:39 ` [PATCH v2 phy-next 10/24] drm/rockchip: dw_hdmi: avoid direct dereference of phy->dev.of_node vladimir.oltean
2026-03-08 11:39 ` vladimir.oltean [this message]
2026-03-08 11:39 ` [PATCH v2 phy-next 12/24] phy: move provider API out of public <linux/phy/phy.h> vladimir.oltean
2026-03-08 11:39 ` [PATCH v2 phy-next 13/24] phy: make phy_get_mode(), phy_(get|set)_bus_width() NULL tolerant vladimir.oltean
2026-03-08 11:39 ` [PATCH v2 phy-next 14/24] phy: introduce phy_get_max_link_rate() helper for consumers vladimir.oltean
2026-03-08 11:40 ` [PATCH v2 phy-next 15/24] drm/rockchip: dsi: include PHY provider header vladimir.oltean
2026-03-08 11:40 ` [PATCH v2 phy-next 16/24] drm: bridge: cdns-mhdp8546: use consumer API for getting PHY bus width vladimir.oltean
2026-03-08 11:40 ` [PATCH v2 phy-next 17/24] media: sunxi: a83-mips-csi2: include PHY provider header vladimir.oltean
2026-03-08 11:40 ` [PATCH v2 phy-next 18/24] net: renesas: rswitch: " vladimir.oltean
2026-03-08 11:40 ` [PATCH v2 phy-next 19/24] pinctrl: tegra-xusb: " vladimir.oltean
2026-03-08 11:40 ` [PATCH v2 phy-next 20/24] power: supply: cpcap-charger: include missing <linux/property.h> vladimir.oltean
2026-03-08 11:40 ` [PATCH v2 phy-next 21/24] phy: include PHY provider header (1/2) vladimir.oltean
2026-03-08 11:40 ` [PATCH v2 phy-next 22/24] phy: include PHY provider header (2/2) vladimir.oltean
2026-03-08 12:01 ` Russell King (Oracle)
2026-03-08 12:37 ` Vladimir Oltean
2026-03-08 11:40 ` [PATCH v2 phy-next 23/24] phy: remove temporary provider compatibility from consumer header vladimir.oltean
2026-03-08 11:40 ` [PATCH v2 phy-next 24/24] MAINTAINERS: add regexes for linux-phy vladimir.oltean
2026-03-08 18:40 ` Joe Perches
[not found] ` <20260308191017.kcyi7ka5pktq5jl4@skbuf>
2026-03-08 19:25 ` Joe Perches
2026-03-08 21:51 ` Claude review: Split Generic PHY consumer and provider API Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260308114009.2546587-12-vladimir.oltean@nxp.com \
--to=vladimir.oltean@nxp.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=neil.armstrong@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=spacemit@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox