[PATCH] drm/msm/dsi: add the missing parameter description

[PATCH] drm/msm/dsi: add the missing parameter description

[Pengyu Luo]

Add a description for is_bonded_dsi in dsi_adjust_pclk_for_compression
to match the existing kernel-doc comment.

Fixes: e4eb11b34d6c ("drm/msm/dsi: fix pclk rate calculation for bonded dsi")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202603080314.XeqyRZ7A-lkp@intel.com/
Signed-off-by: Pengyu Luo <mitltlatltl@gmail.com>
---
 drivers/gpu/drm/msm/dsi/dsi_host.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
index db6da99375..6cb634590e 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_host.c
+++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
@@ -569,6 +569,7 @@ void dsi_link_clk_disable_v2(struct msm_dsi_host *msm_host)
  * dsi_adjust_pclk_for_compression() - Adjust the pclk rate for compression case
  * @mode: The selected mode for the DSI output
  * @dsc: DRM DSC configuration for this DSI output
+ * @is_bonded_dsi: True if two DSI controllers are bonded
  *
  * Adjust the pclk rate by calculating a new hdisplay proportional to
  * the compression ratio such that:
-- 
2.53.0

Claude review: drm/msm/dsi: add the missing parameter description

[Claude Code Review Bot]

Overall Series Review

Subject: drm/msm/dsi: add the missing parameter description
Author: Pengyu Luo <mitltlatltl@gmail.com>
Patches: 1
Reviewed: 2026-03-10T12:27:21.024699

---

This is a single trivial documentation patch that adds a missing `@is_bonded_dsi` kernel-doc parameter description to the `dsi_adjust_pclk_for_compression()` function. The patch was prompted by a kernel test robot (kbuild bot) warning.

**However, the patch appears to be incorrect.** Looking at the actual function signature after the patch is applied (line 588-589 of `dsi_host.c`):

```c
static unsigned long dsi_adjust_pclk_for_compression(const struct drm_display_mode *mode,
		const struct drm_dsc_config *dsc)
```

The function only takes two parameters: `mode` and `dsc`. There is **no** `is_bonded_dsi` parameter on this function. The `is_bonded_dsi` parameter exists on the *caller* function `dsi_host_get_pclk_rate()` (used at line 615), not on `dsi_adjust_pclk_for_compression()`.

Adding a `@is_bonded_dsi` doc entry to the kernel-doc for `dsi_adjust_pclk_for_compression()` will **not** fix the warning — it will create a *new* warning about a documented parameter that doesn't exist in the function signature, while doing nothing about whatever the original kbuild warning actually was.

The referenced Fixes commit `e4eb11b34d6c ("drm/msm/dsi: fix pclk rate calculation for bonded dsi")` likely added `is_bonded_dsi` to `dsi_host_get_pclk_rate()` or similar, and the kbuild warning is probably about that function's kernel-doc, not `dsi_adjust_pclk_for_compression()`.

---
Generated by Claude Code Patch Reviewer

Claude review: drm/msm/dsi: add the missing parameter description

[Claude Code Review Bot]

Patch Review

**Result: Incorrect fix — NAK**

The patch adds:
```
+ * @is_bonded_dsi: True if two DSI controllers are bonded
```

to the kernel-doc comment for `dsi_adjust_pclk_for_compression()`, but this function's signature is:

```c
static unsigned long dsi_adjust_pclk_for_compression(
    const struct drm_display_mode *mode,
    const struct drm_dsc_config *dsc)
```

It has no `is_bonded_dsi` parameter. The author likely confused this function with `dsi_host_get_pclk_rate()` which does use `is_bonded_dsi` (at line 615). The `@is_bonded_dsi` doc entry should be added to whichever function actually has that parameter, not here.

This patch as written would trade one kernel-doc warning for another (excess `@is_bonded_dsi` description with no matching parameter).

---
Generated by Claude Code Patch Reviewer