From: Boris Brezillon <boris.brezillon@collabora.com>
To: Christian König <christian.koenig@amd.com>
Cc: Steven Price <steven.price@arm.com>,
Liviu Dudau <liviu.dudau@arm.com>,
Adrián Larumbe <adrian.larumbe@collabora.com>,
dri-devel@lists.freedesktop.org, kernel@collabora.com,
Nicolas Frattaroli <nicolas.frattaroli@collabora.com>,
Tvrtko Ursulin <tvrtko.ursulin@igalia.com>,
Philipp Stanner <phasta@kernel.org>
Subject: Re: [PATCH] drm/panthor: Fix the "done_fence is initialized" detection logic
Date: Mon, 9 Mar 2026 12:06:56 +0100 [thread overview]
Message-ID: <20260309120656.5821431e@fedora> (raw)
In-Reply-To: <bd0bcaeb-0a0f-4415-b964-ea1d5219b671@amd.com>
On Mon, 9 Mar 2026 11:50:16 +0100
Christian König <christian.koenig@amd.com> wrote:
> On 3/9/26 11:30, Boris Brezillon wrote:
> > After commit 541c8f2468b9 ("dma-buf: detach fence ops on signal
> > v3"), dma_fence::ops == NULL can't be used to check if the fence is
> > initialized or not. We could turn this into an "is_signaled() ||
> > ops == NULL" test, but that's fragile, since it's still subject to
> > dma_fence internal changes. So let's have the "is_initialized"
> > state encoded directly in the pointer through the lowest bit which
> > is guaranteed to be unused because of the dma_fence alignment
> > constraint.
>
> We added the dma_fence_was_initialized() function exactly for this
> use case and fixed all callers.
Oh, I somehow missed that helper. Will respin. Thanks!
next prev parent reply other threads:[~2026-03-09 11:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 10:30 [PATCH] drm/panthor: Fix the "done_fence is initialized" detection logic Boris Brezillon
2026-03-09 10:50 ` Christian König
2026-03-09 11:06 ` Boris Brezillon [this message]
2026-03-09 11:05 ` Liviu Dudau
2026-03-09 13:15 ` Boris Brezillon
2026-03-09 14:54 ` Liviu Dudau
2026-03-09 15:32 ` Boris Brezillon
2026-03-09 11:06 ` Nicolas Frattaroli
2026-03-10 2:25 ` Claude review: " Claude Code Review Bot
2026-03-10 2:25 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260309120656.5821431e@fedora \
--to=boris.brezillon@collabora.com \
--cc=adrian.larumbe@collabora.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@collabora.com \
--cc=liviu.dudau@arm.com \
--cc=nicolas.frattaroli@collabora.com \
--cc=phasta@kernel.org \
--cc=steven.price@arm.com \
--cc=tvrtko.ursulin@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox