From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50A62F41808 for ; Mon, 9 Mar 2026 15:11:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A092710E531; Mon, 9 Mar 2026 15:11:35 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="ihv0LRh+"; dkim-atps=neutral Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id CF16510E531 for ; Mon, 9 Mar 2026 15:11:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1773069091; bh=z5a5ytugvmQd2nEz5UH1pHiejCj57oWa0E71OmU++OM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ihv0LRh+sGPb1iDj3QkfBAxfYiZygMy/dGE+ERf9oeEXmJyiKwx2M4I66ta0JsufA Etfp1Q8wkksmUM5PLH2UlrJygML45Caq92s+ucPS2ZMrmshZ198iOCFacM+7XgSCUw 1bSRO09EFp5JzzPJwlm8pDPU8gPIXGn77hdUx8vFjv41qESGykvk63TsmJe90t1xgr p7QP9mIb3biMDHGJANFjKip8JtDQ8IsgLaCdOLQ9LfOze4eYDbd9/q6qvUgCwMpcMh uMmoWDlzyvyut7FxKIHbfuAhTvD+ZoLuHs5tc1xOeZBQ9ncaK8f23h+nXb2/g+XDt8 KxCpg/i7ytXtw== Received: from fedora (unknown [IPv6:2a01:e0a:2c:6930:a2a7:f53:ebb0:945e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id D30EA17E12D5; Mon, 9 Mar 2026 16:11:30 +0100 (CET) From: Boris Brezillon To: Boris Brezillon , Steven Price , Liviu Dudau , =?UTF-8?q?Adri=C3=A1n=20Larumbe?= Cc: dri-devel@lists.freedesktop.org, David Airlie , Simona Vetter , Akash Goel , Rob Clark , Sean Paul , Konrad Dybcio , Akhil P Oommen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Dmitry Osipenko , Chris Diamand , Danilo Krummrich , Matthew Brost , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= , Alice Ryhl , Chia-I Wu , kernel@collabora.com Subject: [PATCH v5 2/9] drm/panthor: Move panthor_gems_debugfs_init() to panthor_gem.c Date: Mon, 9 Mar 2026 16:11:12 +0100 Message-ID: <20260309151119.290217-3-boris.brezillon@collabora.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260309151119.290217-1-boris.brezillon@collabora.com> References: <20260309151119.290217-1-boris.brezillon@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" There's no reason for panthor_drv to know about panthor_gem.c internals, so let's move the GEM debugfs init logic to panthor_gem.c. v2: - Collect R-bs v3: -No changes v4: - No changes v5: - No changes Signed-off-by: Boris Brezillon Reviewed-by: Liviu Dudau Reviewed-by: Steven Price --- drivers/gpu/drm/panthor/panthor_drv.c | 26 +----------------------- drivers/gpu/drm/panthor/panthor_gem.c | 29 +++++++++++++++++++++++++-- drivers/gpu/drm/panthor/panthor_gem.h | 3 +-- 3 files changed, 29 insertions(+), 29 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c index 1bcec6a2e3e0..c77190bb357c 100644 --- a/drivers/gpu/drm/panthor/panthor_drv.c +++ b/drivers/gpu/drm/panthor/panthor_drv.c @@ -1635,34 +1635,10 @@ static const struct file_operations panthor_drm_driver_fops = { }; #ifdef CONFIG_DEBUG_FS -static int panthor_gems_show(struct seq_file *m, void *data) -{ - struct drm_info_node *node = m->private; - struct drm_device *dev = node->minor->dev; - struct panthor_device *ptdev = container_of(dev, struct panthor_device, base); - - panthor_gem_debugfs_print_bos(ptdev, m); - - return 0; -} - -static struct drm_info_list panthor_debugfs_list[] = { - {"gems", panthor_gems_show, 0, NULL}, -}; - -static int panthor_gems_debugfs_init(struct drm_minor *minor) -{ - drm_debugfs_create_files(panthor_debugfs_list, - ARRAY_SIZE(panthor_debugfs_list), - minor->debugfs_root, minor); - - return 0; -} - static void panthor_debugfs_init(struct drm_minor *minor) { panthor_mmu_debugfs_init(minor); - panthor_gems_debugfs_init(minor); + panthor_gem_debugfs_init(minor); } #endif diff --git a/drivers/gpu/drm/panthor/panthor_gem.c b/drivers/gpu/drm/panthor/panthor_gem.c index 6d14b0269574..c7b8b84a8f8b 100644 --- a/drivers/gpu/drm/panthor/panthor_gem.c +++ b/drivers/gpu/drm/panthor/panthor_gem.c @@ -9,6 +9,8 @@ #include #include +#include +#include #include #include @@ -683,8 +685,8 @@ static void panthor_gem_debugfs_bo_print(struct panthor_gem_object *bo, totals->reclaimable += resident_size; } -void panthor_gem_debugfs_print_bos(struct panthor_device *ptdev, - struct seq_file *m) +static void panthor_gem_debugfs_print_bos(struct panthor_device *ptdev, + struct seq_file *m) { struct gem_size_totals totals = {0}; struct panthor_gem_object *bo; @@ -704,4 +706,27 @@ void panthor_gem_debugfs_print_bos(struct panthor_device *ptdev, seq_printf(m, "Total size: %zd, Total resident: %zd, Total reclaimable: %zd\n", totals.size, totals.resident, totals.reclaimable); } + +static int panthor_gem_show_bos(struct seq_file *m, void *data) +{ + struct drm_info_node *node = m->private; + struct drm_device *dev = node->minor->dev; + struct panthor_device *ptdev = + container_of(dev, struct panthor_device, base); + + panthor_gem_debugfs_print_bos(ptdev, m); + + return 0; +} + +static struct drm_info_list panthor_gem_debugfs_list[] = { + { "gems", panthor_gem_show_bos, 0, NULL }, +}; + +void panthor_gem_debugfs_init(struct drm_minor *minor) +{ + drm_debugfs_create_files(panthor_gem_debugfs_list, + ARRAY_SIZE(panthor_gem_debugfs_list), + minor->debugfs_root, minor); +} #endif diff --git a/drivers/gpu/drm/panthor/panthor_gem.h b/drivers/gpu/drm/panthor/panthor_gem.h index 22519c570b5a..94b2d17cf032 100644 --- a/drivers/gpu/drm/panthor/panthor_gem.h +++ b/drivers/gpu/drm/panthor/panthor_gem.h @@ -203,8 +203,7 @@ panthor_kernel_bo_create(struct panthor_device *ptdev, struct panthor_vm *vm, void panthor_kernel_bo_destroy(struct panthor_kernel_bo *bo); #ifdef CONFIG_DEBUG_FS -void panthor_gem_debugfs_print_bos(struct panthor_device *pfdev, - struct seq_file *m); +void panthor_gem_debugfs_init(struct drm_minor *minor); #endif #endif /* __PANTHOR_GEM_H__ */ -- 2.53.0