[PATCH v3] dt-bindings: display: panel: Document the rotation property

[PATCH v3] dt-bindings: display: panel: Document the rotation property

[Luca Leonardo Scorcia]

The Jadard jd9365da-h3 driver already allows DRM to get the panel
orientation via the device tree rotation property (described in
panel-common.yaml), but it's currently not documented.
Describe it in the driver documentation to fix a dtbs_check error in
Xiaomi Mi Smart Clock x04g, where the panel is landscape-oriented.

Signed-off-by: Luca Leonardo Scorcia <l.scorcia@gmail.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
v3: Fixed commit message wrapping
v2: Review feedback: improved commit message to explain how the rotation
    property is used by the driver and why it's needed in the driver
    documentation.

 .../devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml  | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml b/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
index b8783eba3ddc..25024f4a63e1 100644
--- a/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
+++ b/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
@@ -33,9 +33,8 @@ properties:
     description: supply regulator for VCCIO, usually 1.8V
 
   reset-gpios: true
-
   backlight: true
-
+  rotation: true
   port: true
 
 required:
-- 
2.43.0

Claude review: dt-bindings: display: panel: Document the rotation property

[Claude Code Review Bot]

Overall Series Review

Subject: dt-bindings: display: panel: Document the rotation property
Author: Luca Leonardo Scorcia <l.scorcia@gmail.com>
Patches: 1
Reviewed: 2026-03-10T12:03:47.273946

---

This is a single, straightforward device tree bindings patch (v3) that adds the `rotation` property to the Jadard JD9365DA-H3 panel binding. The change is correct, well-motivated, and already carries an Acked-by from a DT maintainer (Krzysztof Kozlowski). No issues found.

---
Generated by Claude Code Patch Reviewer

Claude review: dt-bindings: display: panel: Document the rotation property

[Claude Code Review Bot]

Patch Review

**Purpose:** The Jadard jd9365da-h3 panel driver already reads the `rotation` property from DT (via `panel-common.yaml` / `of_drm_get_panel_orientation`), but the binding schema didn't list it. This causes `dtbs_check` warnings for boards like the Xiaomi Mi Smart Clock x04g that use the property.

**Review:**

The change is correct. The binding already references `panel-common.yaml` via `allOf`:

```yaml
allOf:
  - $ref: panel-common.yaml#
```

And the file has `additionalProperties: false` (line 49), which means any property not explicitly listed is flagged as an error by `dt-validate`. Adding `rotation: true` delegates the schema validation to the referenced `panel-common.yaml`, which properly constrains rotation values to `{0, 90, 180, 270}`.

**Minor nit:** The patch removes a blank line between `reset-gpios` and `backlight` (lines 121-123 of the diff). This is a cosmetic whitespace change that wasn't mentioned in the commit message. It doesn't matter functionally, but mixing unrelated whitespace changes with the actual fix is slightly untidy. That said, given how trivial this is, it's not worth re-spinning.

**Verdict:** Patch looks good. The commit message clearly explains the what and why, the Acked-by is present, and the change itself is minimal and correct.

Reviewed-by quality: **Accept as-is.**

---
Generated by Claude Code Patch Reviewer