From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1868FD4F04 for ; Tue, 10 Mar 2026 16:07:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 19F5F10E75B; Tue, 10 Mar 2026 16:07:40 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="PO4CUllf"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 923EA10E75B for ; Tue, 10 Mar 2026 16:07:38 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 7818740119; Tue, 10 Mar 2026 16:07:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F3AA2C19423; Tue, 10 Mar 2026 16:07:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773158858; bh=0NCrUYiDXTVQ3wJ3wTIEbkD/aAsEjfCXUe8n9jnE9ik=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=PO4CUllfUHE/ztReyFTdk5126NLtBfGijLff5Nb49Diy8OECQp1+Xu3ySkcUrxIOO i1ODzVi4KDWo3/hcZaz5ZQHKPOiR2TRNRGVziqRBPYe79Vi1ZjFTNy4J+3wkS1VjwL GT4cw1WbRodE7VXhyFd96Gyhaxx5rsOkDK43WFIMzUd82FLelWn5CChNTSaS9VYNCn j4zG4MrjKk3SdTeJRDP0V83V9J0Bt2Y4+ydd+7JAIphVYbYN8/PkIe8ReStqnT0JWO UPU5B3lg/vrWOekaLNAvPqxUF49vDzFxpEMEt9s4rDNUe86gGQbO85eJwSLEkCE4IT QCJkiBaS7S7OQ== From: Maxime Ripard Date: Tue, 10 Mar 2026 17:07:02 +0100 Subject: [PATCH 10/14] drm/atomic: Drop private obj state allocation MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260310-drm-mode-config-init-v1-10-de7397c8e1cf@kernel.org> References: <20260310-drm-mode-config-init-v1-0-de7397c8e1cf@kernel.org> In-Reply-To: <20260310-drm-mode-config-init-v1-0-de7397c8e1cf@kernel.org> To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Shuah Khan , Dmitry Baryshkov , Jyri Sarha , Tomi Valkeinen , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec Cc: dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Maxime Ripard X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1376; i=mripard@kernel.org; h=from:subject:message-id; bh=0NCrUYiDXTVQ3wJ3wTIEbkD/aAsEjfCXUe8n9jnE9ik=; b=owGbwMvMwCmsHn9OcpHtvjLG02pJDJkbHFcUifcdOHxAzsv338UFy732PV/SdjsvwJdxs35jw PuNbCKsHVNZGIQ5GWTFFFmeyISdXt6+uMrBfuUPmDmsTCBDGLg4BWAiuq6MtRIFQZlBhu6nOWaJ V+9SlDn/dMlb1oYbdzjCnuhE2ZrNl2VUiHf6vvDuiatJK/wXRy48z1jFvDrjdLXDlxkbukp/Rcy Puey1ef8m+SXf32ywbVPxK3hrmfTsVqerh1HdxU1p3sWP3SQB X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Now that drm_dev_register() calls drm_mode_config_create_state() for every modeset driver, the private obj states will be initialized at driver registration automatically if they haven't already. Thus, the explicit initial allocation we have in drm_atomic_private_obj_init() is now redundant, and we can remove it. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_atomic.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index d1885f895cce78725419b6291f4dbe5563e3b240..e8dc019364d27123c3a682a10323fba9ff76f9df 100644 --- a/drivers/gpu/drm/drm_atomic.c +++ b/drivers/gpu/drm/drm_atomic.c @@ -991,25 +991,18 @@ static void drm_atomic_plane_print_state(struct drm_printer *p, */ int drm_atomic_private_obj_init(struct drm_device *dev, struct drm_private_obj *obj, const struct drm_private_state_funcs *funcs) { - struct drm_private_state *state; memset(obj, 0, sizeof(*obj)); drm_modeset_lock_init(&obj->lock); obj->dev = dev; obj->funcs = funcs; list_add_tail(&obj->head, &dev->mode_config.privobj_list); - state = obj->funcs->atomic_create_state(obj); - if (IS_ERR(state)) - return PTR_ERR(state); - - obj->state = state; - return 0; } EXPORT_SYMBOL(drm_atomic_private_obj_init); /** -- 2.53.0