From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F80FFD4F02 for ; Tue, 10 Mar 2026 16:07:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D861D10E717; Tue, 10 Mar 2026 16:07:16 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="Yna6ypOK"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1F47610E717 for ; Tue, 10 Mar 2026 16:07:16 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 302ED60127; Tue, 10 Mar 2026 16:07:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1EF7C19425; Tue, 10 Mar 2026 16:07:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773158835; bh=50Fbqi2VnTgdkuk+BUDOfNFbw8A7u/ctiLVkwrOd0Js=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Yna6ypOKP2w9ugdKDmwmMj1Nbt5JRRXejloG5crfwbiFKquek67b5ZyB6ZMQBrKLI Kry4nsKTCkN2Zpab26y+OevAtN6m3d4BsLr4U+wJWG2rXz2rB8sEfm4TuUXZjbCQUZ vCY7CiyFgLl5opgUf1UFycPCNUYD3EycN6LgYj9tMUO+iOiPVd9ZkNdVk1v/1oBmz9 XwbAHFDISwM+XB/9GYt4kAaDvX7OhDCVJ2VYW3Fx42pc1re2s16ljZL4xiQ07qhZNI DNEDtR8ZK/s6I01k4ZAfSh6dIqbXTc/jUlaE2JhcFWTZvODveDCgrJYF/a+WrtUuHX CFwjbh4QQxcFg== From: Maxime Ripard Date: Tue, 10 Mar 2026 17:06:54 +0100 Subject: [PATCH 02/14] drm/atomic: Drop drm_private_state.obj assignment from create_state MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260310-drm-mode-config-init-v1-2-de7397c8e1cf@kernel.org> References: <20260310-drm-mode-config-init-v1-0-de7397c8e1cf@kernel.org> In-Reply-To: <20260310-drm-mode-config-init-v1-0-de7397c8e1cf@kernel.org> To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Shuah Khan , Dmitry Baryshkov , Jyri Sarha , Tomi Valkeinen , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec Cc: dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Maxime Ripard X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1530; i=mripard@kernel.org; h=from:subject:message-id; bh=50Fbqi2VnTgdkuk+BUDOfNFbw8A7u/ctiLVkwrOd0Js=; b=owGbwMvMwCmsHn9OcpHtvjLG02pJDJkbHJecqfD3UWGL2S8c/Xye2VuNVhbxDP+Gikc6vZlLl YLmPefvmMrCIMzJICumyPJEJuz08vbFVQ72K3/AzGFlAhnCwMUpABNJDWasYp63I2w56+Z+vaLL r/6oMBo/say/7Om8v6Swz+Wdy7G9DYZCsV5piQVVT0N1Wl84ce1grFNUav2xYN2G1a8O6xm8Xpi m9er9vspLfmsufZNcof+0XvCD4I3Any7rZkhKMTtduXNftxIA X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The initial intent of the atomic_create_state helper was to simply allocate a proper drm_private_state and returning it, without any side effect. However, the __drm_atomic_helper_private_obj_create_state() introduces a side effect by setting the drm_private_obj.state to the newly allocated state. This assignment defeats the purpose, but is also redundant since the only caller, drm_atomic_private_obj_init(), will also set this pointer to the newly allocated state. Let's drop the assignment in __drm_atomic_helper_private_obj_create_state(). Fixes: e7be39ed1716 ("drm/atomic-helper: Add private_obj atomic_create_state helper") Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_atomic_state_helper.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_state_helper.c b/drivers/gpu/drm/drm_atomic_state_helper.c index bd6faa09f83b498b1417869493f31d876cd13914..323abc9926e084ad595768c06d5c5ee28c22c014 100644 --- a/drivers/gpu/drm/drm_atomic_state_helper.c +++ b/drivers/gpu/drm/drm_atomic_state_helper.c @@ -728,12 +728,10 @@ EXPORT_SYMBOL(drm_atomic_helper_connector_destroy_state); void __drm_atomic_helper_private_obj_create_state(struct drm_private_obj *obj, struct drm_private_state *state) { if (state) state->obj = obj; - - obj->state = state; } EXPORT_SYMBOL(__drm_atomic_helper_private_obj_create_state); /** * __drm_atomic_helper_private_obj_duplicate_state - copy atomic private state -- 2.53.0