From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7729FD2D88 for ; Tue, 10 Mar 2026 11:57:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6666310E6EE; Tue, 10 Mar 2026 11:57:48 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=lankhorst.se header.i=@lankhorst.se header.b="OXTIUA5T"; dkim-atps=neutral Received: from lankhorst.se (unknown [141.105.120.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3C65F10E6CC; Tue, 10 Mar 2026 11:57:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lankhorst.se; s=default; t=1773143859; bh=dWlyZ+nzXkTj179ReweZJJwlq8+QsUSPlvN3YLSeioA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OXTIUA5TqHDBu06AhyzL2kajGWCUqKWgXeX8Mn9loxq33wz0zlL6ATBM7REj9nS5K GHYoXj4Suna6zVvpppYF7Biq4wMlOAQtUgzDfuWuJErd5Vz2ehNQNqhMC6iwsYptt9 e2ZC/btHhWogOZK6PVKxGMGvjmI3JLeozzE/fdu8r4BdQsrI6bfq0nYu82ERqAvVZ4 mbn5c/09kRNCCSutS9jat4AtXzKLVHu5chFkBNvtCNplnAL+wjgPws2YKGG0T1kQpP 5Bve8VJTIn9EAbc54Skbqx3mFgLYqpiRl8RqshXsY6bdGRy7koLnJ5QsZ9s2/t2TM4 OKQyKuuPlt0eA== From: Maarten Lankhorst To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org, Sebastian Andrzej Siewior , Maarten Lankhorst , Tvrtko Ursulin , Maarten Lankhorst Subject: [PATCH v7 17/26] drm/i915: Drop the irqs_disabled() check Date: Tue, 10 Mar 2026 12:56:59 +0100 Message-ID: <20260310115709.2276203-18-dev@lankhorst.se> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260310115709.2276203-1-dev@lankhorst.se> References: <20260310115709.2276203-1-dev@lankhorst.se> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Sebastian Andrzej Siewior The !irqs_disabled() check triggers on PREEMPT_RT even with i915_sched_engine::lock acquired. The reason is the lock is transformed into a sleeping lock on PREEMPT_RT and does not disable interrupts. There is no need to check for disabled interrupts. The lockdep annotation below already check if the lock has been acquired by the caller and will yell if the interrupts are not disabled. Remove the !irqs_disabled() check. Reported-by: Maarten Lankhorst Acked-by: Tvrtko Ursulin Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/i915_request.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c index d2c7b1090df08..f66f8efc70629 100644 --- a/drivers/gpu/drm/i915/i915_request.c +++ b/drivers/gpu/drm/i915/i915_request.c @@ -610,7 +610,6 @@ bool __i915_request_submit(struct i915_request *request) RQ_TRACE(request, "\n"); - GEM_BUG_ON(!irqs_disabled()); lockdep_assert_held(&engine->sched_engine->lock); /* @@ -719,7 +718,6 @@ void __i915_request_unsubmit(struct i915_request *request) */ RQ_TRACE(request, "\n"); - GEM_BUG_ON(!irqs_disabled()); lockdep_assert_held(&engine->sched_engine->lock); /* -- 2.51.0