From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2350FD2D7C for ; Tue, 10 Mar 2026 11:57:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9491810E6E8; Tue, 10 Mar 2026 11:57:47 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=lankhorst.se header.i=@lankhorst.se header.b="DcM0GUk7"; dkim-atps=neutral Received: from lankhorst.se (unknown [141.105.120.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6D0C510E6D9; Tue, 10 Mar 2026 11:57:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lankhorst.se; s=default; t=1773143862; bh=dgU9NxaeCYzOSvvL/Rn9LO0Bo2PGBMD2TB4KIygXVt8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DcM0GUk74a88eEIzf8dSJzNqOIuxBZf1aRg4b3wtiIIXjNxYgRpI9vss2+FYRJiYb 6fPvVV5ozWG/nhSlXt8Mu/a1Nz+0MWv7uOLbCxk7vznuFk0YJCF/XlWnxOCrR82i+q tJs8tAXHJ3LBKelQT96zH0GCjnTSJhOPwgBjMkS5eyInBNT3N5GTjTtmUiy2ePe5rB 4dF5kTWIjWEHQyFuRveCEnf/oU1gs/NboXTmK2BA5gqdLNk9PALuMWp2zFGlF6KSsH PI+5RDhoqsP3CL+ItD12XibE3xgQXDdHeOCUwlG4BR4hPwRblXAXx7PGKgL3KsZnIX KmibJMSN67+Hw== From: Maarten Lankhorst To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org, Maarten Lankhorst Subject: [PATCH v7 21/26] drm/i915/display: Remove uncore lock from vlv_atomic_update_fifo Date: Tue, 10 Mar 2026 12:57:03 +0100 Message-ID: <20260310115709.2276203-22-dev@lankhorst.se> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260310115709.2276203-1-dev@lankhorst.se> References: <20260310115709.2276203-1-dev@lankhorst.se> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" TODO: Grab uncore lock during entire vblank evasion before disabling interrupts, and check what breaks? Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/i9xx_wm.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/i9xx_wm.c b/drivers/gpu/drm/i915/display/i9xx_wm.c index 9e170e79dcf67..8e1b3aced9a98 100644 --- a/drivers/gpu/drm/i915/display/i9xx_wm.c +++ b/drivers/gpu/drm/i915/display/i9xx_wm.c @@ -1863,7 +1863,6 @@ static void vlv_atomic_update_fifo(struct intel_atomic_state *state, struct intel_crtc *crtc) { struct intel_display *display = to_intel_display(crtc); - struct intel_uncore *uncore = to_intel_uncore(display->drm); const struct intel_crtc_state *crtc_state = intel_atomic_get_new_crtc_state(state, crtc); const struct vlv_fifo_state *fifo_state = @@ -1892,7 +1891,6 @@ static void vlv_atomic_update_fifo(struct intel_atomic_state *state, * intel_pipe_update_start() has already disabled interrupts * for us, so a plain spin_lock() is sufficient here. */ - spin_lock(&uncore->lock); switch (crtc->pipe) { case PIPE_A: @@ -1951,8 +1949,6 @@ static void vlv_atomic_update_fifo(struct intel_atomic_state *state, } intel_de_read_fw(display, DSPARB(display)); - - spin_unlock(&uncore->lock); } #undef VLV_FIFO -- 2.51.0