From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4CF7112588E for ; Wed, 11 Mar 2026 20:17:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0841B10E921; Wed, 11 Mar 2026 20:17:48 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="KCWqWiOE"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KWW03oUs"; dkim-atps=neutral Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7AB3010E916 for ; Wed, 11 Mar 2026 20:17:41 +0000 (UTC) Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62BGc1mT294464 for ; Wed, 11 Mar 2026 20:17:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IctiJKzFga8uaoriJYS2d7YQbSXoOC3YlhoWAOwIcBE=; b=KCWqWiOEJeY3hadC wS62c8gJ0nsvyWJ6BVuAEso34vcsVKmHkW899r2bacf6o0gkZrlAfXG1sYvXbAyW ZlxDW4ewUlMDDQz/NJUuKrT1OCxxLXziQju1Am3z0o9Ib3/+kcnVtOhCRmhtmjjn luuuV8V8Iqi4sn+NwBHiU2sA6H9ZLYWwNdsB+XtpBWZJ6iv528dmXTGJdt745pgI eo12qkxEKQwRvlbuKzIpzox29y7GE2dQDjR/dTgqaoT8b7yipGVfqSlgfxIrnA1g HuG9J+pmwBhRI7nTY+NYwmoqRib0CisbN7LoEIc+d1Fjy/2ZWDvpOWaKrULBtyHr 0rtbSQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cu6bba4sf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2026 20:17:40 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cd98d96382so40851185a.0 for ; Wed, 11 Mar 2026 13:17:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773260260; x=1773865060; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IctiJKzFga8uaoriJYS2d7YQbSXoOC3YlhoWAOwIcBE=; b=KWW03oUssotEzAKypXCYRHBsU/kHxrDvRgHtikqYeIwpU2yUQvsQ6aVS+WQ7NP2pd/ stXwbQBRZ1uDdiLZr/a0MOWFODByGsJPCPufCGeukhzE3vwXqcT+aDtK4+2oPUYIlRbZ EcIZkcSqVa+U9Qm69vko2xIxqxQBeih78U0qSTY5+FbDfoXCkerzR4iMpmT87Lpu4EO8 XItc0trNh9bp5SOaNLtQ2jGWeJF/J3F3FbzMpsMexVCEDE1Hs8ok/cL9noelNvRv73qD J/tYfO1MHtXfVwgZXa6YOworN55J3n8BmgqOFv66PglOTBdJN3IJSThCdx+XuG3cWnW/ +Vlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773260260; x=1773865060; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=IctiJKzFga8uaoriJYS2d7YQbSXoOC3YlhoWAOwIcBE=; b=WGh/48XkJj9wL7O/h5IRDS3dDY9PCQF8fvZ4e6mFdFMSAeZ0mv/9BzQmPjjGGLh12g O3UmaaAfe1TnWNe14EfmmXdCzSlUONbC1OJqzw77xJrQhrF34CffglmgAgI2OPrkWtFV CuMjOcUM2QJlHAssbHQoprnzyuufe3rGvtRV8wAsd/GndvfuV59dyRVkwhUb/D+ZpsVJ cVTKmgeDPIX5+dsSkr8ftXaBy5s7t79hkNObAHe2fGiLBKJL5Zcm7ZAT7dqPk2QkTV2P uk3G2lGSJ9k/XxlJERyBAcSsmNQpZ6K945h8hyWwPUgav/7T1QtHpTyV80ylOKdKn4Pp ft3Q== X-Forwarded-Encrypted: i=1; AJvYcCUDMjcWW55DWqM2WkY8V9kNkzinmsRPcOA2vs2lxhvVuh/jwm1z7Cdw6gnwbTKTcX0/YcPZP5rSpyw=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yw5v2+iz3JZGQD2WVqXdLKNXGiB5j+P3lwD4uD7Vuyg2YmZ3Mqv Ez5q1/UJ+7TGkyuQKmC21ic6dz/PJs/i/In6mxYckBFTTdUWcptda1BByDzOS/hkX4Qdm+05l42 u6Ib6/x3nEwlVjn6v+K5oBv//Itjd4DDDs9AxSGeaE1G95v4DzQ4KzTWflGQIRs6eTRTw9gc= X-Gm-Gg: ATEYQzy74+/Db55SGcg9aCh/rd7O5c9k9u0DYFJEOKX9ZDwGiWWUmgJZTX6G0pLXAGW tUdjysSNDdi/yOXkAzo5HyxpNbYSiC6GnqSMjAZL/1ZRmaJ8u+e1G7aTeRn9EzBryDEPHEiwcg0 7Zvx4NXwhuUwrrv1i1ndIp6j+JUhYQUmWcDY45SdCnV5JNBye41+R3Zlx/frK9m5VjCK9vpcid8 oOL5yXbCP5CnifXiKCrF/EArKSnB784zqUfKi2/xwuJknbQo4Su8p9jN1GdzIvIY25btONtgOo/ EuxTRJ0fagaIwkbYAfNGXfpg5UplCjY1788H9Lu7T1uibr5lLhxZ5NZTbf6+GMxPDs6i16SVbET B7VhY0lJQbb822Rva4DVPKhwlJGj/SWd9BSzlJK5+KtAK X-Received: by 2002:a05:620a:4608:b0:80e:3af7:7a0c with SMTP id af79cd13be357-8cda1a2d86dmr478179485a.43.1773260259852; Wed, 11 Mar 2026 13:17:39 -0700 (PDT) X-Received: by 2002:a05:620a:4608:b0:80e:3af7:7a0c with SMTP id af79cd13be357-8cda1a2d86dmr478176585a.43.1773260259393; Wed, 11 Mar 2026 13:17:39 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.94]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4854b65fd3dsm79257255e9.10.2026.03.11.13.17.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 13:17:38 -0700 (PDT) From: Krzysztof Kozlowski Date: Wed, 11 Mar 2026 21:17:26 +0100 Subject: [PATCH 2/7] drm/msm/hdmi: Avoid double error print on msm_hdmi_get_phy() failure MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260311-drm-msm-hdmi-cleanup-v1-2-c5535245f6de@oss.qualcomm.com> References: <20260311-drm-msm-hdmi-cleanup-v1-0-c5535245f6de@oss.qualcomm.com> In-Reply-To: <20260311-drm-msm-hdmi-cleanup-v1-0-c5535245f6de@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=914; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=cKeuUxvKam9PYjthYzvdvrZ0HPds02yhZieULog6qvg=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpsc3XvpzTqDQBfvwACXsB3YLTwN5yo9Pd14XvD ywA1VAQbtyJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCabHN1wAKCRDBN2bmhouD 109ZD/4se3ojRQZtYZkaaQQDlKwDOo3S92l9zAVqZ0fXP2et9tbZltOtUyDphgaQ1tGglCwn0pA vkOn3KAMfUPGYoS0dx9YGttBI0GRE2PsAEawERzZp01fH/i4CKhICGVhCYdKs7jAMAq1uqTZ8cJ ZjF/JUf7yVQNIZFMLn660vp7GRDrlYG/1wik0SA2VmeBxw0dKWHZcBelbHRhbBwmKn62LYqj9XQ axg65JTZ14ab0y12qTGqOhWop5SlPFd//siYUhl6qFqE3wy2D3Ih0gUKH3JLUgVREfrYdURxqj3 6Gg56FETRpRnNX583bO7z9raBzHcqlCFqFJDZvOBvSnN00ROGo5/j3tGB5uHwRc6LOAf0prZ4nK Cx/Tq93mOcY538UehUbLughNs41PO+EtddMzmEkvi/j27IGTTCohT96fqoFkmNQd1YdGdPQuV6S RUYF2plnkzjtXFjnMoQtO8bMcimTFwDiVpBYjYVrTduiSDMJvB2Z5/f9YntDJ6kFKSMEZRW7Fw9 lj+FwYnsMSIuXEkzA/bmobBEQUtr1YtuTmHKQVYCG56KsGkgbZaNTvZNgOnoirNL1p4HUQrAnc6 zfd8tYD3sfpFRGB5hW1L9iG4E9oXMw/2CUDJ8hXHdYLMKesRsq2xj2QzszqqKauU+J6E98k2Hkh KoK0MUzqzV9vK+w== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-ORIG-GUID: cHT8lxdIl1x5cDxrAlAR_qRRgFBOHW2z X-Proofpoint-GUID: cHT8lxdIl1x5cDxrAlAR_qRRgFBOHW2z X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzExMDE3MiBTYWx0ZWRfX9FUXAUxvixSf suPAXjAG+aNxJ+Up0XhNvp6W3963oQSBH6tUDLcnu66TV0utSNpurjSDiry7YHBRbC6HKcnXAgH eG2PsgRfo/nGDnf3YjfieGerxcWsPxTgvM7UZ13wX9dXB5ovuOnzY+jhuHfbfRVHLlhP629Uu+y RNm4tO+UfylCv0F3dwaigG3g9g8U3kzSVkZWB2YM+N3gvrgjO8rxjElCHjudp4oaQ3LXkm/gsDM fk7NYOBjyF3Frxmi7WJZ6+rrVPYpPVg9cVHFZDfOVLlAHQQ0+YiP8gKn7fBA1hy4iZCcTZ4FL1Q 4quuzFwsVBrqq92kRonfVJv7H4TiHcggCXnbIbXI0ZLktp/nO63XmGuGdhNa58nFSv2rgem3IM0 yT6ynvfQFhx7wtbwWpzjHWQQ7S2GA9zyG8Jk9xGE0A566I1TDamR/Jmzf26z1FahwiqFA9fczVW 0pvoZl8Rwn3+K03sIlw== X-Authority-Analysis: v=2.4 cv=CKwnnBrD c=1 sm=1 tr=0 ts=69b1cde4 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=gOEeR9iKwsj33Yj5oN/cWg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=kDavz4lrka8aSrD8mlAA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-11_02,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 phishscore=0 impostorscore=0 spamscore=0 adultscore=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603110172 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" msm_hdmi_get_phy() already prints error messages on each error path using dev_err_probe(), so final DRM_DEV_ERROR() would duplicate it and possibly flood the dmesg on probe deferrals. Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/msm/hdmi/hdmi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c index b1db1b597901..02a87bccab77 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c @@ -358,10 +358,8 @@ static int msm_hdmi_dev_probe(struct platform_device *pdev) gpiod_set_consumer_name(hdmi->hpd_gpiod, "HDMI_HPD"); ret = msm_hdmi_get_phy(hdmi); - if (ret) { - DRM_DEV_ERROR(&pdev->dev, "failed to get phy\n"); + if (ret) return ret; - } ret = devm_pm_runtime_enable(&pdev->dev); if (ret) -- 2.51.0