From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B4231125893 for ; Wed, 11 Mar 2026 20:17:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1610610E91B; Wed, 11 Mar 2026 20:17:44 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="TmytrwWj"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gF9RF914"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3813110E916 for ; Wed, 11 Mar 2026 20:17:43 +0000 (UTC) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62BFpLF7351034 for ; Wed, 11 Mar 2026 20:17:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PmOhKe3gw//gTAh1/BLAwiMCIzc+UqKCl9Set3+LH0c=; b=TmytrwWjyv5Z2BvL P/9nk8lDH1JQQn7Yy5z+5LuW7EjUyD1CGgTeT5bZ2yOLwNaXg/P+UEhe9tNX4pKd AmjeGGxgXSf/OWuG/t34qll/Jo6ORphgxHY147jCV2Qck+S1RJdM1DACSk1lLjtD RUYw21Th3vfFhw84WH9jkXxlwCUM6baIC525FfGW7wfUSbHbDiJyg0mu/Hjwq2/H yUO0+06hfQFgh4ob4gBHxB0vsSHtJ0+3z1hJwQANu7t/O2ViyCYF/oxse3++8rgL qRe//GMxtHK3ipB1608A5MOEIeHhw0pcH1zE6AUaVWDPUzL3onsGLnVrNR1FUX/m +xbqTA== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cubd6gvu0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2026 20:17:42 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-899edf0171bso25337856d6.0 for ; Wed, 11 Mar 2026 13:17:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773260262; x=1773865062; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PmOhKe3gw//gTAh1/BLAwiMCIzc+UqKCl9Set3+LH0c=; b=gF9RF914oi5/Pj7YWgGULMMua/dXO0zJybWHN+q2zL1Cw4LrjqtWSNLdpl4Cl0PAnt x37eYlaY1MxwHBEs5QMVk5fZRY++w+Yf6FesZvTu2bhb+NkMjhG5OcYwf9vYAq6imE6j zzpCVsh2DiBzl6tIN6YNMr0kbCh3RaWQQL1ZbOcy4crlbpGTtiyhPL73owM+mEFj1ws/ suJQTu8bh8GvhwM3odh0Cg0sMsXpYc8tQ+w5hdXAWqlXL4M2oXiwFdn8p5c9gfxrgf9v NQRK0LSFoc4R5px0OrA1leulvkyWknmQL8TOZRy5T7eF0tqSaH/OngZIP3Nsep/lxyth ihLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773260262; x=1773865062; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=PmOhKe3gw//gTAh1/BLAwiMCIzc+UqKCl9Set3+LH0c=; b=YDAo2cG64SXpW/BcNlt/gY3nZNMs8A50+jT+rYkouLwHRvmuTPUfhGYEXyXHOr+bpU qRMh3V6xiS0qjHwIK2KUMxA/po6rwqSx45lDyw2BtQqmFo8tLNQ4X7iyrMnGJPvO4VZc eMeViQgyGVdX1a5KVwqt4YyNjAFQUcu/DrNKEIAuNcPfRIHQYhSbvO8MgahSJ8BrvO4U 29o69NIQushwWtlSjJtGEK2f3mnpgC5kOzKcjaGiuIkYp/5nenm51o9tUYR79EcSPWjf 3ddtgDwRGvTobnfS80xqMR+wF3w0QOLmSQGgmpsjxSH1jV7JWwUfoh4jj8AqD/goKJWk X6EQ== X-Forwarded-Encrypted: i=1; AJvYcCWpXlfj1AX+H0fOFABYJXdBpWZWqtQ7Szu5thqht2pAUKPBkfxWwt3nCfDTApXvwfj++KIG4ZfFPuI=@lists.freedesktop.org X-Gm-Message-State: AOJu0YxuumEtOwKx7C30GIgrHu9yLvGBhC5R0yOgvBJcJuA5kVnn1Ye4 LhvT0I8AWRrQoDCxeWCEVD/L6xRUs5LV9p4ueoebH0I5r0PpLTyLKErrI6WKCm3IA1Kdomr3UIC 9WSgD7zMAGDRRy/Y3PQslF8+OJD1zf/qy2wWaOV9tiH1JJe5oz0RM0aSCJrgmKL5eW7c/Sks= X-Gm-Gg: ATEYQzwqfUL1MyR5j8ddwVN6OXtYja92qD0BUS9LxFiztj9qC89lBSCLWXqGm2PB7C3 l7Si+JPj+iw5XYmKVNuNUuT1735e9GP+uH3HdwyL4FPHEkQ5nAam5KN2gVHpQVxm4LeU0pQ0mgM s/lAmZ5TqGdeFxC6twcP5sVC3xY5ycwMzhJPUm4L1Ria6n9UHOSsl6EwW55tyfyF9529X4RlWM4 q597GIRRmXydCB4xEqNIAItUermEyhCQrDlyyYZyjDB/yF29Mtkhzs+bmv771dSN1fvYXsbSbKt TL169c11iBp5F3PjaSb0u/un0ygyaV3ZAOWjha/ZNQOhL5E9p9BAoBNGdoMfxgeYXRsnzVUzB8O 7isuAlMYsTcsD/zscmr01u+/r0SP1ZaKNdFeYOAuy45No X-Received: by 2002:a05:620a:4551:b0:8cd:9707:6315 with SMTP id af79cd13be357-8cda19ba6a7mr469640385a.9.1773260261786; Wed, 11 Mar 2026 13:17:41 -0700 (PDT) X-Received: by 2002:a05:620a:4551:b0:8cd:9707:6315 with SMTP id af79cd13be357-8cda19ba6a7mr469635985a.9.1773260261325; Wed, 11 Mar 2026 13:17:41 -0700 (PDT) Received: from [127.0.1.1] ([178.197.219.94]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4854b65fd3dsm79257255e9.10.2026.03.11.13.17.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2026 13:17:40 -0700 (PDT) From: Krzysztof Kozlowski Date: Wed, 11 Mar 2026 21:17:27 +0100 Subject: [PATCH 3/7] drm/msm/hdmi: Simplify with local 'dev' variable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260311-drm-msm-hdmi-cleanup-v1-3-c5535245f6de@oss.qualcomm.com> References: <20260311-drm-msm-hdmi-cleanup-v1-0-c5535245f6de@oss.qualcomm.com> In-Reply-To: <20260311-drm-msm-hdmi-cleanup-v1-0-c5535245f6de@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3444; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=RQohQzLIQf3hMORNlnLcz8kcaLrfjYXvfR01RWX3LTw=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpsc3Yqd+dsT3DIQ78iz24qnrZhhO/+ftSvRWOQ HRQNVRH8PaJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCabHN2AAKCRDBN2bmhouD 1304D/9qVRxNtpbj1sx/tzTfek3tgBKdMTq2Rd9dY7xQthxc7+l1w0aOLM3kn485m3HbmKQFf0c ZKD5cywiRDL0qiR/AVyx3rY/60hJsq8fBv79AFUP/UzAx2teDyOML4f4JLo/kb9dz6+CE5yV3UG JttKc8rYlWBkhnPIaJacRH4I+boerfgSbMzRkJ8Mx/jM2jbYSGI7ufW757n048YGaWlcOyVeGTb E6CvbuLM/aav4NSueabeYSey2QNel/DFMNwPFQL5NQ515HAtqJA1MmPGNvRpjMCaeQ3Vaa3nUVT ncXPjGluz9K+dVxBjwvYgAQmIu1Qk6bBRdKkYW4zo7Uqop4NxH9dVe8K81laegNGBzJJ+KLdMae kHqAp9iginpThurWsPVU55XXLYhn0IsIyd8ha6ZjF+kmAp/qenpHAjwS7jBm8c3gRz2DzL5x7H1 xe+iEjm4FMAlGoht4MqiyeMEjwyeHR2BTmRpTSSeVLOyxg0H+gH1fjRHUJ4nRZO61Nhidh9Vqmh FCFIJ0WLS7AQUU0aQf8n5ayEuhbYPUHSEwDcd3u9a3oqD8AvknXZJ6n/4qvE2HmDjeDbNdzmtTL 9+iuVKr8v7YQAxLKZfP76UyIpqMlc0QzpBFZuFnIyFmAanYaRmElEZ9bpYq5L0q5Z50zMZx1Uvv c3X3/tiRd2ZvpjA== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Authority-Analysis: v=2.4 cv=OvdCCi/t c=1 sm=1 tr=0 ts=69b1cde6 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=gOEeR9iKwsj33Yj5oN/cWg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=Gs1e6ZCtzmPehomhPS4A:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzExMDE3MiBTYWx0ZWRfX9U/wYb80C1G0 9U5AUpfCxWlb4SzL2hTHJqsj3QnTvzo118MOUw2Z+DQSNEN5tAXerQ2lZjrhmKyhSZxKYYU0rlm KLoILJJKUYA7CWm2kHXJgiAFCkkequEvlQW4H9nAYNme2scVR6hHpdI+uZ9nldAkVZ/7BYN5K4m dYM9griXfdC2L3DTVGtfycwqGURGT2U7wYXGY+0iLhvgDOfS7y95GlHXaz/qv4grgXjTeraA4fv nFRpKT1HYp4dpfRl1kjdxMRMm8Bbx/eZBB2h352be3vAaNRGxh7sZIwS/1DamQVuwZxigoO7E4f G4Ss+tPkC8+XNbCeXY63fp5nHNK2GrJgU7sNCLPBx7CIj+GMW/2hdh9K9wPCawCG2kait5hrXzl D27lzzV+G8a9UUW8pph2UbwALRgFgPFevdPEF0A+VKfdp/L36nrPyWAvzm9yrzwOaoGthql0ukw wPvvhX+ew+gsURYB9Cw== X-Proofpoint-GUID: zlA8sIPQSm0fJwGEYWjQ0E3kesDVIsNs X-Proofpoint-ORIG-GUID: zlA8sIPQSm0fJwGEYWjQ0E3kesDVIsNs X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-11_02,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 impostorscore=0 phishscore=0 malwarescore=0 suspectscore=0 adultscore=0 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603110172 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" msm_hdmi_dev_probe() function already stores pdev->dev in local variable, so use it directly to make code simpler. Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/msm/hdmi/hdmi.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c index 02a87bccab77..03aa29dbb2f5 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c @@ -278,7 +278,7 @@ static int msm_hdmi_dev_probe(struct platform_device *pdev) if (!config) return -EINVAL; - hdmi = devm_kzalloc(&pdev->dev, sizeof(*hdmi), GFP_KERNEL); + hdmi = devm_kzalloc(dev, sizeof(*hdmi), GFP_KERNEL); if (!hdmi) return -ENOMEM; @@ -304,7 +304,7 @@ static int msm_hdmi_dev_probe(struct platform_device *pdev) hdmi->qfprom_mmio = msm_ioremap(pdev, "qfprom_physical"); if (IS_ERR(hdmi->qfprom_mmio)) { - DRM_DEV_INFO(&pdev->dev, "can't find qfprom resource\n"); + DRM_DEV_INFO(dev, "can't find qfprom resource\n"); hdmi->qfprom_mmio = NULL; } @@ -312,8 +312,7 @@ static int msm_hdmi_dev_probe(struct platform_device *pdev) if (hdmi->irq < 0) return hdmi->irq; - hdmi->pwr_regs = devm_kcalloc(&pdev->dev, - config->pwr_reg_cnt, + hdmi->pwr_regs = devm_kcalloc(dev, config->pwr_reg_cnt, sizeof(hdmi->pwr_regs[0]), GFP_KERNEL); if (!hdmi->pwr_regs) @@ -322,12 +321,11 @@ static int msm_hdmi_dev_probe(struct platform_device *pdev) for (i = 0; i < config->pwr_reg_cnt; i++) hdmi->pwr_regs[i].supply = config->pwr_reg_names[i]; - ret = devm_regulator_bulk_get(&pdev->dev, config->pwr_reg_cnt, hdmi->pwr_regs); + ret = devm_regulator_bulk_get(dev, config->pwr_reg_cnt, hdmi->pwr_regs); if (ret) return dev_err_probe(dev, ret, "failed to get pwr regulators\n"); - hdmi->pwr_clks = devm_kcalloc(&pdev->dev, - config->pwr_clk_cnt, + hdmi->pwr_clks = devm_kcalloc(dev, config->pwr_clk_cnt, sizeof(hdmi->pwr_clks[0]), GFP_KERNEL); if (!hdmi->pwr_clks) @@ -336,16 +334,16 @@ static int msm_hdmi_dev_probe(struct platform_device *pdev) for (i = 0; i < config->pwr_clk_cnt; i++) hdmi->pwr_clks[i].id = config->pwr_clk_names[i]; - ret = devm_clk_bulk_get(&pdev->dev, config->pwr_clk_cnt, hdmi->pwr_clks); + ret = devm_clk_bulk_get(dev, config->pwr_clk_cnt, hdmi->pwr_clks); if (ret) return ret; - hdmi->extp_clk = devm_clk_get_optional(&pdev->dev, "extp"); + hdmi->extp_clk = devm_clk_get_optional(dev, "extp"); if (IS_ERR(hdmi->extp_clk)) return dev_err_probe(dev, PTR_ERR(hdmi->extp_clk), "failed to get extp clock\n"); - hdmi->hpd_gpiod = devm_gpiod_get_optional(&pdev->dev, "hpd", GPIOD_IN); + hdmi->hpd_gpiod = devm_gpiod_get_optional(dev, "hpd", GPIOD_IN); /* This will catch e.g. -EPROBE_DEFER */ if (IS_ERR(hdmi->hpd_gpiod)) return dev_err_probe(dev, PTR_ERR(hdmi->hpd_gpiod), @@ -361,13 +359,13 @@ static int msm_hdmi_dev_probe(struct platform_device *pdev) if (ret) return ret; - ret = devm_pm_runtime_enable(&pdev->dev); + ret = devm_pm_runtime_enable(dev); if (ret) goto err_put_phy; platform_set_drvdata(pdev, hdmi); - ret = component_add(&pdev->dev, &msm_hdmi_ops); + ret = component_add(dev, &msm_hdmi_ops); if (ret) goto err_put_phy; -- 2.51.0