From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A6FFFD88DA for ; Wed, 11 Mar 2026 09:09:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EDC7210E3A1; Wed, 11 Mar 2026 09:09:01 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="bDkzIbLO"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3B30F10E3A1 for ; Wed, 11 Mar 2026 09:09:00 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 513A86012A; Wed, 11 Mar 2026 09:08:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6AA2C4CEF7; Wed, 11 Mar 2026 09:08:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773220139; bh=QmMRcyr8cPQR0MBzpuW18tVPDlR+PLdqMUtnqfdQuWA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bDkzIbLOOxTU/2T/UBRhLPy0pXrulO+dRfcILugrDDsVQTtavO5w9ullnZKuRSJ+4 nJU1zZbiT0I4v2DLOyGIRsYWvd7Pb2ugJTywVjdA6yX2DsBosmonXQKENfgJjuG1wF 0ROfCG8XQZ2N+YSvkBazdKezBWqrBlqcqR5bRD16O0bbshLEvalC2MKBblcQT+hw4s Usw/hO/sI3/Pc1f12XqYVEDlAaFFb2JQeKzTT84zs2ko4a9RqblE0dmLIZK+89/2HG T8Er3SV6AwI6ALySu5maZAL2YI2NeMj6tPPhID6S1ZCJMrW5KAZbd3MiDV8f5RUuER pErCINqf+m+Cg== Date: Wed, 11 Mar 2026 10:08:56 +0100 From: Maxime Ripard To: Tomi Valkeinen Cc: Jyri Sarha , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Sam Ravnborg , Javier Martinez Canillas , Aradhya Bhatia , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Devarsh Thakkar , stable@vger.kernel.org Subject: Re: [PATCH 2/2] drm/tidss: Fix missing drm_bridge_attach() call Message-ID: <20260311-spirited-mighty-grouse-e0b1cb@houat> References: <20260311-tidss-minor-fixes-v1-0-ee5e6e14a566@ideasonboard.com> <20260311-tidss-minor-fixes-v1-2-ee5e6e14a566@ideasonboard.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha384; protocol="application/pgp-signature"; boundary="ozhc3zbwh5ezmexs" Content-Disposition: inline In-Reply-To: <20260311-tidss-minor-fixes-v1-2-ee5e6e14a566@ideasonboard.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --ozhc3zbwh5ezmexs Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH 2/2] drm/tidss: Fix missing drm_bridge_attach() call MIME-Version: 1.0 On Wed, Mar 11, 2026 at 10:16:29AM +0200, Tomi Valkeinen wrote: > tidss encoder-bridge is not added with drm_bridge_add() call, which > leads to: >=20 > [drm] Missing drm_bridge_add() before attach >=20 > Add the missing call, using devm_drm_bridge_add() variant to get the > drm_bridge_remove() handled automatically. The patch itself is fine, but the commit title mentions a missing drm_bridge_attach() call when it should be drm_bridge_add() With that fixed Acked-by: Maxime Ripard Maxime --ozhc3zbwh5ezmexs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCabExIwAKCRAnX84Zoj2+ diJkAX9wcYxbDxiUoCf43yOD93OT3iBlQlTM5ZG8WHo/dzCTlLJe7MA+asG9K12l 8Yi8/YgBgNY+UgM30pgZlDPZlgir/jIhxG2Du0rF/lLb0FS/IHpRB+wGVVVJhdiL dTTFPo6XfA== =KVb4 -----END PGP SIGNATURE----- --ozhc3zbwh5ezmexs--