public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Parth Pancholi <parth.pancholi@toradex.com>,
	Francesco Dolcini <francesco.dolcini@toradex.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
	João Paulo Gonçalves <joao.goncalves@toradex.com>,
	Dmitry Osipenko <digetx@gmail.com>
Subject: [PATCH v2 0/7] drm/bridge: tc358768: Long command support
Date: Wed, 11 Mar 2026 09:48:11 +0200	[thread overview]
Message-ID: <20260311-tc358768-v2-0-e75a99131bd5@ideasonboard.com> (raw)

This series makes some small improvements to the tc358768 driver, and
then adds support for long commands, commands that have more than 8
bytes of payload.

This has been tested on Toradex Verdin AM62 board, with a ST7703 based
DSI panel which requires initial configuration using commands that have
8+ bytes.

I tested the following combinations, by observing the panel visually and
the DSI lanes with an oscilloscope:

- HS command transfer, continuous clock
- HS command transfer, non-continuous clock
- LP command transfer, continuous clock
- LP command transfer, non-continuous clock

All except LP + continuous clock work fine. While observing the lanes
with normal oscilloscope is a very high level and vague view of what
exactly is going on the lanes, it still looks good to me: initial
commands are sent in LP, and then video data is being sent in HS, and
clock lane is continuous. However, the panel stays black, so something
is not quite right.

As it doesn't make sense to send commands in LP during initial
configuration, especially with longer commands, I will leave that
particular combination unresolved. I'd be interested to hear if it works
on some other panel.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
---
Changes in v2:
- Add reviewed-by & tested-by tags
- Rebase on v7.0-rc2
- Link to v1: https://lore.kernel.org/r/20251021-tc358768-v1-0-d590dc6a1a0c@ideasonboard.com

---
Parth Pancholi (1):
      drm/bridge: tc358768: Set pre_enable_prev_first for reverse order

Tomi Valkeinen (6):
      drm/bridge: tc358768: Fix typo in TC358768_DSI_CONTROL_DIS_MODE
      drm/bridge: tc358768: Separate indirect register writes
      drm/bridge: tc358768: Support non-continuous clock
      drm/bridge: tc358768: Add LP mode command support
      drm/bridge: tc358768: Separate video format config
      drm/bridge: tc358768: Add support for long command tx via video buffer

 drivers/gpu/drm/bridge/tc358768.c | 202 +++++++++++++++++++++++++++++---------
 1 file changed, 157 insertions(+), 45 deletions(-)
---
base-commit: 11439c4635edd669ae435eec308f4ab8a0804808
change-id: 20251021-tc358768-93eb23689b7a

Best regards,
-- 
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>


             reply	other threads:[~2026-03-11  7:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11  7:48 Tomi Valkeinen [this message]
2026-03-11  7:48 ` [PATCH v2 1/7] drm/bridge: tc358768: Fix typo in TC358768_DSI_CONTROL_DIS_MODE Tomi Valkeinen
2026-03-11 21:14   ` Claude review: " Claude Code Review Bot
2026-03-11  7:48 ` [PATCH v2 2/7] drm/bridge: tc358768: Set pre_enable_prev_first for reverse order Tomi Valkeinen
2026-03-11 21:14   ` Claude review: " Claude Code Review Bot
2026-03-11  7:48 ` [PATCH v2 3/7] drm/bridge: tc358768: Separate indirect register writes Tomi Valkeinen
2026-03-11 21:14   ` Claude review: " Claude Code Review Bot
2026-03-11  7:48 ` [PATCH v2 4/7] drm/bridge: tc358768: Support non-continuous clock Tomi Valkeinen
2026-03-11 21:14   ` Claude review: " Claude Code Review Bot
2026-03-11  7:48 ` [PATCH v2 5/7] drm/bridge: tc358768: Add LP mode command support Tomi Valkeinen
2026-03-11 21:14   ` Claude review: " Claude Code Review Bot
2026-03-11  7:48 ` [PATCH v2 6/7] drm/bridge: tc358768: Separate video format config Tomi Valkeinen
2026-03-11 21:14   ` Claude review: " Claude Code Review Bot
2026-03-11  7:48 ` [PATCH v2 7/7] drm/bridge: tc358768: Add support for long command tx via video buffer Tomi Valkeinen
2026-03-11 21:14   ` Claude review: " Claude Code Review Bot
2026-03-11 21:14 ` Claude review: drm/bridge: tc358768: Long command support Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260311-tc358768-v2-0-e75a99131bd5@ideasonboard.com \
    --to=tomi.valkeinen@ideasonboard.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=digetx@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=francesco.dolcini@toradex.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=joao.goncalves@toradex.com \
    --cc=jonas@kwiboo.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=parth.pancholi@toradex.com \
    --cc=rfoss@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox